From: Doug Goldstein <cardoe@cardoe.com>
To: Ian Campbell <ian.campbell@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] arm: clean up build variables
Date: Wed, 27 Jan 2016 09:26:58 -0600 [thread overview]
Message-ID: <56A8E1C2.6030108@cardoe.com> (raw)
In-Reply-To: <1453908284.26591.30.camel@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1622 bytes --]
On 1/27/16 9:24 AM, Ian Campbell wrote:
> On Wed, 2016-01-27 at 09:11 -0600, Doug Goldstein wrote:
>> On 1/27/16 9:05 AM, Ian Campbell wrote:
>>> On Wed, 2016-01-27 at 07:44 -0700, Jan Beulich wrote:
>>>>>>> On 27.01.16 at 15:30, <cardoe@cardoe.com> wrote:
>>>>> On 1/25/16 5:27 AM, Ian Campbell wrote:
>>>>>> On Wed, 2016-01-20 at 15:47 -0600, Doug Goldstein wrote:
>>>>>>> @@ -52,7 +52,7 @@ ALL_OBJS := $(TARGET_SUBARCH)/head.o
>>>>>>> $(ALL_OBJS)
>>>>>>>
>>>>>>> $(TARGET): $(TARGET)-syms $(TARGET).axf
>>>>>>> $(OBJCOPY) -O binary -S $< $@
>>>>>>> -ifeq (arm64,$(XEN_TARGET_ARCH))
>>>>>>> +ifdef CONFIG_ARM_64
>>>>>>
>>>>>> The old way looks to be the prevailing normal form. I don't
>>>>>> especially
>>>>>> object to the change but things ought to remain consistent.
>>>>>
>>>>> Which part? Using arm32/arm64? Or having the if blocks rather than
>>>>> var-$(CONFIG_THING) ?
>>>>>
>>>>> My goal here is consistency and that was to standardize on the form
>>>>> of
>>>>> var-$(CONFIG_THING) across the board.
>>>>
>>>> But there's no var-$(CONFIG_THING) in the code above.
>>>
>>> Indeed, I was referring to the change from:
>>>
>>> -ifeq (arm64,$(XEN_TARGET_ARCH))
>>>
>>> to
>>>
>>> +ifdef CONFIG_ARM_64
>>>
>>> While:
>>>
>>> ifeq ($(CONFIG_ARM_64),y)
>>>
>>> is the more prevalent style.
>>>
>>> Ian.
>>>
>>
>> Oh sure. We can do that. Would you like me to send a v2 or are you
>> comfortable squashing that into the patch?
>
> I may as well just do it, thanks.
>
>
I'll change my style going forward to use that form as well.
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-01-27 15:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 21:47 [PATCH] arm: clean up build variables Doug Goldstein
2016-01-21 10:56 ` Jan Beulich
2016-01-25 11:27 ` Ian Campbell
2016-01-27 14:30 ` Doug Goldstein
2016-01-27 14:44 ` Jan Beulich
2016-01-27 15:05 ` Ian Campbell
2016-01-27 15:11 ` Doug Goldstein
2016-01-27 15:24 ` Ian Campbell
2016-01-27 15:26 ` Doug Goldstein [this message]
2016-01-29 14:35 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A8E1C2.6030108@cardoe.com \
--to=cardoe@cardoe.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.