From: Eric Anholt <eric@anholt.net> To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>, Eric Anholt <eric@anholt.net> Subject: [PATCH 5/6] drm/vc4: Fix setting of vertical timings in the CRTC. Date: Tue, 16 Feb 2016 13:20:18 -0800 [thread overview] Message-ID: <1455657619-12030-6-git-send-email-eric@anholt.net> (raw) In-Reply-To: <1455657619-12030-1-git-send-email-eric@anholt.net> It looks like when I went to add the interlaced bits, I just took the existing PV_VERT* block and indented it, instead of copy and pasting it first. Without this, changing resolution never worked. Signed-off-by: Eric Anholt <eric@anholt.net> --- drivers/gpu/drm/vc4/vc4_crtc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 5daa824..89562904 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -217,6 +217,16 @@ static void vc4_crtc_mode_set_nofb(struct drm_crtc *crtc) PV_HORZB_HFP) | VC4_SET_FIELD(mode->hdisplay, PV_HORZB_HACTIVE)); + CRTC_WRITE(PV_VERTA, + VC4_SET_FIELD(mode->vtotal - mode->vsync_end, + PV_VERTA_VBP) | + VC4_SET_FIELD(mode->vsync_end - mode->vsync_start, + PV_VERTA_VSYNC)); + CRTC_WRITE(PV_VERTB, + VC4_SET_FIELD(mode->vsync_start - mode->vdisplay, + PV_VERTB_VFP) | + VC4_SET_FIELD(vactive, PV_VERTB_VACTIVE)); + if (interlace) { CRTC_WRITE(PV_VERTA_EVEN, VC4_SET_FIELD(mode->vtotal - mode->vsync_end - 1, -- 2.7.0
WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net> To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH 5/6] drm/vc4: Fix setting of vertical timings in the CRTC. Date: Tue, 16 Feb 2016 13:20:18 -0800 [thread overview] Message-ID: <1455657619-12030-6-git-send-email-eric@anholt.net> (raw) In-Reply-To: <1455657619-12030-1-git-send-email-eric@anholt.net> It looks like when I went to add the interlaced bits, I just took the existing PV_VERT* block and indented it, instead of copy and pasting it first. Without this, changing resolution never worked. Signed-off-by: Eric Anholt <eric@anholt.net> --- drivers/gpu/drm/vc4/vc4_crtc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 5daa824..89562904 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -217,6 +217,16 @@ static void vc4_crtc_mode_set_nofb(struct drm_crtc *crtc) PV_HORZB_HFP) | VC4_SET_FIELD(mode->hdisplay, PV_HORZB_HACTIVE)); + CRTC_WRITE(PV_VERTA, + VC4_SET_FIELD(mode->vtotal - mode->vsync_end, + PV_VERTA_VBP) | + VC4_SET_FIELD(mode->vsync_end - mode->vsync_start, + PV_VERTA_VSYNC)); + CRTC_WRITE(PV_VERTB, + VC4_SET_FIELD(mode->vsync_start - mode->vdisplay, + PV_VERTB_VFP) | + VC4_SET_FIELD(vactive, PV_VERTB_VACTIVE)); + if (interlace) { CRTC_WRITE(PV_VERTA_EVEN, VC4_SET_FIELD(mode->vtotal - mode->vsync_end - 1, -- 2.7.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-02-16 21:22 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-16 21:20 drm/vc4: Modesetting fixes Eric Anholt 2016-02-16 21:20 ` Eric Anholt 2016-02-16 21:20 ` [PATCH 1/6] drm/vc4: Fix a framebuffer reference leak on async flip interrupt Eric Anholt 2016-02-16 21:20 ` Eric Anholt 2016-02-16 21:20 ` [PATCH 2/6] drm/vc4: Bring HDMI up from power off if necessary Eric Anholt 2016-02-16 21:20 ` Eric Anholt 2016-02-16 21:20 ` [PATCH 3/6] drm/vc4: Add another reg to HDMI debug dumping Eric Anholt 2016-02-16 21:20 ` Eric Anholt 2016-02-16 21:20 ` [PATCH 4/6] drm/vc4: Fix the name of the VSYNCD_EVEN register Eric Anholt 2016-02-16 21:20 ` Eric Anholt 2016-02-16 21:20 ` Eric Anholt [this message] 2016-02-16 21:20 ` [PATCH 5/6] drm/vc4: Fix setting of vertical timings in the CRTC Eric Anholt 2016-02-16 21:20 ` [PATCH 6/6] drm/vc4: Initialize scaler DISPBKGND on modeset Eric Anholt 2016-02-16 21:20 ` Eric Anholt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1455657619-12030-6-git-send-email-eric@anholt.net \ --to=eric@anholt.net \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.