From: Jon Hunter <jonathanh@nvidia.com> To: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Kevin Hilman <khilman@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org> Cc: Thierry Reding <thierry.reding@gmail.com>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, Alexander Aring <alex.aring@gmail.com>, Eric Anholt <eric@anholt.net>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, Jon Hunter <jonathanh@nvidia.com> Subject: [RFC PATCH 4/8] PM / Domains: Don't expose generic_pm_domain structure Date: Fri, 4 Mar 2016 11:23:50 +0000 [thread overview] Message-ID: <1457090634-14785-5-git-send-email-jonathanh@nvidia.com> (raw) In-Reply-To: <1457090634-14785-1-git-send-email-jonathanh@nvidia.com> There should be no need to expose the generic_pm_domain structure and this eliminates the need to implement reference counting for any external reference to a PM domain. Therefore, make the functions pm_genpd_lookup_dev() and of_genpd_get_from_provider() private to the PM domain core. Signed-off-by: Jon Hunter <jonathanh@nvidia.com> --- drivers/base/power/domain.c | 5 ++--- include/linux/pm_domain.h | 14 -------------- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index b24893499454..c2ba1d6dbad3 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -45,7 +45,7 @@ static DEFINE_MUTEX(gpd_list_lock); * and checks that the PM domain pointer is a real generic PM domain. * Any failure results in NULL being returned. */ -struct generic_pm_domain *pm_genpd_lookup_dev(struct device *dev) +static struct generic_pm_domain *pm_genpd_lookup_dev(struct device *dev) { struct generic_pm_domain *genpd = NULL, *gpd; @@ -1680,7 +1680,7 @@ EXPORT_SYMBOL_GPL(of_genpd_del_provider); * Returns a valid pointer to struct generic_pm_domain on success or ERR_PTR() * on failure. */ -struct generic_pm_domain *of_genpd_get_from_provider( +static struct generic_pm_domain *of_genpd_get_from_provider( struct of_phandle_args *genpdspec) { struct generic_pm_domain *genpd = ERR_PTR(-ENOENT); @@ -1703,7 +1703,6 @@ struct generic_pm_domain *of_genpd_get_from_provider( return genpd; } -EXPORT_SYMBOL_GPL(of_genpd_get_from_provider); /** * of_genpd_add_device() - Add a device to an I/O PM domain diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index 2b6ee670b231..510512d5390e 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -119,7 +119,6 @@ static inline struct generic_pm_domain_data *dev_gpd_data(struct device *dev) return to_gpd_data(dev->power.subsys_data->domain_data); } -extern struct generic_pm_domain *pm_genpd_lookup_dev(struct device *dev); extern int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev, struct gpd_timing_data *td); @@ -141,10 +140,6 @@ static inline struct generic_pm_domain_data *dev_gpd_data(struct device *dev) { return ERR_PTR(-ENOSYS); } -static inline struct generic_pm_domain *pm_genpd_lookup_dev(struct device *dev) -{ - return NULL; -} static inline int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev, struct gpd_timing_data *td) @@ -201,9 +196,6 @@ typedef struct generic_pm_domain *(*genpd_xlate_t)(struct of_phandle_args *args, int __of_genpd_add_provider(struct device_node *np, genpd_xlate_t xlate, void *data); void of_genpd_del_provider(struct device_node *np); -struct generic_pm_domain *of_genpd_get_from_provider( - struct of_phandle_args *genpdspec); - struct generic_pm_domain *__of_genpd_xlate_simple( struct of_phandle_args *genpdspec, void *data); @@ -224,12 +216,6 @@ static inline int __of_genpd_add_provider(struct device_node *np, } static inline void of_genpd_del_provider(struct device_node *np) {} -static inline struct generic_pm_domain *of_genpd_get_from_provider( - struct of_phandle_args *genpdspec) -{ - return NULL; -} - #define __of_genpd_xlate_simple NULL #define __of_genpd_xlate_onecell NULL -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: jonathanh@nvidia.com (Jon Hunter) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 4/8] PM / Domains: Don't expose generic_pm_domain structure Date: Fri, 4 Mar 2016 11:23:50 +0000 [thread overview] Message-ID: <1457090634-14785-5-git-send-email-jonathanh@nvidia.com> (raw) In-Reply-To: <1457090634-14785-1-git-send-email-jonathanh@nvidia.com> There should be no need to expose the generic_pm_domain structure and this eliminates the need to implement reference counting for any external reference to a PM domain. Therefore, make the functions pm_genpd_lookup_dev() and of_genpd_get_from_provider() private to the PM domain core. Signed-off-by: Jon Hunter <jonathanh@nvidia.com> --- drivers/base/power/domain.c | 5 ++--- include/linux/pm_domain.h | 14 -------------- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index b24893499454..c2ba1d6dbad3 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -45,7 +45,7 @@ static DEFINE_MUTEX(gpd_list_lock); * and checks that the PM domain pointer is a real generic PM domain. * Any failure results in NULL being returned. */ -struct generic_pm_domain *pm_genpd_lookup_dev(struct device *dev) +static struct generic_pm_domain *pm_genpd_lookup_dev(struct device *dev) { struct generic_pm_domain *genpd = NULL, *gpd; @@ -1680,7 +1680,7 @@ EXPORT_SYMBOL_GPL(of_genpd_del_provider); * Returns a valid pointer to struct generic_pm_domain on success or ERR_PTR() * on failure. */ -struct generic_pm_domain *of_genpd_get_from_provider( +static struct generic_pm_domain *of_genpd_get_from_provider( struct of_phandle_args *genpdspec) { struct generic_pm_domain *genpd = ERR_PTR(-ENOENT); @@ -1703,7 +1703,6 @@ struct generic_pm_domain *of_genpd_get_from_provider( return genpd; } -EXPORT_SYMBOL_GPL(of_genpd_get_from_provider); /** * of_genpd_add_device() - Add a device to an I/O PM domain diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index 2b6ee670b231..510512d5390e 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -119,7 +119,6 @@ static inline struct generic_pm_domain_data *dev_gpd_data(struct device *dev) return to_gpd_data(dev->power.subsys_data->domain_data); } -extern struct generic_pm_domain *pm_genpd_lookup_dev(struct device *dev); extern int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev, struct gpd_timing_data *td); @@ -141,10 +140,6 @@ static inline struct generic_pm_domain_data *dev_gpd_data(struct device *dev) { return ERR_PTR(-ENOSYS); } -static inline struct generic_pm_domain *pm_genpd_lookup_dev(struct device *dev) -{ - return NULL; -} static inline int __pm_genpd_add_device(struct generic_pm_domain *genpd, struct device *dev, struct gpd_timing_data *td) @@ -201,9 +196,6 @@ typedef struct generic_pm_domain *(*genpd_xlate_t)(struct of_phandle_args *args, int __of_genpd_add_provider(struct device_node *np, genpd_xlate_t xlate, void *data); void of_genpd_del_provider(struct device_node *np); -struct generic_pm_domain *of_genpd_get_from_provider( - struct of_phandle_args *genpdspec); - struct generic_pm_domain *__of_genpd_xlate_simple( struct of_phandle_args *genpdspec, void *data); @@ -224,12 +216,6 @@ static inline int __of_genpd_add_provider(struct device_node *np, } static inline void of_genpd_del_provider(struct device_node *np) {} -static inline struct generic_pm_domain *of_genpd_get_from_provider( - struct of_phandle_args *genpdspec) -{ - return NULL; -} - #define __of_genpd_xlate_simple NULL #define __of_genpd_xlate_onecell NULL -- 2.1.4
next prev parent reply other threads:[~2016-03-04 11:23 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-04 11:23 [RFC PATCH 0/8] PM / Domains: Add support for removing PM domains Jon Hunter 2016-03-04 11:23 ` Jon Hunter 2016-03-04 11:23 ` [RFC PATCH 3/8] staging: board: Remove calls to of_genpd_get_from_provider() Jon Hunter 2016-03-04 11:23 ` Jon Hunter 2016-03-04 11:23 ` Jon Hunter [this message] 2016-03-04 11:23 ` [RFC PATCH 4/8] PM / Domains: Don't expose generic_pm_domain structure Jon Hunter 2016-08-05 11:55 ` Ulf Hansson 2016-08-05 11:55 ` Ulf Hansson [not found] ` <1457090634-14785-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2016-03-04 11:23 ` [RFC PATCH 1/8] PM / Domains: Add new helper functions for device-tree Jon Hunter 2016-03-04 11:23 ` Jon Hunter 2016-06-22 11:00 ` Jon Hunter 2016-06-22 11:00 ` Jon Hunter 2016-06-22 14:58 ` Jon Hunter 2016-06-22 14:58 ` Jon Hunter 2016-06-22 15:08 ` Ulf Hansson 2016-06-22 15:08 ` Ulf Hansson 2016-06-22 15:22 ` Jon Hunter 2016-06-22 15:22 ` Jon Hunter 2016-06-22 15:36 ` Ulf Hansson 2016-06-22 15:36 ` Ulf Hansson 2016-03-04 11:23 ` [RFC PATCH 2/8] ARM: EXYNOS: Remove calls to of_genpd_get_from_provider() Jon Hunter 2016-03-04 11:23 ` Jon Hunter 2016-03-04 11:23 ` [RFC PATCH 5/8] PM / Domains: Verify the PM domain is present when adding a provider Jon Hunter 2016-03-04 11:23 ` Jon Hunter 2016-08-05 11:57 ` Ulf Hansson 2016-08-05 11:57 ` Ulf Hansson 2016-03-04 11:23 ` [RFC PATCH 7/8] PM / Domains: Prepare for adding support to remove PM domains Jon Hunter 2016-03-04 11:23 ` Jon Hunter 2016-03-04 12:33 ` [RFC PATCH 0/8] PM / Domains: Add support for removing " Ulf Hansson 2016-03-04 12:33 ` Ulf Hansson [not found] ` <CAPDyKFq3hNARzjSOoP+-NmcgfSWzG6GDmh7qVX6yx6QPgN9Arw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-03-28 12:38 ` Jon Hunter 2016-03-28 12:38 ` Jon Hunter [not found] ` <56F925D9.3080703-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2016-06-06 13:19 ` Jon Hunter 2016-06-06 13:19 ` Jon Hunter 2016-06-15 14:46 ` Ulf Hansson 2016-06-15 14:46 ` Ulf Hansson 2016-03-04 11:23 ` [RFC PATCH 6/8] PM / Domains: Remove a provider by referencing the data pointer Jon Hunter 2016-03-04 11:23 ` Jon Hunter [not found] ` <1457090634-14785-7-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2016-06-15 14:38 ` Ulf Hansson 2016-06-15 14:38 ` Ulf Hansson 2016-06-21 13:47 ` Jon Hunter 2016-06-21 13:47 ` Jon Hunter [not found] ` <5769455C.9010809-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2016-07-11 13:14 ` Jon Hunter 2016-07-11 13:14 ` Jon Hunter 2016-08-05 11:55 ` Ulf Hansson 2016-08-05 11:55 ` Ulf Hansson [not found] ` <CAPDyKFovC07Z9y-4RQ4MKGtjJx5w1D8er3Fv-8HF2qyTKgVViQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-08-11 16:39 ` Jon Hunter 2016-08-11 16:39 ` Jon Hunter [not found] ` <18ad702c-83fe-fd6d-89ae-57e6f2715860-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2016-08-12 0:24 ` Rafael J. Wysocki 2016-08-12 0:24 ` Rafael J. Wysocki 2016-06-21 14:45 ` Jon Hunter 2016-06-21 14:45 ` Jon Hunter 2016-03-04 11:23 ` [RFC PATCH 8/8] PM / Domains: Add support for removing PM domains Jon Hunter 2016-03-04 11:23 ` Jon Hunter [not found] ` <1457090634-14785-9-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2016-06-15 14:33 ` Ulf Hansson 2016-06-15 14:33 ` Ulf Hansson 2016-06-21 14:08 ` Jon Hunter 2016-06-21 14:08 ` Jon Hunter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1457090634-14785-5-git-send-email-jonathanh@nvidia.com \ --to=jonathanh@nvidia.com \ --cc=alex.aring@gmail.com \ --cc=eric@anholt.net \ --cc=k.kozlowski@samsung.com \ --cc=kgene@kernel.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=thierry.reding@gmail.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.