From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] nfit, libnvdimm: clear poison command support
Date: Wed, 9 Mar 2016 23:03:59 +0000 [thread overview]
Message-ID: <1457564634.4525.32.camel@intel.com> (raw)
In-Reply-To: <20160308224718.16298.47066.stgit@dwillia2-desk3.jf.intel.com>
On Tue, 2016-03-08 at 14:47 -0800, Dan Williams wrote:
> Add the boiler-plate for a 'clear error' command based on section
> 9.20.7.6 "Function Index 4 - Clear Uncorrectable Error" from the ACPI
> 6.1 specification, and add a reference implementation in nfit_test.
>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/acpi/nfit.c | 12 +++++++++++-
> drivers/nvdimm/bus.c | 19 +++++++++++++++++++
> include/uapi/linux/ndctl.h | 13 +++++++++++++
> tools/testing/nvdimm/test/nfit.c | 29 +++++++++++++++++++++++++++++
> 4 files changed, 72 insertions(+), 1 deletion(-)
>
<snip>
> diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h
> index cc68b92124d4..0f001c571cdd 100644
> --- a/include/uapi/linux/ndctl.h
> +++ b/include/uapi/linux/ndctl.h
> @@ -98,6 +98,14 @@ struct nd_cmd_ars_status {
> } __packed records[0];
> } __packed;
>
> +struct nd_cmd_clear_error {
> + __u64 address;
> + __u64 length;
> + __u32 status;
> + __u8 reserved[4];
> + __u64 cleared;
> +} __packed;
> +
> enum {
> ND_CMD_IMPLEMENTED = 0,
>
> @@ -105,6 +113,7 @@ enum {
> ND_CMD_ARS_CAP = 1,
> ND_CMD_ARS_START = 2,
> ND_CMD_ARS_STATUS = 3,
> + ND_CMD_CLEAR_ERROR = 4,
>
> /* per-dimm commands */
> ND_CMD_SMART = 1,
> @@ -129,6 +138,7 @@ static inline const char
> *nvdimm_bus_cmd_name(unsigned cmd)
> [ND_CMD_ARS_CAP] = "ars_cap",
> [ND_CMD_ARS_START] = "ars_start",
> [ND_CMD_ARS_STATUS] = "ars_status",
> + [ND_CMD_CLEAR_ERROR] = "clear_error",
> };
>
> if (cmd < ARRAY_SIZE(names) && names[cmd])
> @@ -187,6 +197,9 @@ static inline const char *nvdimm_cmd_name(unsigned
> cmd)
> #define ND_IOCTL_ARS_STATUS _IOWR(ND_IOCTL,
> ND_CMD_ARS_STATUS,\
> struct nd_cmd_ars_status)
>
> +#define ND_IOCTL_CLEAR_ERROR _IOWR(ND_IOCTL,
> ND_CMD_CLEAR_ERROR,\
> + struct nd_cmd_ars_status)
> +
Typo here? Should be struct nd_cmd_clear_error.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 1/3] nfit, libnvdimm: clear poison command support
Date: Wed, 9 Mar 2016 23:03:59 +0000 [thread overview]
Message-ID: <1457564634.4525.32.camel@intel.com> (raw)
In-Reply-To: <20160308224718.16298.47066.stgit@dwillia2-desk3.jf.intel.com>
On Tue, 2016-03-08 at 14:47 -0800, Dan Williams wrote:
> Add the boiler-plate for a 'clear error' command based on section
> 9.20.7.6 "Function Index 4 - Clear Uncorrectable Error" from the ACPI
> 6.1 specification, and add a reference implementation in nfit_test.
>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/acpi/nfit.c | 12 +++++++++++-
> drivers/nvdimm/bus.c | 19 +++++++++++++++++++
> include/uapi/linux/ndctl.h | 13 +++++++++++++
> tools/testing/nvdimm/test/nfit.c | 29 +++++++++++++++++++++++++++++
> 4 files changed, 72 insertions(+), 1 deletion(-)
>
<snip>
> diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h
> index cc68b92124d4..0f001c571cdd 100644
> --- a/include/uapi/linux/ndctl.h
> +++ b/include/uapi/linux/ndctl.h
> @@ -98,6 +98,14 @@ struct nd_cmd_ars_status {
> } __packed records[0];
> } __packed;
>
> +struct nd_cmd_clear_error {
> + __u64 address;
> + __u64 length;
> + __u32 status;
> + __u8 reserved[4];
> + __u64 cleared;
> +} __packed;
> +
> enum {
> ND_CMD_IMPLEMENTED = 0,
>
> @@ -105,6 +113,7 @@ enum {
> ND_CMD_ARS_CAP = 1,
> ND_CMD_ARS_START = 2,
> ND_CMD_ARS_STATUS = 3,
> + ND_CMD_CLEAR_ERROR = 4,
>
> /* per-dimm commands */
> ND_CMD_SMART = 1,
> @@ -129,6 +138,7 @@ static inline const char
> *nvdimm_bus_cmd_name(unsigned cmd)
> [ND_CMD_ARS_CAP] = "ars_cap",
> [ND_CMD_ARS_START] = "ars_start",
> [ND_CMD_ARS_STATUS] = "ars_status",
> + [ND_CMD_CLEAR_ERROR] = "clear_error",
> };
>
> if (cmd < ARRAY_SIZE(names) && names[cmd])
> @@ -187,6 +197,9 @@ static inline const char *nvdimm_cmd_name(unsigned
> cmd)
> #define ND_IOCTL_ARS_STATUS _IOWR(ND_IOCTL,
> ND_CMD_ARS_STATUS,\
> struct nd_cmd_ars_status)
>
> +#define ND_IOCTL_CLEAR_ERROR _IOWR(ND_IOCTL,
> ND_CMD_CLEAR_ERROR,\
> + struct nd_cmd_ars_status)
> +
Typo here? Should be struct nd_cmd_clear_error.
WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 1/3] nfit, libnvdimm: clear poison command support
Date: Wed, 9 Mar 2016 23:03:59 +0000 [thread overview]
Message-ID: <1457564634.4525.32.camel@intel.com> (raw)
In-Reply-To: <20160308224718.16298.47066.stgit@dwillia2-desk3.jf.intel.com>
On Tue, 2016-03-08 at 14:47 -0800, Dan Williams wrote:
> Add the boiler-plate for a 'clear error' command based on section
> 9.20.7.6 "Function Index 4 - Clear Uncorrectable Error" from the ACPI
> 6.1 specification, and add a reference implementation in nfit_test.
>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/acpi/nfit.c | 12 +++++++++++-
> drivers/nvdimm/bus.c | 19 +++++++++++++++++++
> include/uapi/linux/ndctl.h | 13 +++++++++++++
> tools/testing/nvdimm/test/nfit.c | 29 +++++++++++++++++++++++++++++
> 4 files changed, 72 insertions(+), 1 deletion(-)
>
<snip>
> diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h
> index cc68b92124d4..0f001c571cdd 100644
> --- a/include/uapi/linux/ndctl.h
> +++ b/include/uapi/linux/ndctl.h
> @@ -98,6 +98,14 @@ struct nd_cmd_ars_status {
> } __packed records[0];
> } __packed;
>
> +struct nd_cmd_clear_error {
> + __u64 address;
> + __u64 length;
> + __u32 status;
> + __u8 reserved[4];
> + __u64 cleared;
> +} __packed;
> +
> enum {
> ND_CMD_IMPLEMENTED = 0,
>
> @@ -105,6 +113,7 @@ enum {
> ND_CMD_ARS_CAP = 1,
> ND_CMD_ARS_START = 2,
> ND_CMD_ARS_STATUS = 3,
> + ND_CMD_CLEAR_ERROR = 4,
>
> /* per-dimm commands */
> ND_CMD_SMART = 1,
> @@ -129,6 +138,7 @@ static inline const char
> *nvdimm_bus_cmd_name(unsigned cmd)
> [ND_CMD_ARS_CAP] = "ars_cap",
> [ND_CMD_ARS_START] = "ars_start",
> [ND_CMD_ARS_STATUS] = "ars_status",
> + [ND_CMD_CLEAR_ERROR] = "clear_error",
> };
>
> if (cmd < ARRAY_SIZE(names) && names[cmd])
> @@ -187,6 +197,9 @@ static inline const char *nvdimm_cmd_name(unsigned
> cmd)
> #define ND_IOCTL_ARS_STATUS _IOWR(ND_IOCTL,
> ND_CMD_ARS_STATUS,\
> struct nd_cmd_ars_status)
>
> +#define ND_IOCTL_CLEAR_ERROR _IOWR(ND_IOCTL,
> ND_CMD_CLEAR_ERROR,\
> + struct nd_cmd_ars_status)
> +
Typo here? Should be struct nd_cmd_clear_error.
next prev parent reply other threads:[~2016-03-09 23:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 22:47 [PATCH 0/3] nfit, libnvdimm, pmem: clear poison support Dan Williams
2016-03-08 22:47 ` Dan Williams
2016-03-08 22:47 ` Dan Williams
2016-03-08 22:47 ` [PATCH 1/3] nfit, libnvdimm: clear poison command support Dan Williams
2016-03-08 22:47 ` Dan Williams
2016-03-08 22:47 ` Dan Williams
2016-03-09 23:03 ` Verma, Vishal L [this message]
2016-03-09 23:03 ` Verma, Vishal L
2016-03-09 23:03 ` Verma, Vishal L
2016-03-09 23:07 ` Dan Williams
2016-03-09 23:07 ` Dan Williams
2016-03-09 23:07 ` Dan Williams
2016-03-08 22:47 ` [PATCH 2/3] libnvdimm, pmem: fix kmap_atomic() leak in error path Dan Williams
2016-03-08 22:47 ` Dan Williams
2016-03-08 22:47 ` Dan Williams
2016-03-08 22:47 ` [PATCH 3/3] libnvdimm, pmem: clear poison on write Dan Williams
2016-03-08 22:47 ` Dan Williams
2016-03-08 22:47 ` Dan Williams
2016-03-11 0:39 ` Verma, Vishal L
2016-03-11 0:39 ` Verma, Vishal L
2016-03-11 0:39 ` Verma, Vishal L
2016-03-11 0:50 ` Dan Williams
2016-03-11 0:50 ` Dan Williams
2016-03-11 0:50 ` Dan Williams
2016-03-09 23:05 ` [PATCH 0/3] nfit, libnvdimm, pmem: clear poison support Verma, Vishal L
2016-03-09 23:05 ` Verma, Vishal L
2016-03-09 23:05 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457564634.4525.32.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.