From: Matthew Wilcox <matthew.r.wilcox@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
linux-nvdimm@lists.01.org
Subject: [PATCH 3/3] pfn_t: New functions pfn_t_add and pfn_t_cmp
Date: Fri, 11 Mar 2016 16:13:04 -0500 [thread overview]
Message-ID: <1457730784-9890-4-git-send-email-matthew.r.wilcox@intel.com> (raw)
In-Reply-To: <1457730784-9890-1-git-send-email-matthew.r.wilcox@intel.com>
When we find a huge PFN in the radix tree, we need to add the low
bits of the index to it in order to find the PFN we are looking for.
Since we want the result to stay in pfn_t form, create pfn_t_add().
We also need to compare PFNs, for example to determine if the PFN
represents a zero page. At the moment, we only have use for comparing
equality, but a general compare operation is no more code and may prove
useful in the future.
Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
---
include/linux/pfn_t.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/include/linux/pfn_t.h b/include/linux/pfn_t.h
index 0ff4c4e..c3bb5fe 100644
--- a/include/linux/pfn_t.h
+++ b/include/linux/pfn_t.h
@@ -67,6 +67,22 @@ static inline unsigned long pfn_t_to_pfn(pfn_t pfn)
return v >> PFN_FLAG_BITS;
}
+static inline __must_check pfn_t pfn_t_add(const pfn_t pfn, int val)
+{
+ pfn_t tmp = pfn;
+ if (tmp.val & PFN_HUGE)
+ tmp.val &= ~PFN_SIZE_MASK;
+ tmp.val &= ~PFN_SG_MASK;
+ tmp.val += val << PFN_FLAG_BITS;
+ return tmp;
+}
+
+/* Like memcmp, returns <0 if a<b, 0 if a=b and >0 if b>a */
+static inline int pfn_t_cmp(pfn_t a, pfn_t b)
+{
+ return pfn_t_to_pfn(b) - pfn_t_to_pfn(a);
+}
+
extern pfn_t phys_to_pfn_t(phys_addr_t addr, u64 flags);
static inline bool pfn_t_has_page(pfn_t pfn)
--
2.7.0
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew.r.wilcox@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>,
linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, willy@linux.intel.com
Subject: [PATCH 3/3] pfn_t: New functions pfn_t_add and pfn_t_cmp
Date: Fri, 11 Mar 2016 16:13:04 -0500 [thread overview]
Message-ID: <1457730784-9890-4-git-send-email-matthew.r.wilcox@intel.com> (raw)
In-Reply-To: <1457730784-9890-1-git-send-email-matthew.r.wilcox@intel.com>
When we find a huge PFN in the radix tree, we need to add the low
bits of the index to it in order to find the PFN we are looking for.
Since we want the result to stay in pfn_t form, create pfn_t_add().
We also need to compare PFNs, for example to determine if the PFN
represents a zero page. At the moment, we only have use for comparing
equality, but a general compare operation is no more code and may prove
useful in the future.
Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
---
include/linux/pfn_t.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/include/linux/pfn_t.h b/include/linux/pfn_t.h
index 0ff4c4e..c3bb5fe 100644
--- a/include/linux/pfn_t.h
+++ b/include/linux/pfn_t.h
@@ -67,6 +67,22 @@ static inline unsigned long pfn_t_to_pfn(pfn_t pfn)
return v >> PFN_FLAG_BITS;
}
+static inline __must_check pfn_t pfn_t_add(const pfn_t pfn, int val)
+{
+ pfn_t tmp = pfn;
+ if (tmp.val & PFN_HUGE)
+ tmp.val &= ~PFN_SIZE_MASK;
+ tmp.val &= ~PFN_SG_MASK;
+ tmp.val += val << PFN_FLAG_BITS;
+ return tmp;
+}
+
+/* Like memcmp, returns <0 if a<b, 0 if a=b and >0 if b>a */
+static inline int pfn_t_cmp(pfn_t a, pfn_t b)
+{
+ return pfn_t_to_pfn(b) - pfn_t_to_pfn(a);
+}
+
extern pfn_t phys_to_pfn_t(phys_addr_t addr, u64 flags);
static inline bool pfn_t_has_page(pfn_t pfn)
--
2.7.0
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew.r.wilcox@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, willy@linux.intel.com
Subject: [PATCH 3/3] pfn_t: New functions pfn_t_add and pfn_t_cmp
Date: Fri, 11 Mar 2016 16:13:04 -0500 [thread overview]
Message-ID: <1457730784-9890-4-git-send-email-matthew.r.wilcox@intel.com> (raw)
In-Reply-To: <1457730784-9890-1-git-send-email-matthew.r.wilcox@intel.com>
When we find a huge PFN in the radix tree, we need to add the low
bits of the index to it in order to find the PFN we are looking for.
Since we want the result to stay in pfn_t form, create pfn_t_add().
We also need to compare PFNs, for example to determine if the PFN
represents a zero page. At the moment, we only have use for comparing
equality, but a general compare operation is no more code and may prove
useful in the future.
Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
---
include/linux/pfn_t.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/include/linux/pfn_t.h b/include/linux/pfn_t.h
index 0ff4c4e..c3bb5fe 100644
--- a/include/linux/pfn_t.h
+++ b/include/linux/pfn_t.h
@@ -67,6 +67,22 @@ static inline unsigned long pfn_t_to_pfn(pfn_t pfn)
return v >> PFN_FLAG_BITS;
}
+static inline __must_check pfn_t pfn_t_add(const pfn_t pfn, int val)
+{
+ pfn_t tmp = pfn;
+ if (tmp.val & PFN_HUGE)
+ tmp.val &= ~PFN_SIZE_MASK;
+ tmp.val &= ~PFN_SG_MASK;
+ tmp.val += val << PFN_FLAG_BITS;
+ return tmp;
+}
+
+/* Like memcmp, returns <0 if a<b, 0 if a=b and >0 if b>a */
+static inline int pfn_t_cmp(pfn_t a, pfn_t b)
+{
+ return pfn_t_to_pfn(b) - pfn_t_to_pfn(a);
+}
+
extern pfn_t phys_to_pfn_t(phys_addr_t addr, u64 flags);
static inline bool pfn_t_has_page(pfn_t pfn)
--
2.7.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-03-11 21:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 21:13 [PATCH 0/3] Make pfn_t suitable for placing in the radix tree Matthew Wilcox
2016-03-11 21:13 ` Matthew Wilcox
2016-03-11 21:13 ` Matthew Wilcox
2016-03-11 21:13 ` [PATCH 1/3] pfn_t: Change the encoding Matthew Wilcox
2016-03-11 21:13 ` Matthew Wilcox
2016-03-11 21:13 ` Matthew Wilcox
2016-03-11 21:40 ` Dan Williams
2016-03-11 21:40 ` Dan Williams
2016-03-11 21:40 ` Dan Williams
2016-03-12 18:30 ` Matthew Wilcox
2016-03-12 18:30 ` Matthew Wilcox
2016-03-12 18:30 ` Matthew Wilcox
2016-03-13 23:09 ` Dan Williams
2016-03-13 23:09 ` Dan Williams
2016-03-13 23:09 ` Dan Williams
2016-03-14 15:00 ` Matthew Wilcox
2016-03-14 15:00 ` Matthew Wilcox
2016-03-14 15:00 ` Matthew Wilcox
2016-03-11 21:13 ` [PATCH 2/3] pfn_t: Support for huge PFNs Matthew Wilcox
2016-03-11 21:13 ` Matthew Wilcox
2016-03-11 21:13 ` Matthew Wilcox
2016-03-11 21:13 ` Matthew Wilcox [this message]
2016-03-11 21:13 ` [PATCH 3/3] pfn_t: New functions pfn_t_add and pfn_t_cmp Matthew Wilcox
2016-03-11 21:13 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457730784-9890-4-git-send-email-matthew.r.wilcox@intel.com \
--to=matthew.r.wilcox@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.