From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> To: Hugh Dickins <hughd@google.com>, Andrea Arcangeli <aarcange@redhat.com>, Andrew Morton <akpm@linux-foundation.org> Cc: Dave Hansen <dave.hansen@intel.com>, Vlastimil Babka <vbabka@suse.cz>, Christoph Lameter <cl@gentwo.org>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, Jerome Marchand <jmarchan@redhat.com>, Yang Shi <yang.shi@linaro.org>, Sasha Levin <sasha.levin@oracle.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Subject: [PATCHv4 11/25] thp: handle file pages in mremap() Date: Sat, 12 Mar 2016 01:59:03 +0300 [thread overview] Message-ID: <1457737157-38573-12-git-send-email-kirill.shutemov@linux.intel.com> (raw) In-Reply-To: <1457737157-38573-1-git-send-email-kirill.shutemov@linux.intel.com> We need to mirror logic in move_ptes() wrt need_rmap_locks to get proper serialization file THP. Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> --- mm/mremap.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/mm/mremap.c b/mm/mremap.c index 3fa0a467df66..88fa7ab1a8ce 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -192,17 +192,27 @@ unsigned long move_page_tables(struct vm_area_struct *vma, break; if (pmd_trans_huge(*old_pmd)) { if (extent == HPAGE_PMD_SIZE) { + struct address_space *mapping = NULL; + struct anon_vma *anon_vma = NULL; bool moved; - VM_BUG_ON_VMA(vma->vm_file || !vma->anon_vma, - vma); /* See comment in move_ptes() */ - if (need_rmap_locks) - anon_vma_lock_write(vma->anon_vma); + if (need_rmap_locks) { + if (vma->vm_file) { + mapping = vma->vm_file->f_mapping; + i_mmap_lock_write(mapping); + } + if (vma->anon_vma) { + anon_vma = vma->anon_vma; + anon_vma_lock_write(anon_vma); + } + } moved = move_huge_pmd(vma, new_vma, old_addr, new_addr, old_end, old_pmd, new_pmd); - if (need_rmap_locks) - anon_vma_unlock_write(vma->anon_vma); + if (anon_vma) + anon_vma_unlock_write(anon_vma); + if (mapping) + i_mmap_unlock_write(mapping); if (moved) { need_flush = true; continue; -- 2.7.0
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> To: Hugh Dickins <hughd@google.com>, Andrea Arcangeli <aarcange@redhat.com>, Andrew Morton <akpm@linux-foundation.org> Cc: Dave Hansen <dave.hansen@intel.com>, Vlastimil Babka <vbabka@suse.cz>, Christoph Lameter <cl@gentwo.org>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, Jerome Marchand <jmarchan@redhat.com>, Yang Shi <yang.shi@linaro.org>, Sasha Levin <sasha.levin@oracle.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Subject: [PATCHv4 11/25] thp: handle file pages in mremap() Date: Sat, 12 Mar 2016 01:59:03 +0300 [thread overview] Message-ID: <1457737157-38573-12-git-send-email-kirill.shutemov@linux.intel.com> (raw) In-Reply-To: <1457737157-38573-1-git-send-email-kirill.shutemov@linux.intel.com> We need to mirror logic in move_ptes() wrt need_rmap_locks to get proper serialization file THP. Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> --- mm/mremap.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/mm/mremap.c b/mm/mremap.c index 3fa0a467df66..88fa7ab1a8ce 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -192,17 +192,27 @@ unsigned long move_page_tables(struct vm_area_struct *vma, break; if (pmd_trans_huge(*old_pmd)) { if (extent == HPAGE_PMD_SIZE) { + struct address_space *mapping = NULL; + struct anon_vma *anon_vma = NULL; bool moved; - VM_BUG_ON_VMA(vma->vm_file || !vma->anon_vma, - vma); /* See comment in move_ptes() */ - if (need_rmap_locks) - anon_vma_lock_write(vma->anon_vma); + if (need_rmap_locks) { + if (vma->vm_file) { + mapping = vma->vm_file->f_mapping; + i_mmap_lock_write(mapping); + } + if (vma->anon_vma) { + anon_vma = vma->anon_vma; + anon_vma_lock_write(anon_vma); + } + } moved = move_huge_pmd(vma, new_vma, old_addr, new_addr, old_end, old_pmd, new_pmd); - if (need_rmap_locks) - anon_vma_unlock_write(vma->anon_vma); + if (anon_vma) + anon_vma_unlock_write(anon_vma); + if (mapping) + i_mmap_unlock_write(mapping); if (moved) { need_flush = true; continue; -- 2.7.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-03-11 22:59 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-11 22:58 [PATCHv4 00/25] THP-enabled tmpfs/shmem Kirill A. Shutemov 2016-03-11 22:58 ` Kirill A. Shutemov 2016-03-11 22:58 ` [PATCHv4 01/25] mm: do not pass mm_struct into handle_mm_fault Kirill A. Shutemov 2016-03-11 22:58 ` Kirill A. Shutemov 2016-03-11 22:58 ` [PATCHv4 02/25] mm: introduce fault_env Kirill A. Shutemov 2016-03-11 22:58 ` Kirill A. Shutemov 2016-03-11 22:58 ` [PATCHv4 03/25] mm: postpone page table allocation until we have page to map Kirill A. Shutemov 2016-03-11 22:58 ` Kirill A. Shutemov 2016-03-11 22:58 ` [PATCHv4 04/25] rmap: support file thp Kirill A. Shutemov 2016-03-11 22:58 ` Kirill A. Shutemov 2016-03-18 9:40 ` Aneesh Kumar K.V 2016-03-18 9:40 ` Aneesh Kumar K.V 2016-03-18 9:40 ` Aneesh Kumar K.V 2016-03-19 1:01 ` Kirill A. Shutemov 2016-03-19 1:01 ` Kirill A. Shutemov 2016-03-11 22:58 ` [PATCHv4 05/25] mm: introduce do_set_pmd() Kirill A. Shutemov 2016-03-11 22:58 ` Kirill A. Shutemov 2016-03-11 22:58 ` [PATCHv4 06/25] mm, rmap: account file thp pages Kirill A. Shutemov 2016-03-11 22:58 ` Kirill A. Shutemov 2016-03-15 15:30 ` [PATCHv5 " Kirill A. Shutemov 2016-03-15 15:30 ` Kirill A. Shutemov 2016-03-11 22:58 ` [PATCHv4 07/25] thp, vmstats: add counters for huge file pages Kirill A. Shutemov 2016-03-11 22:58 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 08/25] thp: support file pages in zap_huge_pmd() Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-18 13:53 ` Aneesh Kumar K.V 2016-03-18 13:53 ` Aneesh Kumar K.V 2016-03-18 13:53 ` Aneesh Kumar K.V 2016-03-19 1:02 ` Kirill A. Shutemov 2016-03-19 1:02 ` Kirill A. Shutemov 2016-03-21 4:33 ` Aneesh Kumar K.V 2016-03-21 4:33 ` Aneesh Kumar K.V 2016-03-21 14:39 ` Kirill A. Shutemov 2016-03-21 14:39 ` Kirill A. Shutemov 2016-03-21 16:42 ` Aneesh Kumar K.V 2016-03-21 16:42 ` Aneesh Kumar K.V 2016-03-11 22:59 ` [PATCHv4 09/25] thp: handle file pages in split_huge_pmd() Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 10/25] thp: handle file COW faults Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov [this message] 2016-03-11 22:59 ` [PATCHv4 11/25] thp: handle file pages in mremap() Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 12/25] thp: skip file huge pmd on copy_huge_pmd() Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 13/25] thp: prepare change_huge_pmd() for file thp Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 14/25] thp: run vma_adjust_trans_huge() outside i_mmap_rwsem Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 15/25] thp: file pages support for split_huge_page() Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 16/25] thp, mlock: do not mlock PTE-mapped file huge pages Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 17/25] vmscan: split file huge pages before paging them out Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 18/25] page-flags: relax policy for PG_mappedtodisk and PG_reclaim Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 19/25] radix-tree: implement radix_tree_maybe_preload_order() Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 20/25] filemap: prepare find and delete operations for huge pages Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 21/25] truncate: handle file thp Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 22/25] shmem: prepare huge= mount option and sysfs knob Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 23/25] shmem: get_unmapped_area align huge page Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 24/25] shmem: add huge pages support Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-11 22:59 ` [PATCHv4 25/25] shmem, thp: respect MADV_{NO,}HUGEPAGE for file mappings Kirill A. Shutemov 2016-03-11 22:59 ` Kirill A. Shutemov 2016-03-15 15:52 ` [PATCHv5 26/25] thp: update Documentation/vm/transhuge.txt Kirill A. Shutemov 2016-03-15 15:52 ` Kirill A. Shutemov 2016-03-23 20:09 ` [PATCHv4 00/25] THP-enabled tmpfs/shmem Hugh Dickins 2016-03-23 20:09 ` Hugh Dickins 2016-03-24 9:17 ` Kirill A. Shutemov 2016-03-24 9:17 ` Kirill A. Shutemov 2016-03-24 19:08 ` Hugh Dickins 2016-03-24 19:08 ` Hugh Dickins 2016-03-25 15:04 ` Kirill A. Shutemov 2016-03-25 15:04 ` Kirill A. Shutemov 2016-03-26 0:00 ` Hugh Dickins 2016-03-26 0:00 ` Hugh Dickins 2016-03-28 18:00 ` Kirill A. Shutemov 2016-03-28 18:00 ` Kirill A. Shutemov 2016-03-28 18:42 ` Hugh Dickins 2016-03-28 18:42 ` Hugh Dickins 2016-03-28 12:29 ` Kirill A. Shutemov 2016-03-28 12:29 ` Kirill A. Shutemov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1457737157-38573-12-git-send-email-kirill.shutemov@linux.intel.com \ --to=kirill.shutemov@linux.intel.com \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=cl@gentwo.org \ --cc=dave.hansen@intel.com \ --cc=hughd@google.com \ --cc=jmarchan@redhat.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=n-horiguchi@ah.jp.nec.com \ --cc=sasha.levin@oracle.com \ --cc=vbabka@suse.cz \ --cc=yang.shi@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.