From: Xiao Guangrong <guangrong.xiao@linux.intel.com> To: pbonzini@redhat.com, imammedo@redhat.com Cc: gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, Xiao Guangrong <guangrong.xiao@linux.intel.com> Subject: [PATCH 13/15] nvdimm acpi: support Get Namespace Label Data function Date: Thu, 17 Mar 2016 16:32:59 +0800 [thread overview] Message-ID: <1458203581-59143-14-git-send-email-guangrong.xiao@linux.intel.com> (raw) In-Reply-To: <1458203581-59143-1-git-send-email-guangrong.xiao@linux.intel.com> Function 5 is used to get Namespace Label Data Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> --- hw/acpi/nvdimm.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 80 insertions(+), 1 deletion(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 4b5f672..1240328 100644 --- a/hw/acpi/nvdimm.c +++ b/hw/acpi/nvdimm.c @@ -438,6 +438,14 @@ struct NvdimmFuncGetLabelSizeOut { typedef struct NvdimmFuncGetLabelSizeOut NvdimmFuncGetLabelSizeOut; QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncGetLabelSizeOut) > TARGET_PAGE_SIZE); +struct NvdimmFuncGetLabelDataIn { + uint32_t offset; /* the offset in the namespace label data area. */ + uint32_t length; /* the size of data is to be read via the function. */ +} QEMU_PACKED; +typedef struct NvdimmFuncGetLabelDataIn NvdimmFuncGetLabelDataIn; +QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncGetLabelDataIn) + sizeof(NvdimmDsmIn) > + TARGET_PAGE_SIZE); + struct NvdimmFuncGetLabelDataOut { /* the size of buffer filled by QEMU. */ uint32_t len; @@ -445,6 +453,7 @@ struct NvdimmFuncGetLabelDataOut { uint8_t out_buf[0]; /* the data got via Get Namesapce Label function. */ } QEMU_PACKED; typedef struct NvdimmFuncGetLabelDataOut NvdimmFuncGetLabelDataOut; +QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncGetLabelDataOut) > TARGET_PAGE_SIZE); struct NvdimmFuncSetLabelDataIn { uint32_t offset; /* the offset in the namespace label data area. */ @@ -539,6 +548,70 @@ static void nvdimm_dsm_label_size(NVDIMMDevice *nvdimm, hwaddr dsm_mem_addr) sizeof(label_size_out)); } +static uint32_t nvdimm_rw_label_data_check(NVDIMMDevice *nvdimm, + uint32_t offset, uint32_t length) +{ + uint32_t ret = 3 /* Invalid Input Parameters */; + + if (offset + length < offset) { + nvdimm_debug("offset %#x + length %#x is overflow.\n", offset, + length); + return ret; + } + + if (nvdimm->label_size < offset + length) { + nvdimm_debug("position %#x is beyond label data (len = %#lx).\n", + offset + length, nvdimm->label_size); + return ret; + } + + if (length > nvdimm_get_max_xfer_label_size()) { + nvdimm_debug("length (%#x) is larger than max_xfer (%#x).\n", + length, nvdimm_get_max_xfer_label_size()); + return ret; + } + + return 0 /* Success */; +} + +/* + * DSM Spec Rev1 4.5 Get Namespace Label Data (Function Index 5). + */ +static void nvdimm_dsm_get_label_data(NVDIMMDevice *nvdimm, NvdimmDsmIn *in, + hwaddr dsm_mem_addr) +{ + NVDIMMClass *nvc = NVDIMM_GET_CLASS(nvdimm); + NvdimmFuncGetLabelDataIn *get_label_data; + NvdimmFuncGetLabelDataOut *get_label_data_out; + uint32_t status; + int size; + + get_label_data = (NvdimmFuncGetLabelDataIn *)in->arg3; + le32_to_cpus(&get_label_data->offset); + le32_to_cpus(&get_label_data->length); + + nvdimm_debug("Read Label Data: offset %#x length %#x.\n", + get_label_data->offset, get_label_data->length); + + status = nvdimm_rw_label_data_check(nvdimm, get_label_data->offset, + get_label_data->length); + if (status != 0 /* Success */) { + return nvdimm_dsm_no_payload(status, dsm_mem_addr); + } + + size = sizeof(*get_label_data_out) + get_label_data->length; + assert(size <= TARGET_PAGE_SIZE); + get_label_data_out = g_malloc(size); + + get_label_data_out->len = cpu_to_le32(size); + get_label_data_out->func_ret_status = cpu_to_le32(0 /* Success */); + nvc->read_label_data(nvdimm, get_label_data_out->out_buf, + get_label_data->length, get_label_data->offset); + + cpu_physical_memory_write(dsm_mem_addr, get_label_data_out, size); + g_free(get_label_data_out); +} + static void nvdimm_dsm_device(NvdimmDsmIn *in, hwaddr dsm_mem_addr) { NVDIMMDevice *nvdimm = nvdimm_get_device_by_handle(in->handle); @@ -551,7 +624,8 @@ static void nvdimm_dsm_device(NvdimmDsmIn *in, hwaddr dsm_mem_addr) supported_func |= 0x1 /* Bit 0 indicates whether there is support for any functions other than function 0. */ | - 1 << 4 /* Get Namespace Label Size */; + 1 << 4 /* Get Namespace Label Size */ | + 1 << 5 /* Get Namespace Label Data */; } return nvdimm_dsm_function0(supported_func, dsm_mem_addr); } @@ -568,6 +642,11 @@ static void nvdimm_dsm_device(NvdimmDsmIn *in, hwaddr dsm_mem_addr) nvdimm_dsm_label_size(nvdimm, dsm_mem_addr); } break; + case 5 /* Get Namespace Label Data */: + if (nvdimm->reserve_label) { + nvdimm_dsm_get_label_data(nvdimm, in, dsm_mem_addr); + } + break; default: nvdimm_dsm_no_payload(1 /* Not Supported */, dsm_mem_addr); } -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <guangrong.xiao@linux.intel.com> To: pbonzini@redhat.com, imammedo@redhat.com Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net Subject: [Qemu-devel] [PATCH 13/15] nvdimm acpi: support Get Namespace Label Data function Date: Thu, 17 Mar 2016 16:32:59 +0800 [thread overview] Message-ID: <1458203581-59143-14-git-send-email-guangrong.xiao@linux.intel.com> (raw) In-Reply-To: <1458203581-59143-1-git-send-email-guangrong.xiao@linux.intel.com> Function 5 is used to get Namespace Label Data Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> --- hw/acpi/nvdimm.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 80 insertions(+), 1 deletion(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 4b5f672..1240328 100644 --- a/hw/acpi/nvdimm.c +++ b/hw/acpi/nvdimm.c @@ -438,6 +438,14 @@ struct NvdimmFuncGetLabelSizeOut { typedef struct NvdimmFuncGetLabelSizeOut NvdimmFuncGetLabelSizeOut; QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncGetLabelSizeOut) > TARGET_PAGE_SIZE); +struct NvdimmFuncGetLabelDataIn { + uint32_t offset; /* the offset in the namespace label data area. */ + uint32_t length; /* the size of data is to be read via the function. */ +} QEMU_PACKED; +typedef struct NvdimmFuncGetLabelDataIn NvdimmFuncGetLabelDataIn; +QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncGetLabelDataIn) + sizeof(NvdimmDsmIn) > + TARGET_PAGE_SIZE); + struct NvdimmFuncGetLabelDataOut { /* the size of buffer filled by QEMU. */ uint32_t len; @@ -445,6 +453,7 @@ struct NvdimmFuncGetLabelDataOut { uint8_t out_buf[0]; /* the data got via Get Namesapce Label function. */ } QEMU_PACKED; typedef struct NvdimmFuncGetLabelDataOut NvdimmFuncGetLabelDataOut; +QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncGetLabelDataOut) > TARGET_PAGE_SIZE); struct NvdimmFuncSetLabelDataIn { uint32_t offset; /* the offset in the namespace label data area. */ @@ -539,6 +548,70 @@ static void nvdimm_dsm_label_size(NVDIMMDevice *nvdimm, hwaddr dsm_mem_addr) sizeof(label_size_out)); } +static uint32_t nvdimm_rw_label_data_check(NVDIMMDevice *nvdimm, + uint32_t offset, uint32_t length) +{ + uint32_t ret = 3 /* Invalid Input Parameters */; + + if (offset + length < offset) { + nvdimm_debug("offset %#x + length %#x is overflow.\n", offset, + length); + return ret; + } + + if (nvdimm->label_size < offset + length) { + nvdimm_debug("position %#x is beyond label data (len = %#lx).\n", + offset + length, nvdimm->label_size); + return ret; + } + + if (length > nvdimm_get_max_xfer_label_size()) { + nvdimm_debug("length (%#x) is larger than max_xfer (%#x).\n", + length, nvdimm_get_max_xfer_label_size()); + return ret; + } + + return 0 /* Success */; +} + +/* + * DSM Spec Rev1 4.5 Get Namespace Label Data (Function Index 5). + */ +static void nvdimm_dsm_get_label_data(NVDIMMDevice *nvdimm, NvdimmDsmIn *in, + hwaddr dsm_mem_addr) +{ + NVDIMMClass *nvc = NVDIMM_GET_CLASS(nvdimm); + NvdimmFuncGetLabelDataIn *get_label_data; + NvdimmFuncGetLabelDataOut *get_label_data_out; + uint32_t status; + int size; + + get_label_data = (NvdimmFuncGetLabelDataIn *)in->arg3; + le32_to_cpus(&get_label_data->offset); + le32_to_cpus(&get_label_data->length); + + nvdimm_debug("Read Label Data: offset %#x length %#x.\n", + get_label_data->offset, get_label_data->length); + + status = nvdimm_rw_label_data_check(nvdimm, get_label_data->offset, + get_label_data->length); + if (status != 0 /* Success */) { + return nvdimm_dsm_no_payload(status, dsm_mem_addr); + } + + size = sizeof(*get_label_data_out) + get_label_data->length; + assert(size <= TARGET_PAGE_SIZE); + get_label_data_out = g_malloc(size); + + get_label_data_out->len = cpu_to_le32(size); + get_label_data_out->func_ret_status = cpu_to_le32(0 /* Success */); + nvc->read_label_data(nvdimm, get_label_data_out->out_buf, + get_label_data->length, get_label_data->offset); + + cpu_physical_memory_write(dsm_mem_addr, get_label_data_out, size); + g_free(get_label_data_out); +} + static void nvdimm_dsm_device(NvdimmDsmIn *in, hwaddr dsm_mem_addr) { NVDIMMDevice *nvdimm = nvdimm_get_device_by_handle(in->handle); @@ -551,7 +624,8 @@ static void nvdimm_dsm_device(NvdimmDsmIn *in, hwaddr dsm_mem_addr) supported_func |= 0x1 /* Bit 0 indicates whether there is support for any functions other than function 0. */ | - 1 << 4 /* Get Namespace Label Size */; + 1 << 4 /* Get Namespace Label Size */ | + 1 << 5 /* Get Namespace Label Data */; } return nvdimm_dsm_function0(supported_func, dsm_mem_addr); } @@ -568,6 +642,11 @@ static void nvdimm_dsm_device(NvdimmDsmIn *in, hwaddr dsm_mem_addr) nvdimm_dsm_label_size(nvdimm, dsm_mem_addr); } break; + case 5 /* Get Namespace Label Data */: + if (nvdimm->reserve_label) { + nvdimm_dsm_get_label_data(nvdimm, in, dsm_mem_addr); + } + break; default: nvdimm_dsm_no_payload(1 /* Not Supported */, dsm_mem_addr); } -- 1.8.3.1
next prev parent reply other threads:[~2016-03-17 8:33 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-17 8:32 [PATCH 00/15] NVDIMM: introduce nvdimm label support Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 01/15] pc-dimm: get memory region from ->get_memory_region() Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 02/15] pc-dimm: introduce realize callback Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 03/15] pc-dimm: keep the state of the whole backend memory Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 04/15] nvdimm: support nvdimm label Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 10:28 ` Stefan Hajnoczi 2016-03-17 10:28 ` [Qemu-devel] " Stefan Hajnoczi 2016-03-23 3:40 ` Xiao Guangrong 2016-03-23 3:40 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 05/15] acpi: add aml_object_type Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 06/15] acpi: add aml_call5 Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 07/15] nvdimm acpi: set HDLE properly Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 08/15] nvdimm acpi: save arg3 of _DSM method Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 09/15] nvdimm acpi: check UUID Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 10/15] nvdimm acpi: abstract the operations for root device and nvdimm devices Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 10:35 ` Stefan Hajnoczi 2016-03-17 10:35 ` [Qemu-devel] " Stefan Hajnoczi 2016-03-23 3:43 ` Xiao Guangrong 2016-03-23 3:43 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 11/15] nvdimm acpi: check revision Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 12/15] nvdimm acpi: support Get Namespace Label Size function Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 10:58 ` Stefan Hajnoczi 2016-03-17 10:58 ` [Qemu-devel] " Stefan Hajnoczi 2016-03-23 3:46 ` Xiao Guangrong 2016-03-23 3:46 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` Xiao Guangrong [this message] 2016-03-17 8:32 ` [Qemu-devel] [PATCH 13/15] nvdimm acpi: support Get Namespace Label Data function Xiao Guangrong 2016-03-17 8:33 ` [PATCH 14/15] nvdimm acpi: support Set " Xiao Guangrong 2016-03-17 8:33 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:33 ` [PATCH 15/15] docs: add NVDIMM ACPI documentation Xiao Guangrong 2016-03-17 8:33 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 10:04 ` [PATCH 00/15] NVDIMM: introduce nvdimm label support Stefan Hajnoczi 2016-03-17 10:04 ` [Qemu-devel] " Stefan Hajnoczi 2016-03-22 15:37 ` Dan Williams 2016-03-22 15:37 ` [Qemu-devel] " Dan Williams 2016-03-22 20:30 ` Stefan Hajnoczi 2016-03-22 20:30 ` [Qemu-devel] " Stefan Hajnoczi 2016-03-23 2:46 ` Xiao Guangrong 2016-03-23 2:46 ` [Qemu-devel] " Xiao Guangrong 2016-03-23 16:48 ` Stefan Hajnoczi 2016-03-23 16:48 ` [Qemu-devel] " Stefan Hajnoczi 2016-03-22 11:17 ` Michael S. Tsirkin 2016-03-22 11:17 ` [Qemu-devel] " Michael S. Tsirkin 2016-03-23 3:47 ` Xiao Guangrong 2016-03-23 3:47 ` [Qemu-devel] " Xiao Guangrong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1458203581-59143-14-git-send-email-guangrong.xiao@linux.intel.com \ --to=guangrong.xiao@linux.intel.com \ --cc=dan.j.williams@intel.com \ --cc=ehabkost@redhat.com \ --cc=gleb@kernel.org \ --cc=imammedo@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=stefanha@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.