From: Brian Foster <bfoster@redhat.com> To: xfs@oss.sgi.com Cc: dm-devel@redhat.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [RFC PATCH 4/9] dm thin: update reserve space func to allow reduction Date: Thu, 17 Mar 2016 10:30:32 -0400 [thread overview] Message-ID: <1458225037-24155-5-git-send-email-bfoster@redhat.com> (raw) In-Reply-To: <1458225037-24155-1-git-send-email-bfoster@redhat.com> The dm-thin set_reserve_count() function is designed to control the current block reservation for a thin pool. It currently only provides the ability to increase the reservation. Clients such as XFS will rely on over-reservation and thus require the ability to release excess reservation back to the pool. Update set_reserve_count() to return reserved blocks back to the pool. Signed-off-by: Brian Foster <bfoster@redhat.com> --- drivers/md/dm-thin.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index 31d36da..ac770d89 100644 --- a/drivers/md/dm-thin.c +++ b/drivers/md/dm-thin.c @@ -1429,7 +1429,8 @@ static bool dec_reserve_count(struct thin_c *tc, dm_block_t free_blocks) static int set_reserve_count(struct thin_c *tc, dm_block_t count) { int r; - dm_block_t free_blocks, delta; + dm_block_t free_blocks; + int64_t delta; unsigned long flags; r = get_free_blocks(tc->pool, &free_blocks); @@ -1437,8 +1438,6 @@ static int set_reserve_count(struct thin_c *tc, dm_block_t count) return r; spin_lock_irqsave(&tc->pool->lock, flags); - if (count <= tc->reserve_count) - goto out_unlock; /* nothing to do */ delta = count - tc->reserve_count; if (tc->pool->reserve_count + delta > free_blocks) r = -ENOSPC; @@ -1446,7 +1445,6 @@ static int set_reserve_count(struct thin_c *tc, dm_block_t count) tc->reserve_count = count; tc->pool->reserve_count += delta; } -out_unlock: spin_unlock_irqrestore(&tc->pool->lock, flags); return r; @@ -4369,7 +4367,7 @@ static int thin_reserve_space(struct dm_target *ti, sector_t nr_sects) * @nr_sects must always be a factor of the pool's blocksize; * upper layers can rely on the bdev's minimum_io_size for this. */ - if (!nr_sects || !is_factor(nr_sects, pool->sectors_per_block)) + if (!is_factor(nr_sects, pool->sectors_per_block)) return -EINVAL; blocks = nr_sects; -- 2.4.3
WARNING: multiple messages have this Message-ID (diff)
From: Brian Foster <bfoster@redhat.com> To: xfs@oss.sgi.com Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com Subject: [RFC PATCH 4/9] dm thin: update reserve space func to allow reduction Date: Thu, 17 Mar 2016 10:30:32 -0400 [thread overview] Message-ID: <1458225037-24155-5-git-send-email-bfoster@redhat.com> (raw) In-Reply-To: <1458225037-24155-1-git-send-email-bfoster@redhat.com> The dm-thin set_reserve_count() function is designed to control the current block reservation for a thin pool. It currently only provides the ability to increase the reservation. Clients such as XFS will rely on over-reservation and thus require the ability to release excess reservation back to the pool. Update set_reserve_count() to return reserved blocks back to the pool. Signed-off-by: Brian Foster <bfoster@redhat.com> --- drivers/md/dm-thin.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index 31d36da..ac770d89 100644 --- a/drivers/md/dm-thin.c +++ b/drivers/md/dm-thin.c @@ -1429,7 +1429,8 @@ static bool dec_reserve_count(struct thin_c *tc, dm_block_t free_blocks) static int set_reserve_count(struct thin_c *tc, dm_block_t count) { int r; - dm_block_t free_blocks, delta; + dm_block_t free_blocks; + int64_t delta; unsigned long flags; r = get_free_blocks(tc->pool, &free_blocks); @@ -1437,8 +1438,6 @@ static int set_reserve_count(struct thin_c *tc, dm_block_t count) return r; spin_lock_irqsave(&tc->pool->lock, flags); - if (count <= tc->reserve_count) - goto out_unlock; /* nothing to do */ delta = count - tc->reserve_count; if (tc->pool->reserve_count + delta > free_blocks) r = -ENOSPC; @@ -1446,7 +1445,6 @@ static int set_reserve_count(struct thin_c *tc, dm_block_t count) tc->reserve_count = count; tc->pool->reserve_count += delta; } -out_unlock: spin_unlock_irqrestore(&tc->pool->lock, flags); return r; @@ -4369,7 +4367,7 @@ static int thin_reserve_space(struct dm_target *ti, sector_t nr_sects) * @nr_sects must always be a factor of the pool's blocksize; * upper layers can rely on the bdev's minimum_io_size for this. */ - if (!nr_sects || !is_factor(nr_sects, pool->sectors_per_block)) + if (!is_factor(nr_sects, pool->sectors_per_block)) return -EINVAL; blocks = nr_sects; -- 2.4.3 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-17 14:30 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-17 14:30 [RFC PATCH 0/9] dm-thin/xfs: prototype a block reservation allocation model Brian Foster 2016-03-17 14:30 ` Brian Foster 2016-03-17 14:30 ` [RFC PATCH 1/9] block: add block_device_operations methods to set and get reserved space Brian Foster 2016-03-17 14:30 ` Brian Foster 2016-03-21 12:08 ` Carlos Maiolino 2016-03-21 12:08 ` Carlos Maiolino 2016-03-21 21:53 ` Dave Chinner 2016-03-21 21:53 ` Dave Chinner 2016-03-22 12:05 ` Brian Foster 2016-03-22 12:05 ` Brian Foster 2016-03-17 14:30 ` [RFC PATCH 2/9] dm: add " Brian Foster 2016-03-17 14:30 ` Brian Foster 2016-03-21 12:17 ` Carlos Maiolino 2016-03-21 12:17 ` Carlos Maiolino 2016-03-17 14:30 ` [RFC PATCH 3/9] dm thin: " Brian Foster 2016-03-17 14:30 ` Brian Foster 2016-03-17 14:30 ` Brian Foster [this message] 2016-03-17 14:30 ` [RFC PATCH 4/9] dm thin: update reserve space func to allow reduction Brian Foster 2016-03-17 14:30 ` [RFC PATCH 5/9] block: add a block_device_operations method to provision space Brian Foster 2016-03-17 14:30 ` Brian Foster 2016-03-17 14:30 ` [RFC PATCH 6/9] dm: add " Brian Foster 2016-03-17 14:30 ` Brian Foster 2016-03-17 14:30 ` [RFC PATCH 7/9] dm thin: " Brian Foster 2016-03-17 14:30 ` Brian Foster 2016-03-17 14:30 ` [RFC PATCH 8/9] xfs: thin block device reservation mechanism Brian Foster 2016-03-17 14:30 ` Brian Foster 2016-03-17 14:30 ` [RFC PATCH 9/9] xfs: adopt a reserved allocation model on dm-thin devices Brian Foster 2016-03-17 14:30 ` Brian Foster 2016-03-21 13:33 ` [RFC PATCH 0/9] dm-thin/xfs: prototype a block reservation allocation model Carlos Maiolino 2016-03-21 13:33 ` Carlos Maiolino 2016-03-21 22:36 ` Dave Chinner 2016-03-21 22:36 ` Dave Chinner 2016-03-22 12:06 ` Brian Foster 2016-03-22 12:06 ` Brian Foster
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1458225037-24155-5-git-send-email-bfoster@redhat.com \ --to=bfoster@redhat.com \ --cc=dm-devel@redhat.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.