[PATCH v2 02/11] IOMMU: handle IOMMU mapping and unmapping failures

From: Quan Xu <quan.xu@intel.com>
To: xen-devel@lists.xen.org
Cc: dario.faggioli@citrix.com, Jan Beulich <jbeulich@suse.com>,
	Quan Xu <quan.xu@intel.com>
Subject: [PATCH v2 02/11] IOMMU: handle IOMMU mapping and unmapping failures
Date: Mon, 18 Apr 2016 22:00:02 +0800	[thread overview]
Message-ID: <1460988011-17758-3-git-send-email-quan.xu@intel.com> (raw)
In-Reply-To: <1460988011-17758-1-git-send-email-quan.xu@intel.com>

Now IOMMU mapping and unmapping failures are treated as a fatal to
the domain (with the exception of the hardware domain).

If IOMMU mapping and unmapping failed, crash the domain (with the
exception of the hardware domain) and propagate the error up to the
call trees.

Signed-off-by: Quan Xu <quan.xu@intel.com>

CC: Jan Beulich <jbeulich@suse.com>
---
 xen/drivers/passthrough/iommu.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
index b64676f..850101b 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -243,21 +243,33 @@ int iommu_map_page(struct domain *d, unsigned long gfn, unsigned long mfn,
                    unsigned int flags)
 {
     struct hvm_iommu *hd = domain_hvm_iommu(d);
+    int rc;
 
     if ( !iommu_enabled || !hd->platform_ops )
         return 0;
 
-    return hd->platform_ops->map_page(d, gfn, mfn, flags);
+    rc = hd->platform_ops->map_page(d, gfn, mfn, flags);
+
+    if ( rc && !is_hardware_domain(d) )
+        domain_crash(d);
+
+    return rc;
 }
 
 int iommu_unmap_page(struct domain *d, unsigned long gfn)
 {
     struct hvm_iommu *hd = domain_hvm_iommu(d);
+    int rc;
 
     if ( !iommu_enabled || !hd->platform_ops )
         return 0;
 
-    return hd->platform_ops->unmap_page(d, gfn);
+    rc = hd->platform_ops->unmap_page(d, gfn);
+
+    if ( rc && !is_hardware_domain(d) )
+        domain_crash(d);
+
+    return rc;
 }
 
 static void iommu_free_pagetables(unsigned long unused)
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
