From: "Xu, Quan" <quan.xu@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "dario.faggioli@citrix.com" <dario.faggioli@citrix.com>,
"Wu, Feng" <feng.wu@intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 08/11] IOMMU: propagate IOMMU Device-TLB flush error up to iommu_iotlb_flush{, _all} (leaf ones).
Date: Tue, 26 Apr 2016 11:50:26 +0000 [thread overview]
Message-ID: <945CA011AD5F084CBEA3E851C0AB28894B89480D@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <571E1E1402000078000E54C8@prv-mh.provo.novell.com>
On April 25, 2016 7:40 PM, Jan Beulich <JBeulich@suse.com> wrote:
> >>> On 18.04.16 at 16:00, <quan.xu@intel.com> wrote:
> > While IOMMU Device-TLB flush timed out, xen calls panic() at present.
> > However the existing panic() is going to be eliminated, so we must
> > propagate the IOMMU Device-TLB flush error up to the
> > iommu_iotlb_flush{,_all}.
> >
> > If IOMMU mapping and unmapping failed, the domain (with the exception
> > of the hardware domain) is crashed, treated as a fatal error. Rollback
> > can be lighter weight.
> >
> > This patch fixes the leaf ones.
> >
> > Signed-off-by: Quan Xu <quan.xu@intel.com>
>
> Looks okay except for the again missing uses of __must_check on function
> declarations or, where needed, definitions.
>
This patch modifies the common part 'iommu_ops', but not to
fix the ARM/AMD callbacks ( it seems the callbacks are not initialized for AMD code, but ARM does).
I need to fix ARM callbacks as well.
I wonder whether it is good to use __must_check on these callbacks or not.
IMO I'd better use __must_check on functions, i.e. iommu_iotlb_flush_all(), invoking these callbacks, instead of these callbacks.
Quan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-26 11:50 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 14:00 [PATCH v2 00/11] Check VT-d Device-TLB flush error Quan Xu
2016-04-18 14:00 ` [PATCH v2 01/11] vt-d: fix the IOMMU flush issue Quan Xu
2016-04-19 6:33 ` Tian, Kevin
2016-04-19 8:33 ` Xu, Quan
2016-04-25 9:22 ` Jan Beulich
2016-04-26 1:17 ` Xu, Quan
2016-04-26 2:18 ` Xu, Quan
2016-04-26 9:10 ` Jan Beulich
2016-04-26 10:15 ` Xu, Quan
2016-04-26 10:52 ` Jan Beulich
2016-04-26 10:58 ` Xu, Quan
2016-04-18 14:00 ` [PATCH v2 02/11] IOMMU: handle IOMMU mapping and unmapping failures Quan Xu
2016-04-19 6:36 ` Tian, Kevin
2016-04-19 6:40 ` Xu, Quan
2016-04-25 9:26 ` Jan Beulich
2016-04-27 14:26 ` Xu, Quan
2016-04-27 15:02 ` Jan Beulich
2016-04-28 1:23 ` Xu, Quan
2016-04-18 14:00 ` [PATCH v2 03/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping Quan Xu
2016-04-19 6:44 ` Tian, Kevin
2016-04-20 5:27 ` Xu, Quan
2016-04-20 5:44 ` Tian, Kevin
2016-04-20 6:11 ` Jan Beulich
2016-04-20 6:26 ` Xu, Quan
2016-04-25 9:50 ` Jan Beulich
2016-04-27 8:49 ` Xu, Quan
2016-04-27 9:36 ` Jan Beulich
2016-04-27 13:10 ` Xu, Quan
2016-04-27 14:06 ` Jan Beulich
2016-04-27 15:48 ` George Dunlap
2016-04-28 1:18 ` Xu, Quan
2016-04-18 14:00 ` [PATCH v2 04/11] grant_table: avoid unnecessary work during grant table unmapping Quan Xu
2016-04-19 6:46 ` Tian, Kevin
2016-04-19 13:27 ` Xu, Quan
2016-04-20 5:35 ` Tian, Kevin
2016-04-25 9:55 ` Jan Beulich
2016-04-26 6:48 ` Xu, Quan
2016-04-18 14:00 ` [PATCH v2 05/11] vt-d: propagate IOMMU Device-TLB flush error up to IOMMU unmapping Quan Xu
2016-04-19 6:51 ` Tian, Kevin
2016-04-19 7:01 ` Xu, Quan
2016-04-25 10:06 ` Jan Beulich
2016-04-26 6:49 ` Xu, Quan
2016-04-18 14:00 ` [PATCH v2 06/11] vt-d: propagate IOMMU Device-TLB flush error up to IOMMU mapping Quan Xu
2016-04-19 6:53 ` Tian, Kevin
2016-04-18 14:00 ` [PATCH v2 07/11] IOMMU/MMU: propagate IOMMU Device-TLB flush error up to iommu_iotlb_flush{, _all} (top level ones) Quan Xu
2016-04-25 10:19 ` Jan Beulich
2016-04-26 12:23 ` Xu, Quan
2016-04-26 12:48 ` Jan Beulich
2016-04-27 6:21 ` Xu, Quan
2016-04-27 6:31 ` Jan Beulich
2016-04-27 9:08 ` Xu, Quan
2016-04-27 9:38 ` Jan Beulich
2016-04-18 14:00 ` [PATCH v2 08/11] IOMMU: propagate IOMMU Device-TLB flush error up to iommu_iotlb_flush{, _all} (leaf ones) Quan Xu
2016-04-19 6:58 ` Tian, Kevin
2016-04-19 8:58 ` Xu, Quan
2016-04-25 11:39 ` Jan Beulich
2016-04-26 11:50 ` Xu, Quan [this message]
2016-04-26 12:51 ` Jan Beulich
2016-04-26 13:20 ` Xu, Quan
2016-04-18 14:00 ` [PATCH v2 09/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending Quan Xu
2016-04-25 11:52 ` Jan Beulich
2016-04-25 13:58 ` Julien Grall
2016-04-25 14:50 ` Xu, Quan
2016-04-26 9:40 ` Julien Grall
2016-04-26 11:28 ` Xu, Quan
2016-04-28 14:14 ` Xu, Quan
2016-04-28 14:36 ` Jan Beulich
2016-04-28 15:03 ` Xu, Quan
2016-04-28 15:12 ` Jan Beulich
2016-04-28 16:08 ` Xu, Quan
2016-04-29 2:20 ` Tian, Kevin
2016-04-29 2:41 ` Xu, Quan
2016-04-29 7:13 ` Jan Beulich
2016-04-29 8:23 ` Xu, Quan
2016-04-18 14:00 ` [PATCH v2 10/11] vt-d: propagate IOMMU Device-TLB flush error up to vt-d hardware initialization Quan Xu
2016-04-18 14:00 ` [PATCH v2 11/11] vt-d: propagate error up to ME phantom function mapping and unmapping Quan Xu
2016-04-25 12:00 ` Jan Beulich
2016-04-26 10:48 ` Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=945CA011AD5F084CBEA3E851C0AB28894B89480D@SHSMSX101.ccr.corp.intel.com \
--to=quan.xu@intel.com \
--cc=JBeulich@suse.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.