All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org
Cc: linux.amoon@gmail.com, tjakobi@math.uni-bielefeld.de,
	m.szyprowski@samsung.com, hverkuil@xs4all.nl,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [RFT PATCH 2/3] ARM: dts: exynos: Provide regulator for usb3503 on Odroid to fix device detection
Date: Fri, 29 Apr 2016 12:59:50 +0200	[thread overview]
Message-ID: <1461927591-7864-3-git-send-email-k.kozlowski@samsung.com> (raw)
In-Reply-To: <1461927591-7864-1-git-send-email-k.kozlowski@samsung.com>

On Odroid U3 (Exynos4412-based) board if USB was initialized by
bootloader (in U-Boot "usb start" before tftpboot), the HUB after
successful probing was not visible in the system ("lsusb"). Connected
devices were not visible neither.

The USB3503 takes optional regulator so provide one - buck8 on Odroid
U3.

Additionally switch the control of buck8 to GPIO mode. It is faster than
I2C/register mode and it is the easiest way to disable it (regulator
state is a logical OR state of GPIO and register value).

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index d73aa6c58fe3..5308a955ede4 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -74,6 +74,7 @@
 	regulator-name = "BUCK8_P3V3";
 	regulator-min-microvolt = <3300000>;
 	regulator-max-microvolt = <3300000>;
+	maxim,ena-gpios = <&gpa1 1 GPIO_ACTIVE_HIGH>;
 };
 
 /* VDDQ for MSHC (eMMC card) */
@@ -98,6 +99,7 @@
 	clock-names = "refclk";
 	clocks = <&pmu_system_controller 0>;
 	refclk-frequency = <24000000>;
+	vdd33-supply = <&buck8_reg>;
 };
 
 &ehci {
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org
Cc: linux.amoon@gmail.com, tjakobi@math.uni-bielefeld.de,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	hverkuil@xs4all.nl, m.szyprowski@samsung.com
Subject: [RFT PATCH 2/3] ARM: dts: exynos: Provide regulator for usb3503 on Odroid to fix device detection
Date: Fri, 29 Apr 2016 12:59:50 +0200	[thread overview]
Message-ID: <1461927591-7864-3-git-send-email-k.kozlowski@samsung.com> (raw)
In-Reply-To: <1461927591-7864-1-git-send-email-k.kozlowski@samsung.com>

On Odroid U3 (Exynos4412-based) board if USB was initialized by
bootloader (in U-Boot "usb start" before tftpboot), the HUB after
successful probing was not visible in the system ("lsusb"). Connected
devices were not visible neither.

The USB3503 takes optional regulator so provide one - buck8 on Odroid
U3.

Additionally switch the control of buck8 to GPIO mode. It is faster than
I2C/register mode and it is the easiest way to disable it (regulator
state is a logical OR state of GPIO and register value).

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index d73aa6c58fe3..5308a955ede4 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -74,6 +74,7 @@
 	regulator-name = "BUCK8_P3V3";
 	regulator-min-microvolt = <3300000>;
 	regulator-max-microvolt = <3300000>;
+	maxim,ena-gpios = <&gpa1 1 GPIO_ACTIVE_HIGH>;
 };
 
 /* VDDQ for MSHC (eMMC card) */
@@ -98,6 +99,7 @@
 	clock-names = "refclk";
 	clocks = <&pmu_system_controller 0>;
 	refclk-frequency = <24000000>;
+	vdd33-supply = <&buck8_reg>;
 };
 
 &ehci {
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFT PATCH 2/3] ARM: dts: exynos: Provide regulator for usb3503 on Odroid to fix device detection
Date: Fri, 29 Apr 2016 12:59:50 +0200	[thread overview]
Message-ID: <1461927591-7864-3-git-send-email-k.kozlowski@samsung.com> (raw)
In-Reply-To: <1461927591-7864-1-git-send-email-k.kozlowski@samsung.com>

On Odroid U3 (Exynos4412-based) board if USB was initialized by
bootloader (in U-Boot "usb start" before tftpboot), the HUB after
successful probing was not visible in the system ("lsusb"). Connected
devices were not visible neither.

The USB3503 takes optional regulator so provide one - buck8 on Odroid
U3.

Additionally switch the control of buck8 to GPIO mode. It is faster than
I2C/register mode and it is the easiest way to disable it (regulator
state is a logical OR state of GPIO and register value).

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 arch/arm/boot/dts/exynos4412-odroidu3.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index d73aa6c58fe3..5308a955ede4 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -74,6 +74,7 @@
 	regulator-name = "BUCK8_P3V3";
 	regulator-min-microvolt = <3300000>;
 	regulator-max-microvolt = <3300000>;
+	maxim,ena-gpios = <&gpa1 1 GPIO_ACTIVE_HIGH>;
 };
 
 /* VDDQ for MSHC (eMMC card) */
@@ -98,6 +99,7 @@
 	clock-names = "refclk";
 	clocks = <&pmu_system_controller 0>;
 	refclk-frequency = <24000000>;
+	vdd33-supply = <&buck8_reg>;
 };
 
 &ehci {
-- 
1.9.1

  parent reply	other threads:[~2016-04-29 11:00 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 10:59 [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP booting Krzysztof Kozlowski
2016-04-29 10:59 ` Krzysztof Kozlowski
2016-04-29 10:59 ` [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after bootloader initialization Krzysztof Kozlowski
2016-04-29 10:59   ` Krzysztof Kozlowski
2016-04-29 11:30   ` Mark Brown
2016-04-29 11:30     ` Mark Brown
2016-04-29 11:55     ` Krzysztof Kozlowski
2016-04-29 11:55       ` Krzysztof Kozlowski
2016-04-29 16:44       ` Mark Brown
2016-04-29 16:44         ` Mark Brown
2016-05-02  9:49         ` Krzysztof Kozlowski
2016-05-02  9:49           ` Krzysztof Kozlowski
2016-05-02 10:49           ` Krzysztof Kozlowski
2016-05-02 10:49             ` Krzysztof Kozlowski
2016-05-02 10:55           ` Mark Brown
2016-05-02 10:55             ` Mark Brown
2016-05-03 18:00             ` Rob Herring
2016-05-03 18:00               ` Rob Herring
2016-05-04 12:01               ` Krzysztof Kozlowski
2016-05-04 12:01                 ` Krzysztof Kozlowski
2016-05-04 12:01                 ` Krzysztof Kozlowski
2016-05-04 18:25                 ` Mark Brown
2016-05-04 18:25                   ` Mark Brown
2016-04-29 10:59 ` Krzysztof Kozlowski [this message]
2016-04-29 10:59   ` [RFT PATCH 2/3] ARM: dts: exynos: Provide regulator for usb3503 on Odroid to fix device detection Krzysztof Kozlowski
2016-04-29 10:59   ` Krzysztof Kozlowski
2016-04-29 10:59 ` [PATCH 3/3] regulator: max77686: Configure enable time to properly handle regulator enable Krzysztof Kozlowski
2016-04-29 10:59   ` Krzysztof Kozlowski
2016-04-29 10:59   ` Krzysztof Kozlowski
2016-04-29 11:31   ` Applied "regulator: max77686: Configure enable time to properly handle regulator enable" to the regulator tree Mark Brown
2016-04-29 11:31     ` Mark Brown
2016-04-29 11:31     ` Mark Brown
2016-04-30  9:43 ` [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP booting Hans Verkuil
2016-04-30  9:43   ` Hans Verkuil
2016-04-30  9:43   ` Hans Verkuil
2016-05-01 13:17   ` Krzysztof Kozlowski
2016-05-01 13:17     ` Krzysztof Kozlowski
2016-05-01 13:17     ` Krzysztof Kozlowski
2016-05-01 14:09     ` Hans Verkuil
2016-05-01 14:09       ` Hans Verkuil
2016-05-01 16:01       ` Hans Verkuil
2016-05-01 16:01         ` Hans Verkuil
2016-05-01 16:01         ` Hans Verkuil
2016-05-01 16:42         ` Krzysztof Kozlowski
2016-05-01 16:42           ` Krzysztof Kozlowski
2016-05-02 13:40           ` Hans Verkuil
2016-05-02 13:40             ` Hans Verkuil
2016-05-02 13:40             ` Hans Verkuil
2016-05-02 13:41             ` Krzysztof Kozlowski
2016-05-02 13:41               ` Krzysztof Kozlowski
2016-05-02  5:50         ` Marek Szyprowski
2016-05-02  5:50           ` Marek Szyprowski
2016-05-02  5:50           ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461927591-7864-3-git-send-email-k.kozlowski@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hverkuil@xs4all.nl \
    --cc=kgene@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux.amoon@gmail.com \
    --cc=m.szyprowski@samsung.com \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.