From: Ben Dooks <ben.dooks@codethink.co.uk> To: linux-kernel@lists.codethink.co.uk Cc: Ben Dooks <ben.dooks@codethink.co.uk>, Linus Walleij <linus.walleij@linaro.org>, Alessandro Rubini <rubini@unipv.it>, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH] pinctrl: sh-pfc: fix warnings by include core.h Date: Tue, 7 Jun 2016 18:33:06 +0100 [thread overview] Message-ID: <1465320786-10333-1-git-send-email-ben.dooks@codethink.co.uk> (raw) Fix warnings about emev2_pinmux_info and r8a7779_pinmux_info by using core.h instead of sh_pfc.h in these files. This gives the declarations of the two structures and removes the following warnings: drivers/pinctrl/sh-pfc/pfc-emev2.c:1695:30: warning: symbol 'emev2_pinmux_info' was not declared. Should it be static? drivers/pinctrl/sh-pfc/pfc-r8a7779.c:3888:30: warning: symbol 'r8a7779_pinmux_info' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Alessandro Rubini <rubini@unipv.it> Cc: linux-renesas-soc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-gpio@vger.kernel.org --- drivers/pinctrl/sh-pfc/pfc-emev2.c | 2 +- drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/sh-pfc/pfc-emev2.c b/drivers/pinctrl/sh-pfc/pfc-emev2.c index 1cbbe04..f943854 100644 --- a/drivers/pinctrl/sh-pfc/pfc-emev2.c +++ b/drivers/pinctrl/sh-pfc/pfc-emev2.c @@ -10,7 +10,7 @@ #include <linux/init.h> #include <linux/kernel.h> -#include "sh_pfc.h" +#include "core.h" #define CPU_ALL_PORT(fn, pfx, sfx) \ PORT_10(0, fn, pfx, sfx), PORT_90(0, fn, pfx, sfx), \ diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c index 5bef934..098d01e 100644 --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c @@ -21,7 +21,7 @@ #include <linux/kernel.h> -#include "sh_pfc.h" +#include "core.h" #define CPU_ALL_PORT(fn, sfx) \ PORT_GP_32(0, fn, sfx), \ -- 2.8.1
WARNING: multiple messages have this Message-ID (diff)
From: ben.dooks@codethink.co.uk (Ben Dooks) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] pinctrl: sh-pfc: fix warnings by include core.h Date: Tue, 7 Jun 2016 18:33:06 +0100 [thread overview] Message-ID: <1465320786-10333-1-git-send-email-ben.dooks@codethink.co.uk> (raw) Fix warnings about emev2_pinmux_info and r8a7779_pinmux_info by using core.h instead of sh_pfc.h in these files. This gives the declarations of the two structures and removes the following warnings: drivers/pinctrl/sh-pfc/pfc-emev2.c:1695:30: warning: symbol 'emev2_pinmux_info' was not declared. Should it be static? drivers/pinctrl/sh-pfc/pfc-r8a7779.c:3888:30: warning: symbol 'r8a7779_pinmux_info' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Alessandro Rubini <rubini@unipv.it> Cc: linux-renesas-soc at vger.kernel.org Cc: linux-arm-kernel at lists.infradead.org Cc: linux-gpio at vger.kernel.org --- drivers/pinctrl/sh-pfc/pfc-emev2.c | 2 +- drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/sh-pfc/pfc-emev2.c b/drivers/pinctrl/sh-pfc/pfc-emev2.c index 1cbbe04..f943854 100644 --- a/drivers/pinctrl/sh-pfc/pfc-emev2.c +++ b/drivers/pinctrl/sh-pfc/pfc-emev2.c @@ -10,7 +10,7 @@ #include <linux/init.h> #include <linux/kernel.h> -#include "sh_pfc.h" +#include "core.h" #define CPU_ALL_PORT(fn, pfx, sfx) \ PORT_10(0, fn, pfx, sfx), PORT_90(0, fn, pfx, sfx), \ diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c index 5bef934..098d01e 100644 --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c @@ -21,7 +21,7 @@ #include <linux/kernel.h> -#include "sh_pfc.h" +#include "core.h" #define CPU_ALL_PORT(fn, sfx) \ PORT_GP_32(0, fn, sfx), \ -- 2.8.1
next reply other threads:[~2016-06-07 17:33 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-07 17:33 Ben Dooks [this message] 2016-06-07 17:33 ` [PATCH] pinctrl: sh-pfc: fix warnings by include core.h Ben Dooks 2016-06-08 12:08 ` Linus Walleij 2016-06-08 12:08 ` Linus Walleij 2016-06-09 8:08 ` Geert Uytterhoeven 2016-06-09 8:08 ` Geert Uytterhoeven 2016-06-09 8:25 ` Ben Dooks 2016-06-09 8:25 ` Ben Dooks
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1465320786-10333-1-git-send-email-ben.dooks@codethink.co.uk \ --to=ben.dooks@codethink.co.uk \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@lists.codethink.co.uk \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=rubini@unipv.it \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.