From: Garlic Tseng <garlic.tseng@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: <tiwai@suse.de>, <srv_heupstream@mediatek.com>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<koro.chen@mediatek.com>, <PC.Liao@mediatek.com>,
<ir.lian@mediatek.com>
Subject: Re: [alsa-devel] [PATCH v2 5/9] ASoC: mediatek: add structure define and clock control for 2701
Date: Wed, 8 Jun 2016 09:44:37 +0800 [thread overview]
Message-ID: <1465350277.4197.2.camel@mtksdaap41> (raw)
In-Reply-To: <20160607161508.GC7510@sirena.org.uk>
On Tue, 2016-06-07 at 17:15 +0100, Mark Brown wrote:
> On Fri, Jun 03, 2016 at 12:56:20PM +0800, Garlic Tseng wrote:
>
> > +void mt2701_init_clock(struct mtk_base_afe *afe)
> > +{
> > + struct mt2701_afe_private *afe_priv = afe->platform_priv;
> > + int i = 0;
> > +
> > + for (i = 0; i < MT2701_CLOCK_NUM; i++) {
> > + afe_priv->clocks[i] = devm_clk_get(afe->dev, aud_clks[i]);
> > + if (IS_ERR(aud_clks[i]))
> > + dev_warn(afe->dev, "%s devm_clk_get %s fail\n",
> > + __func__, aud_clks[i]);
> > + }
> > +}
>
> This looks like we just ignore the error but I'm not seeing anything
> that stops us trying to use the clocks or handle deferred probe?
The probe for platform_driver should fail if the clock error occur.
I'll fix it. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Garlic Tseng <garlic.tseng@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, srv_heupstream@mediatek.com,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
koro.chen@mediatek.com, PC.Liao@mediatek.com,
ir.lian@mediatek.com
Subject: Re: [alsa-devel] [PATCH v2 5/9] ASoC: mediatek: add structure define and clock control for 2701
Date: Wed, 8 Jun 2016 09:44:37 +0800 [thread overview]
Message-ID: <1465350277.4197.2.camel@mtksdaap41> (raw)
In-Reply-To: <20160607161508.GC7510@sirena.org.uk>
On Tue, 2016-06-07 at 17:15 +0100, Mark Brown wrote:
> On Fri, Jun 03, 2016 at 12:56:20PM +0800, Garlic Tseng wrote:
>
> > +void mt2701_init_clock(struct mtk_base_afe *afe)
> > +{
> > + struct mt2701_afe_private *afe_priv = afe->platform_priv;
> > + int i = 0;
> > +
> > + for (i = 0; i < MT2701_CLOCK_NUM; i++) {
> > + afe_priv->clocks[i] = devm_clk_get(afe->dev, aud_clks[i]);
> > + if (IS_ERR(aud_clks[i]))
> > + dev_warn(afe->dev, "%s devm_clk_get %s fail\n",
> > + __func__, aud_clks[i]);
> > + }
> > +}
>
> This looks like we just ignore the error but I'm not seeing anything
> that stops us trying to use the clocks or handle deferred probe?
The probe for platform_driver should fail if the clock error occur.
I'll fix it. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: garlic.tseng@mediatek.com (Garlic Tseng)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH v2 5/9] ASoC: mediatek: add structure define and clock control for 2701
Date: Wed, 8 Jun 2016 09:44:37 +0800 [thread overview]
Message-ID: <1465350277.4197.2.camel@mtksdaap41> (raw)
In-Reply-To: <20160607161508.GC7510@sirena.org.uk>
On Tue, 2016-06-07 at 17:15 +0100, Mark Brown wrote:
> On Fri, Jun 03, 2016 at 12:56:20PM +0800, Garlic Tseng wrote:
>
> > +void mt2701_init_clock(struct mtk_base_afe *afe)
> > +{
> > + struct mt2701_afe_private *afe_priv = afe->platform_priv;
> > + int i = 0;
> > +
> > + for (i = 0; i < MT2701_CLOCK_NUM; i++) {
> > + afe_priv->clocks[i] = devm_clk_get(afe->dev, aud_clks[i]);
> > + if (IS_ERR(aud_clks[i]))
> > + dev_warn(afe->dev, "%s devm_clk_get %s fail\n",
> > + __func__, aud_clks[i]);
> > + }
> > +}
>
> This looks like we just ignore the error but I'm not seeing anything
> that stops us trying to use the clocks or handle deferred probe?
The probe for platform_driver should fail if the clock error occur.
I'll fix it. Thanks.
next prev parent reply other threads:[~2016-06-08 1:44 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 4:56 [alsa-devel] [PATCH v2 0/9] ASoC: Mediatek: Add support for MT2701 SOC Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 1/9] ASoC: mediatek: Refine mt8173 driver and change config option Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 2/9] ASoC: mediatek: implement mediatek common structure Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-07 15:54 ` Mark Brown
2016-06-07 15:54 ` Mark Brown
2016-06-07 15:54 ` Mark Brown
2016-06-08 2:06 ` [alsa-devel] " Garlic Tseng
2016-06-08 2:06 ` Garlic Tseng
2016-06-08 2:06 ` Garlic Tseng
2016-06-09 10:44 ` Mark Brown
2016-06-09 10:44 ` Mark Brown
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 3/9] ASoC: mediatek: let mt8173 use " Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 4/9] ASoC: mediatek: add documents for mt2701 Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-29 19:16 ` Applied "ASoC: mediatek: add documents for mt2701" to the asoc tree Mark Brown
2016-06-29 19:16 ` Mark Brown
2016-06-29 19:16 ` Mark Brown
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 5/9] ASoC: mediatek: add structure define and clock control for 2701 Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-07 16:15 ` Mark Brown
2016-06-07 16:15 ` Mark Brown
2016-06-08 1:44 ` Garlic Tseng [this message]
2016-06-08 1:44 ` Garlic Tseng
2016-06-08 1:44 ` Garlic Tseng
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-07 16:31 ` Mark Brown
2016-06-07 16:31 ` Mark Brown
2016-06-07 16:31 ` Mark Brown
2016-06-08 3:32 ` Garlic Tseng
2016-06-08 3:32 ` Garlic Tseng
2016-06-08 3:32 ` Garlic Tseng
2016-06-09 10:44 ` Mark Brown
2016-06-09 10:44 ` Mark Brown
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 7/9] ASoC: bt-sco: extend rate and add a general compatible string Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 8/9] ASoC: mediatek: add BT implementation Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 9/9] ASoC: mediatek: Add mt2701-cs42448 driver and config option Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
2016-06-03 4:56 ` Garlic Tseng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465350277.4197.2.camel@mtksdaap41 \
--to=garlic.tseng@mediatek.com \
--cc=PC.Liao@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ir.lian@mediatek.com \
--cc=koro.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=srv_heupstream@mediatek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.