From: "Kani, Toshimitsu" <toshi.kani-ZPxbGqLxI0U@public.gmane.org> To: "dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Cc: "axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org" <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>, "sandeen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" <sandeen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "axboe-b10kYP2dOMg@public.gmane.org" <axboe-b10kYP2dOMg@public.gmane.org>, "linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org" <linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" <dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org" <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>, "agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" <agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Subject: Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Date: Tue, 21 Jun 2016 16:56:03 +0000 [thread overview] Message-ID: <1466527550.3504.273.camel@hpe.com> (raw) In-Reply-To: <CAPcyv4ht8B7dHe1ckv5d=bOrRzCy3=ZDVSTD0rRsak_LYD8r8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On Tue, 2016-06-21 at 09:45 -0700, Dan Williams wrote: > On Tue, Jun 21, 2016 at 9:35 AM, Kani, Toshimitsu <toshi.kani@hpe.com> > wrote: > > On Tue, 2016-06-21 at 09:25 -0700, Dan Williams wrote: > > > On Tue, Jun 21, 2016 at 8:44 AM, Kani, Toshimitsu <toshi.kani@hpe.com> > > > wrote: > > > > : > > > > I think GENHD_FL_DAX is more appropriate since DAX does not use a > > > > request queue, except for protecting the underlining device being > > > > disabled while direct_access() is called (b2e0d1625e19). > > > > > > > > About protecting direct_access, this patch assumes that the > > > > underlining device cannot be disabled until dtr() is called. Is this > > > > correct? If not, I will need to call dax_map_atomic(). > > > > > > Kernel internal usages of dax should be using dax_map_atomic() to > > > safely resolve device removal races. > > > > Will do. In such case, shall I move dax_[un]map_atomic() to block_dev.c > > and rename them to bdev_dax_[un]map_atomic()? > > Sounds good to me. I know Jeff and Christoph don't like the current > calling convention of passing in a structure. Just note that they > might ask you to change it back to a list of parameters if it moves to > bdev_dax_map_atomic(). OK, I will change it back to a list of parameters as well. Thanks, -Toshi _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshimitsu" <toshi.kani@hpe.com> To: "dan.j.williams@intel.com" <dan.j.williams@intel.com> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "sandeen@redhat.com" <sandeen@redhat.com>, "linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>, "agk@redhat.com" <agk@redhat.com>, "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>, "snitzer@redhat.com" <snitzer@redhat.com>, "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>, "axboe@kernel.dk" <axboe@kernel.dk>, "axboe@fb.com" <axboe@fb.com>, "ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>, "dm-devel@redhat.com" <dm-devel@redhat.com> Subject: Re: [PATCH 0/6] Support DAX for device-mapper dm-linear devices Date: Tue, 21 Jun 2016 16:56:03 +0000 [thread overview] Message-ID: <1466527550.3504.273.camel@hpe.com> (raw) In-Reply-To: <CAPcyv4ht8B7dHe1ckv5d=bOrRzCy3=ZDVSTD0rRsak_LYD8r8g@mail.gmail.com> On Tue, 2016-06-21 at 09:45 -0700, Dan Williams wrote: > On Tue, Jun 21, 2016 at 9:35 AM, Kani, Toshimitsu <toshi.kani@hpe.com> > wrote: > > On Tue, 2016-06-21 at 09:25 -0700, Dan Williams wrote: > > > On Tue, Jun 21, 2016 at 8:44 AM, Kani, Toshimitsu <toshi.kani@hpe.com> > > > wrote: > > > > : > > > > I think GENHD_FL_DAX is more appropriate since DAX does not use a > > > > request queue, except for protecting the underlining device being > > > > disabled while direct_access() is called (b2e0d1625e19). > > > > > > > > About protecting direct_access, this patch assumes that the > > > > underlining device cannot be disabled until dtr() is called. Is this > > > > correct? If not, I will need to call dax_map_atomic(). > > > > > > Kernel internal usages of dax should be using dax_map_atomic() to > > > safely resolve device removal races. > > > > Will do. In such case, shall I move dax_[un]map_atomic() to block_dev.c > > and rename them to bdev_dax_[un]map_atomic()? > > Sounds good to me. I know Jeff and Christoph don't like the current > calling convention of passing in a structure. Just note that they > might ask you to change it back to a list of parameters if it moves to > bdev_dax_map_atomic(). OK, I will change it back to a list of parameters as well. Thanks, -Toshi
next prev parent reply other threads:[~2016-06-21 16:56 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-13 22:21 [PATCH 0/6] Support DAX for device-mapper dm-linear devices Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` [PATCH 1/6] genhd: Add GENHD_FL_DAX to gendisk flags Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` [PATCH 2/6] block: Check GENHD_FL_DAX for DAX capability Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` [PATCH 3/6] dm: Add dm_blk_direct_access() for mapped device Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` [PATCH 4/6] dm-linear: Add linear_direct_access() Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` [PATCH 5/6] dm, dm-linear: Add dax_supported to dm_target Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` [PATCH 6/6] dm: Enable DAX support for mapper device Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:21 ` Toshi Kani 2016-06-13 22:57 ` [PATCH 0/6] Support DAX for device-mapper dm-linear devices Mike Snitzer [not found] ` <20160613225756.GA18417-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-06-20 18:00 ` Mike Snitzer 2016-06-20 18:00 ` Mike Snitzer [not found] ` <20160620180043.GA21261-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-06-20 18:31 ` Kani, Toshimitsu 2016-06-20 18:31 ` Kani, Toshimitsu [not found] ` <1466446861.3504.243.camel-ZPxbGqLxI0U@public.gmane.org> 2016-06-20 19:40 ` Mike Snitzer 2016-06-20 19:40 ` Mike Snitzer [not found] ` <20160620194026.GA21657-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-06-20 19:52 ` Mike Snitzer 2016-06-20 19:52 ` Mike Snitzer [not found] ` <20160620195217.GB21657-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-06-20 20:11 ` Kani, Toshimitsu 2016-06-20 20:11 ` Kani, Toshimitsu [not found] ` <1466452883.3504.244.camel-ZPxbGqLxI0U@public.gmane.org> 2016-06-20 21:28 ` Kani, Toshimitsu 2016-06-20 21:28 ` Kani, Toshimitsu [not found] ` <1466457467.3504.249.camel-ZPxbGqLxI0U@public.gmane.org> 2016-06-20 22:22 ` Mike Snitzer 2016-06-20 22:22 ` Mike Snitzer [not found] ` <20160620222236.GA22461-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-06-21 13:41 ` Mike Snitzer 2016-06-21 13:41 ` Mike Snitzer [not found] ` <20160621134147.GA26392-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-06-21 15:44 ` Kani, Toshimitsu 2016-06-21 15:44 ` Kani, Toshimitsu [not found] ` <1466523280.3504.262.camel-ZPxbGqLxI0U@public.gmane.org> 2016-06-21 15:50 ` Kani, Toshimitsu 2016-06-21 15:50 ` Kani, Toshimitsu 2016-06-21 16:25 ` Dan Williams 2016-06-21 16:25 ` Dan Williams [not found] ` <CAPcyv4gFREc94ANuFD_Lyddx3iqRTN2UDebgeJe3LqPL8xrVzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-06-21 16:35 ` Kani, Toshimitsu 2016-06-21 16:35 ` Kani, Toshimitsu [not found] ` <1466526342.3504.270.camel-ZPxbGqLxI0U@public.gmane.org> 2016-06-21 16:45 ` Dan Williams 2016-06-21 16:45 ` Dan Williams [not found] ` <CAPcyv4ht8B7dHe1ckv5d=bOrRzCy3=ZDVSTD0rRsak_LYD8r8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-06-21 16:56 ` Kani, Toshimitsu [this message] 2016-06-21 16:56 ` Kani, Toshimitsu 2016-06-21 18:17 ` Mike Snitzer 2016-06-21 18:17 ` Mike Snitzer 2016-06-22 17:44 ` Kani, Toshimitsu 2016-06-22 17:44 ` Kani, Toshimitsu [not found] ` <1466616868.3504.320.camel-ZPxbGqLxI0U@public.gmane.org> 2016-06-22 19:15 ` Dan Williams 2016-06-22 19:15 ` Dan Williams 2016-06-22 20:16 ` Kani, Toshimitsu 2016-06-22 22:38 ` Mike Snitzer 2016-06-22 22:38 ` Mike Snitzer [not found] ` <20160622223842.GA34512-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-06-22 22:59 ` Kani, Toshimitsu 2016-06-22 22:59 ` Kani, Toshimitsu 2016-06-13 23:18 ` Dan Williams 2016-06-13 23:18 ` Dan Williams 2016-06-13 23:18 ` Dan Williams 2016-06-13 23:59 ` Kani, Toshimitsu 2016-06-13 23:59 ` Kani, Toshimitsu 2016-06-13 23:59 ` Kani, Toshimitsu 2016-06-14 0:02 ` Dan Williams 2016-06-14 0:02 ` Dan Williams 2016-06-14 0:02 ` Dan Williams 2016-06-14 7:30 ` Dan Williams 2016-06-14 7:30 ` Dan Williams 2016-06-14 7:30 ` Dan Williams 2016-06-14 13:50 ` Jeff Moyer 2016-06-14 13:50 ` Jeff Moyer 2016-06-14 13:50 ` Jeff Moyer 2016-06-14 15:41 ` Mike Snitzer 2016-06-14 15:41 ` Mike Snitzer 2016-06-14 15:41 ` Mike Snitzer 2016-06-14 18:00 ` Kani, Toshimitsu 2016-06-14 20:19 ` Jeff Moyer 2016-06-14 20:19 ` Jeff Moyer 2016-06-14 20:19 ` Jeff Moyer 2016-06-15 1:46 ` Mike Snitzer 2016-06-15 1:46 ` Mike Snitzer 2016-06-15 2:07 ` Dan Williams 2016-06-15 2:07 ` Dan Williams 2016-06-15 2:35 ` Mike Snitzer 2016-06-15 2:35 ` Mike Snitzer 2016-06-14 15:53 ` Kani, Toshimitsu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1466527550.3504.273.camel@hpe.com \ --to=toshi.kani-zpxbgqlxi0u@public.gmane.org \ --cc=agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=axboe-b10kYP2dOMg@public.gmane.org \ --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \ --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org \ --cc=linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=sandeen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.