From: "Jan Lübbe" <jlu@pengutronix.de>
To: HS Liao <hs.liao@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Monica Wang <monica.wang@mediatek.com>,
Jiaguang Zhang <jiaguang.zhang@mediatek.com>,
Nicolas Boichat <drinkcat@chromium.org>,
cawa cheng <cawa.cheng@mediatek.com>,
Bibby Hsieh <bibby.hsieh@mediatek.com>,
YT Shen <yt.shen@mediatek.com>,
Damon Chu <damon.chu@mediatek.com>,
devicetree@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>,
Daoyuan Huang <daoyuan.huang@mediatek.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Glory Hung <glory.hung@mediatek.com>, CK HU <ck.hu@mediatek.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com,
Josh-YC Liu <josh-yc.liu@mediatek.com>,
linux-kernel@vger.kernel.org,
Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v9 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit
Date: Fri, 08 Jul 2016 12:17:46 +0200 [thread overview]
Message-ID: <1467973066.2472.238.camel@pengutronix.de> (raw)
In-Reply-To: <1467270883-1407-2-git-send-email-hs.liao@mediatek.com>
On Do, 2016-06-30 at 15:14 +0800, HS Liao wrote:
[...]
> +Required properties:
> +- compatible: Must be "mediatek,mt8173-gce"
> +- reg: Address range of the GCE unit
> +- interrupts: The interrupt signal from the GCE block
> +- clock: Clocks according to the common clock binding
> +- clock-names: Must be "gce" to stand for GCE clock
> +- #mbox-cells: Should be 1
[...]
> + #mbox-cells = <1>;
[...]
> + mediatek,gce = <&gce>;
> + mboxes = <&gce 0 1 /* main display with merging wfe */
> + &gce 1 1>; /* sub display with merging wfe */
It seems that you use two cells instead of one as you declared above.
This should be consistent.
Also, why do you need an explicit phandle to the gce if you already use
mailboxes?
Best regards,
Jan Lübbe
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: "Jan Lübbe" <jlu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: HS Liao <hs.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Monica Wang <monica.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Jiaguang Zhang
<jiaguang.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Nicolas Boichat
<drinkcat-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
cawa cheng <cawa.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Bibby Hsieh <bibby.hsieh-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
YT Shen <yt.shen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Damon Chu <damon.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Daoyuan Huang
<daoyuan.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Glory Hung <glory.hung-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
CK HU <ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
Josh-YC Liu <josh-yc.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Dennis-YC Hsieh
<dennis-yc.hsieh-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [PATCH v9 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit
Date: Fri, 08 Jul 2016 12:17:46 +0200 [thread overview]
Message-ID: <1467973066.2472.238.camel@pengutronix.de> (raw)
In-Reply-To: <1467270883-1407-2-git-send-email-hs.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On Do, 2016-06-30 at 15:14 +0800, HS Liao wrote:
[...]
> +Required properties:
> +- compatible: Must be "mediatek,mt8173-gce"
> +- reg: Address range of the GCE unit
> +- interrupts: The interrupt signal from the GCE block
> +- clock: Clocks according to the common clock binding
> +- clock-names: Must be "gce" to stand for GCE clock
> +- #mbox-cells: Should be 1
[...]
> + #mbox-cells = <1>;
[...]
> + mediatek,gce = <&gce>;
> + mboxes = <&gce 0 1 /* main display with merging wfe */
> + &gce 1 1>; /* sub display with merging wfe */
It seems that you use two cells instead of one as you declared above.
This should be consistent.
Also, why do you need an explicit phandle to the gce if you already use
mailboxes?
Best regards,
Jan Lübbe
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: jlu@pengutronix.de (Jan Lübbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit
Date: Fri, 08 Jul 2016 12:17:46 +0200 [thread overview]
Message-ID: <1467973066.2472.238.camel@pengutronix.de> (raw)
In-Reply-To: <1467270883-1407-2-git-send-email-hs.liao@mediatek.com>
On Do, 2016-06-30 at 15:14 +0800, HS Liao wrote:
[...]
> +Required properties:
> +- compatible: Must be "mediatek,mt8173-gce"
> +- reg: Address range of the GCE unit
> +- interrupts: The interrupt signal from the GCE block
> +- clock: Clocks according to the common clock binding
> +- clock-names: Must be "gce" to stand for GCE clock
> +- #mbox-cells: Should be 1
[...]
> + #mbox-cells = <1>;
[...]
> + mediatek,gce = <&gce>;
> + mboxes = <&gce 0 1 /* main display with merging wfe */
> + &gce 1 1>; /* sub display with merging wfe */
It seems that you use two cells instead of one as you declared above.
This should be consistent.
Also, why do you need an explicit phandle to the gce if you already use
mailboxes?
Best regards,
Jan L?bbe
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2016-07-08 10:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 7:14 [PATCH v9 0/4] Mediatek MT8173 CMDQ support HS Liao
2016-06-30 7:14 ` HS Liao
2016-06-30 7:14 ` HS Liao
2016-06-30 7:14 ` [PATCH v9 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit HS Liao
2016-06-30 7:14 ` HS Liao
2016-06-30 7:14 ` HS Liao
2016-07-08 10:17 ` Jan Lübbe [this message]
2016-07-08 10:17 ` Jan Lübbe
2016-07-08 10:17 ` Jan Lübbe
2016-07-11 2:55 ` Horng-Shyang Liao
2016-07-11 2:55 ` Horng-Shyang Liao
2016-07-11 2:55 ` Horng-Shyang Liao
2016-06-30 7:14 ` [PATCH v9 2/4] CMDQ: Mediatek CMDQ driver HS Liao
2016-06-30 7:14 ` HS Liao
2016-06-30 7:14 ` HS Liao
2016-06-30 7:14 ` [PATCH v9 3/4] arm64: dts: mt8173: Add GCE node HS Liao
2016-06-30 7:14 ` HS Liao
2016-06-30 7:14 ` HS Liao
2016-06-30 7:14 ` [PATCH v9 4/4] CMDQ: save more energy in idle HS Liao
2016-06-30 7:14 ` HS Liao
2016-06-30 7:14 ` HS Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467973066.2472.238.camel@pengutronix.de \
--to=jlu@pengutronix.de \
--cc=bibby.hsieh@mediatek.com \
--cc=cawa.cheng@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=damon.chu@mediatek.com \
--cc=daoyuan.huang@mediatek.com \
--cc=dennis-yc.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=drinkcat@chromium.org \
--cc=glory.hung@mediatek.com \
--cc=hs.liao@mediatek.com \
--cc=jiaguang.zhang@mediatek.com \
--cc=josh-yc.liu@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=monica.wang@mediatek.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=yt.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.