From: Dan Williams <dan.j.williams@intel.com>
To: linux-nvdimm@lists.01.org
Cc: linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org,
hch@lst.de, linux-kernel@vger.kernel.org
Subject: [PATCH v2 13/17] libnvdimm, pmem: use nvdimm_flush() for namespace I/O writes
Date: Sat, 09 Jul 2016 20:25:38 -0700 [thread overview]
Message-ID: <146812113854.32932.4086784403471595345.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <146812106839.32932.2870621200867047059.stgit@dwillia2-desk3.amr.corp.intel.com>
nsio_rw_bytes() is used to write info block metadata to the namespace,
so it should trigger a flush after every write. Replace wmb_pmem() with
nvdimm_flush() in this path.
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
drivers/nvdimm/claim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c
index 9997ff94a132..d5dc80c48b4c 100644
--- a/drivers/nvdimm/claim.c
+++ b/drivers/nvdimm/claim.c
@@ -240,7 +240,7 @@ static int nsio_rw_bytes(struct nd_namespace_common *ndns,
return memcpy_from_pmem(buf, nsio->addr + offset, size);
} else {
memcpy_to_pmem(nsio->addr + offset, buf, size);
- wmb_pmem();
+ nvdimm_flush(to_nd_region(ndns->dev.parent));
}
return 0;
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hch-jcswGhMUV9g@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v2 13/17] libnvdimm, pmem: use nvdimm_flush() for namespace I/O writes
Date: Sat, 09 Jul 2016 20:25:38 -0700 [thread overview]
Message-ID: <146812113854.32932.4086784403471595345.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <146812106839.32932.2870621200867047059.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
nsio_rw_bytes() is used to write info block metadata to the namespace,
so it should trigger a flush after every write. Replace wmb_pmem() with
nvdimm_flush() in this path.
Cc: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Signed-off-by: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
drivers/nvdimm/claim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c
index 9997ff94a132..d5dc80c48b4c 100644
--- a/drivers/nvdimm/claim.c
+++ b/drivers/nvdimm/claim.c
@@ -240,7 +240,7 @@ static int nsio_rw_bytes(struct nd_namespace_common *ndns,
return memcpy_from_pmem(buf, nsio->addr + offset, size);
} else {
memcpy_to_pmem(nsio->addr + offset, buf, size);
- wmb_pmem();
+ nvdimm_flush(to_nd_region(ndns->dev.parent));
}
return 0;
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: linux-nvdimm@ml01.01.org
Cc: linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org,
Ross Zwisler <ross.zwisler@linux.intel.com>,
hch@lst.de, linux-kernel@vger.kernel.org
Subject: [PATCH v2 13/17] libnvdimm, pmem: use nvdimm_flush() for namespace I/O writes
Date: Sat, 09 Jul 2016 20:25:38 -0700 [thread overview]
Message-ID: <146812113854.32932.4086784403471595345.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <146812106839.32932.2870621200867047059.stgit@dwillia2-desk3.amr.corp.intel.com>
nsio_rw_bytes() is used to write info block metadata to the namespace,
so it should trigger a flush after every write. Replace wmb_pmem() with
nvdimm_flush() in this path.
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
drivers/nvdimm/claim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c
index 9997ff94a132..d5dc80c48b4c 100644
--- a/drivers/nvdimm/claim.c
+++ b/drivers/nvdimm/claim.c
@@ -240,7 +240,7 @@ static int nsio_rw_bytes(struct nd_namespace_common *ndns,
return memcpy_from_pmem(buf, nsio->addr + offset, size);
} else {
memcpy_to_pmem(nsio->addr + offset, buf, size);
- wmb_pmem();
+ nvdimm_flush(to_nd_region(ndns->dev.parent));
}
return 0;
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: linux-nvdimm@lists.01.org
Cc: linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org,
Ross Zwisler <ross.zwisler@linux.intel.com>,
hch@lst.de, linux-kernel@vger.kernel.org
Subject: [PATCH v2 13/17] libnvdimm, pmem: use nvdimm_flush() for namespace I/O writes
Date: Sat, 09 Jul 2016 20:25:38 -0700 [thread overview]
Message-ID: <146812113854.32932.4086784403471595345.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <146812106839.32932.2870621200867047059.stgit@dwillia2-desk3.amr.corp.intel.com>
nsio_rw_bytes() is used to write info block metadata to the namespace,
so it should trigger a flush after every write. Replace wmb_pmem() with
nvdimm_flush() in this path.
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
drivers/nvdimm/claim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c
index 9997ff94a132..d5dc80c48b4c 100644
--- a/drivers/nvdimm/claim.c
+++ b/drivers/nvdimm/claim.c
@@ -240,7 +240,7 @@ static int nsio_rw_bytes(struct nd_namespace_common *ndns,
return memcpy_from_pmem(buf, nsio->addr + offset, size);
} else {
memcpy_to_pmem(nsio->addr + offset, buf, size);
- wmb_pmem();
+ nvdimm_flush(to_nd_region(ndns->dev.parent));
}
return 0;
next prev parent reply other threads:[~2016-07-10 3:28 UTC|newest]
Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-10 3:24 [PATCH v2 00/17] replace pcommit with ADR or directed flushing Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` [PATCH v2 01/17] nfit: always associate flush hints Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` [PATCH v2 02/17] nfit: don't override return value of nfit_mem_init Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` [PATCH v2 03/17] libnvdimm: introduce devm_nvdimm_memremap(), convert nfit_spa_map() users Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 5:30 ` kbuild test robot
2016-07-10 5:30 ` kbuild test robot
2016-07-10 5:30 ` kbuild test robot
2016-07-10 5:30 ` kbuild test robot
2016-07-12 22:22 ` [PATCH v3] " Dan Williams
2016-07-12 22:22 ` Dan Williams
2016-07-12 22:22 ` Dan Williams
2016-07-12 22:22 ` Dan Williams
2016-07-10 3:24 ` [PATCH v2 04/17] libnvdimm, nfit: remove nfit_spa_map() infrastructure Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` [PATCH v2 05/17] libnvdimm, nfit: move flush hint mapping to region-device driver-data Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:24 ` Dan Williams
2016-07-10 3:25 ` [PATCH v2 06/17] tools/testing/nvdimm: simulate multiple flush hints per-dimm Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` [PATCH v2 07/17] libnvdimm: keep region data alive over namespace removal Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` [PATCH v2 08/17] libnvdimm: introduce nvdimm_flush() and nvdimm_has_flush() Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 4:47 ` kbuild test robot
2016-07-10 4:47 ` kbuild test robot
2016-07-10 4:47 ` kbuild test robot
2016-07-10 4:47 ` kbuild test robot
2016-07-10 5:01 ` Dan Williams
2016-07-10 5:01 ` Dan Williams
2016-07-10 5:01 ` Dan Williams
2016-07-10 5:01 ` Dan Williams
2016-07-11 3:48 ` Li, Philip
2016-07-11 3:48 ` Li, Philip
2016-07-11 3:48 ` Li, Philip
2016-07-11 3:48 ` Li, Philip
2016-07-12 22:25 ` [PATCH v3] " Dan Williams
2016-07-12 22:25 ` Dan Williams
2016-07-12 22:25 ` Dan Williams
2016-07-12 22:25 ` Dan Williams
2016-07-10 3:25 ` [PATCH v2 09/17] libnvdimm: cycle flush hints Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` [PATCH v2 10/17] libnvdimm, pmem: use REQ_FUA, REQ_FLUSH for nvdimm_flush() Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-12 22:26 ` [PATCH v3] " Dan Williams
2016-07-12 22:26 ` Dan Williams
2016-07-12 22:26 ` Dan Williams
2016-07-12 22:26 ` Dan Williams
2016-07-13 19:46 ` Kani, Toshimitsu
2016-07-13 19:46 ` Kani, Toshimitsu
2016-07-13 19:46 ` Kani, Toshimitsu
2016-07-13 19:46 ` Kani, Toshimitsu
2016-07-10 3:25 ` [PATCH v2 11/17] libnvdimm, pmem: flush posted-write queues on shutdown Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` [PATCH v2 12/17] fs/dax: remove wmb_pmem() Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams [this message]
2016-07-10 3:25 ` [PATCH v2 13/17] libnvdimm, pmem: use nvdimm_flush() for namespace I/O writes Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` [PATCH v2 14/17] pmem: kill wmb_pmem() Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` [PATCH v2 15/17] Revert "KVM: x86: add pcommit support" Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` [PATCH v2 16/17] x86/insn: remove pcommit Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
[not found] ` <146812115425.32932.3314855641604340233.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-12 14:57 ` Peter Zijlstra
2016-07-12 14:57 ` Peter Zijlstra
[not found] ` <20160712145757.GV30909-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2016-07-12 22:12 ` Dan Williams
2016-07-12 22:12 ` Dan Williams
2016-07-22 15:55 ` Dan Williams
[not found] ` <CAPcyv4gE8owJZOokGJmxH97CZwkD9uBZys=2-VCBgZy8aLkT8w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-22 16:52 ` Ingo Molnar
2016-07-22 16:52 ` Ingo Molnar
2016-07-23 0:54 ` Dan Williams
[not found] ` <CAPcyv4iQn_rR5wEb0PUOVL2tsWT_-H08kgPDsKmq1LRqGkxdZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-23 7:49 ` Ingo Molnar
2016-07-23 7:49 ` Ingo Molnar
2016-07-10 3:25 ` [PATCH v2 17/17] pmem: kill __pmem address space Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
2016-07-10 3:25 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=146812113854.32932.4086784403471595345.stgit@dwillia2-desk3.amr.corp.intel.com \
--to=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.