From: Joe Perches <joe@perches.com> To: Jens Axboe <axboe@fb.com>, Josef Bacik <jbacik@fb.com>, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, mpa@pengutronix.de, nbd-general@lists.sourceforge.net Subject: Re: [PATCH 3/5] nbd: use flags instead of bool Date: Fri, 09 Sep 2016 09:04:28 -0700 [thread overview] Message-ID: <1473437068.13672.41.camel@perches.com> (raw) In-Reply-To: <bda72452-8a5f-8a6a-2409-145585ea41f5@fb.com> On Fri, 2016-09-09 at 07:55 -0600, Jens Axboe wrote: > On 09/08/2016 07:20 PM, Joe Perches wrote: > > On Thu, 2016-09-08 at 17:12 -0400, Josef Bacik wrote: > > > In preparation for some future changes, change a few of the state bools over to > > > normal bits to set/clear properly. > > [] > > > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c > > [] > > > @@ -41,8 +41,12 @@ > > > > > >�#include <linux/nbd.h> > > > > > > +#define NBD_TIMEDOUT 0 > > > +#define NBD_DISCONNECT_REQUESTED 1 > > > + > > >�struct nbd_device { > > >� u32 flags; > > + unsigned long runtime_flags; > > Better to use DECLARE_BITMAP > It's a few flags, we know it fits in a long. There's no point to using > anything but that, and set/test/clear_bit(). It lets the reader know how it's used.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: Jens Axboe <axboe@fb.com>, Josef Bacik <jbacik@fb.com>, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, mpa@pengutronix.de, nbd-general@lists.sourceforge.net Subject: Re: [PATCH 3/5] nbd: use flags instead of bool Date: Fri, 09 Sep 2016 09:04:28 -0700 [thread overview] Message-ID: <1473437068.13672.41.camel@perches.com> (raw) In-Reply-To: <bda72452-8a5f-8a6a-2409-145585ea41f5@fb.com> On Fri, 2016-09-09 at 07:55 -0600, Jens Axboe wrote: > On 09/08/2016 07:20 PM, Joe Perches wrote: > > On Thu, 2016-09-08 at 17:12 -0400, Josef Bacik wrote: > > > In preparation for some future changes, change a few of the state bools over to > > > normal bits to set/clear properly. > > [] > > > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c > > [] > > > @@ -41,8 +41,12 @@ > > > > > > #include <linux/nbd.h> > > > > > > +#define NBD_TIMEDOUT 0 > > > +#define NBD_DISCONNECT_REQUESTED 1 > > > + > > > struct nbd_device { > > > u32 flags; > > + unsigned long runtime_flags; > > Better to use DECLARE_BITMAP > It's a few flags, we know it fits in a long. There's no point to using > anything but that, and set/test/clear_bit(). It lets the reader know how it's used.
next prev parent reply other threads:[~2016-09-09 16:04 UTC|newest] Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-08 21:12 [RESEND][PATCH 0/5] nbd improvements Josef Bacik 2016-09-08 21:12 ` [PATCH 1/5] nbd: convert to blkmq Josef Bacik 2016-09-08 21:12 ` [PATCH 2/5] nbd: don't shutdown sock with irq's disabled Josef Bacik 2016-09-08 21:12 ` [PATCH 3/5] nbd: use flags instead of bool Josef Bacik 2016-09-09 1:20 ` Joe Perches 2016-09-09 13:55 ` Jens Axboe 2016-09-09 16:04 ` Joe Perches [this message] 2016-09-09 16:04 ` Joe Perches 2016-09-09 16:11 ` Jens Axboe 2016-09-09 16:15 ` Joe Perches 2016-09-09 16:20 ` Jens Axboe 2016-09-09 16:20 ` Jens Axboe 2016-09-08 21:12 ` [PATCH 4/5] nbd: allow block mq to deal with timeouts Josef Bacik 2016-09-08 21:12 ` [PATCH 5/5] nbd: add multi-connection support Josef Bacik 2016-09-10 7:43 ` Christoph Hellwig 2016-09-12 13:11 ` Josef Bacik 2016-09-09 20:02 ` [Nbd] [RESEND][PATCH 0/5] nbd improvements Wouter Verhelst 2016-09-09 20:36 ` Josef Bacik 2016-09-09 20:55 ` Wouter Verhelst 2016-09-09 23:00 ` Josef Bacik 2016-09-09 23:37 ` Jens Axboe 2016-09-15 10:49 ` Wouter Verhelst 2016-09-15 11:09 ` Alex Bligh 2016-09-15 11:09 ` Alex Bligh 2016-09-15 11:29 ` Wouter Verhelst 2016-09-15 11:29 ` Wouter Verhelst 2016-09-15 11:40 ` Christoph Hellwig 2016-09-15 11:40 ` Christoph Hellwig 2016-09-15 11:46 ` Alex Bligh 2016-09-15 11:46 ` Alex Bligh 2016-09-15 11:52 ` Christoph Hellwig 2016-09-15 11:52 ` Christoph Hellwig 2016-09-15 12:01 ` Wouter Verhelst 2016-09-15 12:01 ` Wouter Verhelst 2016-09-15 12:20 ` Christoph Hellwig 2016-09-15 12:20 ` Christoph Hellwig 2016-09-15 12:26 ` Wouter Verhelst 2016-09-15 12:26 ` Wouter Verhelst 2016-09-15 12:27 ` Christoph Hellwig 2016-09-15 12:27 ` Christoph Hellwig 2016-09-15 12:04 ` Alex Bligh 2016-09-15 12:04 ` Alex Bligh 2016-09-15 11:39 ` Christoph Hellwig 2016-09-15 11:39 ` Christoph Hellwig 2016-09-15 13:34 ` Eric Blake 2016-09-15 13:34 ` Eric Blake 2016-09-15 14:07 ` Paolo Bonzini 2016-09-15 14:07 ` Paolo Bonzini 2016-09-15 15:23 ` Alex Bligh 2016-09-15 15:23 ` Alex Bligh 2016-09-15 21:10 ` Paolo Bonzini 2016-09-15 21:10 ` Paolo Bonzini 2016-09-15 15:25 ` Alex Bligh 2016-09-15 15:25 ` Alex Bligh 2016-09-15 11:38 ` Christoph Hellwig 2016-09-15 11:43 ` Alex Bligh 2016-09-15 11:43 ` Alex Bligh 2016-09-15 11:46 ` Christoph Hellwig 2016-09-15 11:46 ` Christoph Hellwig 2016-09-15 11:56 ` Alex Bligh 2016-09-15 11:56 ` Alex Bligh 2016-09-15 11:55 ` Wouter Verhelst 2016-09-15 12:01 ` Christoph Hellwig 2016-09-15 12:11 ` Alex Bligh 2016-09-15 12:11 ` Alex Bligh 2016-09-15 12:18 ` Christoph Hellwig 2016-09-15 12:18 ` Christoph Hellwig 2016-09-15 12:28 ` Alex Bligh 2016-09-15 12:28 ` Alex Bligh 2016-09-15 12:21 ` Wouter Verhelst 2016-09-15 12:23 ` Christoph Hellwig 2016-09-15 12:33 ` Alex Bligh 2016-09-15 12:33 ` Alex Bligh 2016-09-15 12:36 ` Christoph Hellwig 2016-09-15 12:36 ` Christoph Hellwig 2016-09-15 12:39 ` Alex Bligh 2016-09-15 12:39 ` Alex Bligh 2016-09-15 12:41 ` Christoph Hellwig 2016-09-15 12:41 ` Christoph Hellwig 2016-09-15 12:44 ` Alex Bligh 2016-09-15 12:44 ` Alex Bligh 2016-09-15 13:17 ` Wouter Verhelst 2016-09-15 13:17 ` Wouter Verhelst 2016-09-15 13:57 ` Josef Bacik 2016-09-15 13:57 ` Josef Bacik 2016-09-15 15:17 ` Alex Bligh 2016-09-15 15:17 ` Alex Bligh 2016-09-15 16:08 ` Alex Bligh 2016-09-15 16:08 ` Alex Bligh 2016-09-15 16:27 ` Wouter Verhelst 2016-09-15 16:27 ` Wouter Verhelst 2016-09-15 16:42 ` Alex Bligh 2016-09-15 16:42 ` Alex Bligh 2016-09-15 19:02 ` Eric Blake 2016-09-15 19:02 ` Eric Blake
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1473437068.13672.41.camel@perches.com \ --to=joe@perches.com \ --cc=axboe@fb.com \ --cc=jbacik@fb.com \ --cc=kernel-team@fb.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mpa@pengutronix.de \ --cc=nbd-general@lists.sourceforge.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.