All of lore.kernel.org
 help / color / mirror / Atom feed
From: Horng-Shyang Liao <hs.liao@mediatek.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Daniel Kurtz <djkurtz@chromium.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	Devicetree List <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<srv_heupstream@mediatek.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	Nicolas Boichat <drinkcat@chromium.org>,
	"CK HU" <ck.hu@mediatek.com>,
	cawa cheng <cawa.cheng@mediatek.com>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	YT Shen <yt.shen@mediatek.com>,
	Daoyuan Huang <daoyuan.huang@mediatek.com>,
	Damon Chu <damon.chu@mediatek.com>,
	"Josh-YC Liu" <josh-yc.liu@mediatek.com>,
	Glory Hung <glory.hung@mediatek.com>,
	Jiaguang Zhang <jiaguang.zhang@mediatek.com>,
	Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
	Monica Wang <monica.wang@mediatek.com>, <hs.liao@mediatek.com>
Subject: Re: [PATCH v14 4/4] CMDQ: save more energy in idle
Date: Fri, 23 Sep 2016 17:28:05 +0800	[thread overview]
Message-ID: <1474622885.21723.25.camel@mtksdaap41> (raw)
In-Reply-To: <CABb+yY1YqyReK5bii6n5a_rJ6fgpPi=aC3sfKJdomvM5+NG9FA@mail.gmail.com>

On Thu, 2016-09-22 at 13:22 +0530, Jassi Brar wrote:
> On Mon, Sep 5, 2016 at 7:14 AM, HS Liao <hs.liao@mediatek.com> wrote:
> > Use clk_disable_unprepare instead of clk_disable to save more energy
> > when CMDQ is idle.
> >
> > Signed-off-by: HS Liao <hs.liao@mediatek.com>
> > ---
> >  drivers/mailbox/mtk-cmdq.c | 54 +++++++++++++++++++++++++++++++++++++++-------
> 
> The driver is introduced by second patch of the set, so it makes sense
> to merge this patch into patch 2/4.

Hi Jassi,

Could you take a look at previous discussion between Matthias and me?
http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05239.html
His basic idea is to simplify first working version.
Therefore, I move some code to this patch.

Thanks,
HS

WARNING: multiple messages have this Message-ID (diff)
From: Horng-Shyang Liao <hs.liao@mediatek.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Daniel Kurtz <djkurtz@chromium.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Devicetree List <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
	Sascha Hauer <kernel@pengutronix.de>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Nicolas Boichat <drinkcat@chromium.org>,
	CK HU <ck.hu@mediatek.com>, cawa cheng <cawa.cheng@mediatek.com>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	YT Shen <yt.shen@mediatek.com>,
	Daoyuan Huang <daoyuan.huang@mediatek.com>,
	Damon Chu <damon.chu@mediatek.com>,
	Jo
Subject: Re: [PATCH v14 4/4] CMDQ: save more energy in idle
Date: Fri, 23 Sep 2016 17:28:05 +0800	[thread overview]
Message-ID: <1474622885.21723.25.camel@mtksdaap41> (raw)
In-Reply-To: <CABb+yY1YqyReK5bii6n5a_rJ6fgpPi=aC3sfKJdomvM5+NG9FA@mail.gmail.com>

On Thu, 2016-09-22 at 13:22 +0530, Jassi Brar wrote:
> On Mon, Sep 5, 2016 at 7:14 AM, HS Liao <hs.liao@mediatek.com> wrote:
> > Use clk_disable_unprepare instead of clk_disable to save more energy
> > when CMDQ is idle.
> >
> > Signed-off-by: HS Liao <hs.liao@mediatek.com>
> > ---
> >  drivers/mailbox/mtk-cmdq.c | 54 +++++++++++++++++++++++++++++++++++++++-------
> 
> The driver is introduced by second patch of the set, so it makes sense
> to merge this patch into patch 2/4.

Hi Jassi,

Could you take a look at previous discussion between Matthias and me?
http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05239.html
His basic idea is to simplify first working version.
Therefore, I move some code to this patch.

Thanks,
HS

WARNING: multiple messages have this Message-ID (diff)
From: hs.liao@mediatek.com (Horng-Shyang Liao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v14 4/4] CMDQ: save more energy in idle
Date: Fri, 23 Sep 2016 17:28:05 +0800	[thread overview]
Message-ID: <1474622885.21723.25.camel@mtksdaap41> (raw)
In-Reply-To: <CABb+yY1YqyReK5bii6n5a_rJ6fgpPi=aC3sfKJdomvM5+NG9FA@mail.gmail.com>

On Thu, 2016-09-22 at 13:22 +0530, Jassi Brar wrote:
> On Mon, Sep 5, 2016 at 7:14 AM, HS Liao <hs.liao@mediatek.com> wrote:
> > Use clk_disable_unprepare instead of clk_disable to save more energy
> > when CMDQ is idle.
> >
> > Signed-off-by: HS Liao <hs.liao@mediatek.com>
> > ---
> >  drivers/mailbox/mtk-cmdq.c | 54 +++++++++++++++++++++++++++++++++++++++-------
> 
> The driver is introduced by second patch of the set, so it makes sense
> to merge this patch into patch 2/4.

Hi Jassi,

Could you take a look at previous discussion between Matthias and me?
http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05239.html
His basic idea is to simplify first working version.
Therefore, I move some code to this patch.

Thanks,
HS

  reply	other threads:[~2016-09-23  9:28 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05  1:44 [PATCH v14 0/4] Mediatek MT8173 CMDQ support HS Liao
2016-09-05  1:44 ` HS Liao
2016-09-05  1:44 ` HS Liao
2016-09-05  1:44 ` [PATCH v14 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit HS Liao
2016-09-05  1:44   ` HS Liao
2016-09-05  1:44   ` HS Liao
2016-09-05  1:44 ` [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver HS Liao
2016-09-05  1:44   ` HS Liao
2016-09-05  1:44   ` HS Liao
2016-09-22  8:17   ` Jassi Brar
2016-09-22  8:17     ` Jassi Brar
2016-09-22  8:17     ` Jassi Brar
2016-09-23  9:28     ` Horng-Shyang Liao
2016-09-23  9:28       ` Horng-Shyang Liao
2016-09-23  9:28       ` Horng-Shyang Liao
2016-09-30  8:56       ` Horng-Shyang Liao
2016-09-30  8:56         ` Horng-Shyang Liao
2016-09-30  8:56         ` Horng-Shyang Liao
2016-09-30  3:06   ` CK Hu
2016-09-30  3:06     ` CK Hu
2016-09-30  3:06     ` CK Hu
2016-09-30  8:56     ` Horng-Shyang Liao
2016-09-30  8:56       ` Horng-Shyang Liao
2016-09-30  8:56       ` Horng-Shyang Liao
2016-09-30  9:11       ` CK Hu
2016-09-30  9:11         ` CK Hu
2016-09-30  9:11         ` CK Hu
2016-09-30  9:47         ` Horng-Shyang Liao
2016-09-30  9:47           ` Horng-Shyang Liao
2016-09-30  9:47           ` Horng-Shyang Liao
2016-10-05  2:54           ` Horng-Shyang Liao
2016-10-05  2:54             ` Horng-Shyang Liao
2016-10-05  2:54             ` Horng-Shyang Liao
2016-10-05  3:37             ` Jassi Brar
2016-10-05  3:37               ` Jassi Brar
2016-10-05  3:37               ` Jassi Brar
2016-10-05 12:31               ` Horng-Shyang Liao
2016-10-05 12:31                 ` Horng-Shyang Liao
2016-10-05 12:31                 ` Horng-Shyang Liao
2016-10-05 14:43                 ` Jassi Brar
2016-10-05 14:43                   ` Jassi Brar
2016-10-05 14:43                   ` Jassi Brar
2016-10-06 13:01                   ` Horng-Shyang Liao
2016-10-06 13:01                     ` Horng-Shyang Liao
2016-10-06 13:01                     ` Horng-Shyang Liao
2016-10-06 13:10                     ` Jassi Brar
2016-10-06 13:10                       ` Jassi Brar
2016-10-06 13:10                       ` Jassi Brar
2016-10-11  2:40                       ` Horng-Shyang Liao
2016-10-11  2:40                         ` Horng-Shyang Liao
2016-10-11  2:40                         ` Horng-Shyang Liao
2016-10-11  4:19                         ` Jassi Brar
2016-10-11  4:19                           ` Jassi Brar
2016-10-11  4:19                           ` Jassi Brar
2016-09-05  1:44 ` [PATCH v14 3/4] arm64: dts: mt8173: Add GCE node HS Liao
2016-09-05  1:44   ` HS Liao
2016-09-05  1:44   ` HS Liao
2016-09-05  1:44 ` [PATCH v14 4/4] CMDQ: save more energy in idle HS Liao
2016-09-05  1:44   ` HS Liao
2016-09-05  1:44   ` HS Liao
2016-09-22  7:52   ` Jassi Brar
2016-09-22  7:52     ` Jassi Brar
2016-09-22  7:52     ` Jassi Brar
2016-09-23  9:28     ` Horng-Shyang Liao [this message]
2016-09-23  9:28       ` Horng-Shyang Liao
2016-09-23  9:28       ` Horng-Shyang Liao
2016-09-30  8:56       ` Horng-Shyang Liao
2016-09-30  8:56         ` Horng-Shyang Liao
2016-09-30  8:56         ` Horng-Shyang Liao
2016-09-30  9:01         ` Matthias Brugger
2016-09-30  9:01           ` Matthias Brugger
2016-09-30  9:01           ` Matthias Brugger
2016-09-19  6:43 ` [PATCH v14 0/4] Mediatek MT8173 CMDQ support Horng-Shyang Liao
2016-09-19  6:43   ` Horng-Shyang Liao
2016-09-19  6:43   ` Horng-Shyang Liao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474622885.21723.25.camel@mtksdaap41 \
    --to=hs.liao@mediatek.com \
    --cc=bibby.hsieh@mediatek.com \
    --cc=cawa.cheng@mediatek.com \
    --cc=ck.hu@mediatek.com \
    --cc=damon.chu@mediatek.com \
    --cc=daoyuan.huang@mediatek.com \
    --cc=dennis-yc.hsieh@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=djkurtz@chromium.org \
    --cc=drinkcat@chromium.org \
    --cc=glory.hung@mediatek.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=jiaguang.zhang@mediatek.com \
    --cc=josh-yc.liu@mediatek.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=monica.wang@mediatek.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=srv_heupstream@mediatek.com \
    --cc=yt.shen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.