From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: axboe@kernel.dk, akpm@linux-foundation.org, darrick.wong@oracle.com
Cc: linux-block@vger.kernel.org, tytso@mit.edu,
martin.petersen@oracle.com, snitzer@redhat.com,
linux-api@vger.kernel.org, bfoster@redhat.com, xfs@oss.sgi.com,
hch@infradead.org, dm-devel@redhat.com, hare@suse.de,
linux-fsdevel@vger.kernel.org, bart.vanassche@sandisk.com
Subject: [PATCH v11 0/3] fallocate for block devices
Date: Thu, 29 Sep 2016 14:16:16 -0700 [thread overview]
Message-ID: <147518377601.22791.14436504108602322570.stgit@birch.djwong.org> (raw)
Hi Andrew & others,
This is a resend of the patchset to fix page cache coherency with
BLKZEROOUT and implement fallocate for block devices. This time I'm
sending it direct to Andrew for inclusion because the block layer
maintainer has not been responsive over the past year of submissions.
Can this please go upstream for 4.9?
The first patch is still a fix to the existing BLKZEROOUT ioctl to
invalidate the page cache if the zeroing command to the underlying
device succeeds. Without this patch we still have the pagecache
coherence bug that's been in the kernel forever.
The second patch changes the internal block device functions to reject
attempts to discard or zeroout that are not aligned to the logical
block size. Previously, we only checked that the start/len parameters
were 512-byte aligned, which caused kernel BUG_ONs for unaligned IOs
to 4k-LBA devices.
The third patch creates an fallocate handler for block devices, wires
up the FALLOC_FL_PUNCH_HOLE flag to zeroing-discard, and connects
FALLOC_FL_ZERO_RANGE to write-same so that we can have a consistent
fallocate interface between files and block devices. It also allows
the combination of PUNCH_HOLE and NO_HIDE_STALE to invoke non-zeroing
discard.
Test cases for the new block device fallocate are now in xfstests as
generic/349-351.
Comments and questions are, as always, welcome. Patches are against
4.8-rc8.
v7: Strengthen parameter checking and fix various code issues pointed
out by Linus and Christoph.
v8: More code rearranging, rebase to 4.6-rc3, and dig into alignment
issues.
v9: Forward port to 4.7.
v10: Forward port to 4.8. Remove the extra call to
invalidate_inode_pages2_range per Bart Van Assche's request.
v11: Minor fallocate code cleanups suggested by Bart Van Assche.
--D
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: axboe@kernel.dk, akpm@linux-foundation.org, darrick.wong@oracle.com
Cc: hch@infradead.org, tytso@mit.edu, martin.petersen@oracle.com,
snitzer@redhat.com, linux-api@vger.kernel.org,
bfoster@redhat.com, xfs@oss.sgi.com, linux-block@vger.kernel.org,
dm-devel@redhat.com, hare@suse.de, linux-fsdevel@vger.kernel.org,
bart.vanassche@sandisk.com
Subject: [PATCH v11 0/3] fallocate for block devices
Date: Thu, 29 Sep 2016 14:16:16 -0700 [thread overview]
Message-ID: <147518377601.22791.14436504108602322570.stgit@birch.djwong.org> (raw)
Hi Andrew & others,
This is a resend of the patchset to fix page cache coherency with
BLKZEROOUT and implement fallocate for block devices. This time I'm
sending it direct to Andrew for inclusion because the block layer
maintainer has not been responsive over the past year of submissions.
Can this please go upstream for 4.9?
The first patch is still a fix to the existing BLKZEROOUT ioctl to
invalidate the page cache if the zeroing command to the underlying
device succeeds. Without this patch we still have the pagecache
coherence bug that's been in the kernel forever.
The second patch changes the internal block device functions to reject
attempts to discard or zeroout that are not aligned to the logical
block size. Previously, we only checked that the start/len parameters
were 512-byte aligned, which caused kernel BUG_ONs for unaligned IOs
to 4k-LBA devices.
The third patch creates an fallocate handler for block devices, wires
up the FALLOC_FL_PUNCH_HOLE flag to zeroing-discard, and connects
FALLOC_FL_ZERO_RANGE to write-same so that we can have a consistent
fallocate interface between files and block devices. It also allows
the combination of PUNCH_HOLE and NO_HIDE_STALE to invoke non-zeroing
discard.
Test cases for the new block device fallocate are now in xfstests as
generic/349-351.
Comments and questions are, as always, welcome. Patches are against
4.8-rc8.
v7: Strengthen parameter checking and fix various code issues pointed
out by Linus and Christoph.
v8: More code rearranging, rebase to 4.6-rc3, and dig into alignment
issues.
v9: Forward port to 4.7.
v10: Forward port to 4.8. Remove the extra call to
invalidate_inode_pages2_range per Bart Van Assche's request.
v11: Minor fallocate code cleanups suggested by Bart Van Assche.
--D
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2016-09-29 21:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 21:16 Darrick J. Wong [this message]
2016-09-29 21:16 ` [PATCH v11 0/3] fallocate for block devices Darrick J. Wong
2016-09-29 21:16 ` [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT Darrick J. Wong
2016-09-29 21:16 ` Darrick J. Wong
2016-09-29 21:16 ` [PATCH 2/3] block: require write_same and discard requests align to logical block size Darrick J. Wong
2016-09-29 21:16 ` Darrick J. Wong
2016-09-29 21:16 ` [PATCH 3/3] block: implement (some of) fallocate for block devices Darrick J. Wong
2016-09-29 21:16 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147518377601.22791.14436504108602322570.stgit@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=bfoster@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.