From: Eric Auger <eric.auger@redhat.com> To: eric.auger@redhat.com, eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, robin.murphy@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, joro@8bytes.org, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org Cc: kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, Bharat.Bhushan@freescale.com, pranav.sawargaonkar@gmail.com, p.fedin@samsung.com, iommu@lists.linux-foundation.org, Jean-Philippe.Brucker@arm.com, yehuday@marvell.com, Manish.Jaggi@caviumnetworks.com Subject: [PATCH v13 01/15] iommu: Introduce DOMAIN_ATTR_MSI_GEOMETRY Date: Thu, 6 Oct 2016 08:45:17 +0000 [thread overview] Message-ID: <1475743531-4780-2-git-send-email-eric.auger@redhat.com> (raw) In-Reply-To: <1475743531-4780-1-git-send-email-eric.auger@redhat.com> Introduce a new DOMAIN_ATTR_MSI_GEOMETRY domain attribute. It enables to query the aperture of the IOVA window dedicated to MSIs and test whether the MSIs must be IOMMU mapped. x86 IOMMUs will typically expose an MSI aperture matching the 1MB region [FEE0_0000h - FEF0_000h] corresponding to the the APIC configuration space and no support for MSI IOMMU mapping. On ARM, the requirement to map MSIs will be reported by setting iommu_msi_supported to true. A helper function is added to allow testing if the aperture is valid. Signed-off-by: Eric Auger <eric.auger@redhat.com> Suggested-by: Alex Williamson <alex.williamson@redhat.com> --- v12 -> v13: - reword the commit message v8 -> v9: - rename programmable into iommu_msi_supported - add iommu_domain_msi_aperture_valid v8: creation - deprecates DOMAIN_ATTR_MSI_MAPPING flag --- drivers/iommu/iommu.c | 5 +++++ include/linux/iommu.h | 14 ++++++++++++++ 2 files changed, 19 insertions(+) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 9a2f196..617cb2b 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -1485,6 +1485,7 @@ int iommu_domain_get_attr(struct iommu_domain *domain, enum iommu_attr attr, void *data) { struct iommu_domain_geometry *geometry; + struct iommu_domain_msi_geometry *msi_geometry; bool *paging; int ret = 0; u32 *count; @@ -1495,6 +1496,10 @@ int iommu_domain_get_attr(struct iommu_domain *domain, *geometry = domain->geometry; break; + case DOMAIN_ATTR_MSI_GEOMETRY: + msi_geometry = data; + *msi_geometry = domain->msi_geometry; + break; case DOMAIN_ATTR_PAGING: paging = data; *paging = (domain->pgsize_bitmap != 0UL); diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 436dc21..9f90735 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -52,6 +52,12 @@ struct iommu_domain_geometry { bool force_aperture; /* DMA only allowed in mappable range? */ }; +struct iommu_domain_msi_geometry { + dma_addr_t aperture_start; /* First address used for MSI IOVA */ + dma_addr_t aperture_end; /* Last address used for MSI IOVA */ + bool iommu_msi_supported; /* Is MSI mapping supported? */ +}; + /* Domain feature flags */ #define __IOMMU_DOMAIN_PAGING (1U << 0) /* Support for iommu_map/unmap */ #define __IOMMU_DOMAIN_DMA_API (1U << 1) /* Domain for use in DMA-API @@ -83,6 +89,7 @@ struct iommu_domain { iommu_fault_handler_t handler; void *handler_token; struct iommu_domain_geometry geometry; + struct iommu_domain_msi_geometry msi_geometry; void *iova_cookie; }; @@ -108,6 +115,7 @@ enum iommu_cap { enum iommu_attr { DOMAIN_ATTR_GEOMETRY, + DOMAIN_ATTR_MSI_GEOMETRY, DOMAIN_ATTR_PAGING, DOMAIN_ATTR_WINDOWS, DOMAIN_ATTR_FSL_PAMU_STASH, @@ -352,6 +360,12 @@ int iommu_fwspec_init(struct device *dev, struct fwnode_handle *iommu_fwnode, void iommu_fwspec_free(struct device *dev); int iommu_fwspec_add_ids(struct device *dev, u32 *ids, int num_ids); +static inline bool iommu_domain_msi_aperture_valid(struct iommu_domain *domain) +{ + return (domain->msi_geometry.aperture_end > + domain->msi_geometry.aperture_start); +} + #else /* CONFIG_IOMMU_API */ struct iommu_ops {}; -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: eric.auger@redhat.com (Eric Auger) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v13 01/15] iommu: Introduce DOMAIN_ATTR_MSI_GEOMETRY Date: Thu, 6 Oct 2016 08:45:17 +0000 [thread overview] Message-ID: <1475743531-4780-2-git-send-email-eric.auger@redhat.com> (raw) In-Reply-To: <1475743531-4780-1-git-send-email-eric.auger@redhat.com> Introduce a new DOMAIN_ATTR_MSI_GEOMETRY domain attribute. It enables to query the aperture of the IOVA window dedicated to MSIs and test whether the MSIs must be IOMMU mapped. x86 IOMMUs will typically expose an MSI aperture matching the 1MB region [FEE0_0000h - FEF0_000h] corresponding to the the APIC configuration space and no support for MSI IOMMU mapping. On ARM, the requirement to map MSIs will be reported by setting iommu_msi_supported to true. A helper function is added to allow testing if the aperture is valid. Signed-off-by: Eric Auger <eric.auger@redhat.com> Suggested-by: Alex Williamson <alex.williamson@redhat.com> --- v12 -> v13: - reword the commit message v8 -> v9: - rename programmable into iommu_msi_supported - add iommu_domain_msi_aperture_valid v8: creation - deprecates DOMAIN_ATTR_MSI_MAPPING flag --- drivers/iommu/iommu.c | 5 +++++ include/linux/iommu.h | 14 ++++++++++++++ 2 files changed, 19 insertions(+) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 9a2f196..617cb2b 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -1485,6 +1485,7 @@ int iommu_domain_get_attr(struct iommu_domain *domain, enum iommu_attr attr, void *data) { struct iommu_domain_geometry *geometry; + struct iommu_domain_msi_geometry *msi_geometry; bool *paging; int ret = 0; u32 *count; @@ -1495,6 +1496,10 @@ int iommu_domain_get_attr(struct iommu_domain *domain, *geometry = domain->geometry; break; + case DOMAIN_ATTR_MSI_GEOMETRY: + msi_geometry = data; + *msi_geometry = domain->msi_geometry; + break; case DOMAIN_ATTR_PAGING: paging = data; *paging = (domain->pgsize_bitmap != 0UL); diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 436dc21..9f90735 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -52,6 +52,12 @@ struct iommu_domain_geometry { bool force_aperture; /* DMA only allowed in mappable range? */ }; +struct iommu_domain_msi_geometry { + dma_addr_t aperture_start; /* First address used for MSI IOVA */ + dma_addr_t aperture_end; /* Last address used for MSI IOVA */ + bool iommu_msi_supported; /* Is MSI mapping supported? */ +}; + /* Domain feature flags */ #define __IOMMU_DOMAIN_PAGING (1U << 0) /* Support for iommu_map/unmap */ #define __IOMMU_DOMAIN_DMA_API (1U << 1) /* Domain for use in DMA-API @@ -83,6 +89,7 @@ struct iommu_domain { iommu_fault_handler_t handler; void *handler_token; struct iommu_domain_geometry geometry; + struct iommu_domain_msi_geometry msi_geometry; void *iova_cookie; }; @@ -108,6 +115,7 @@ enum iommu_cap { enum iommu_attr { DOMAIN_ATTR_GEOMETRY, + DOMAIN_ATTR_MSI_GEOMETRY, DOMAIN_ATTR_PAGING, DOMAIN_ATTR_WINDOWS, DOMAIN_ATTR_FSL_PAMU_STASH, @@ -352,6 +360,12 @@ int iommu_fwspec_init(struct device *dev, struct fwnode_handle *iommu_fwnode, void iommu_fwspec_free(struct device *dev); int iommu_fwspec_add_ids(struct device *dev, u32 *ids, int num_ids); +static inline bool iommu_domain_msi_aperture_valid(struct iommu_domain *domain) +{ + return (domain->msi_geometry.aperture_end > + domain->msi_geometry.aperture_start); +} + #else /* CONFIG_IOMMU_API */ struct iommu_ops {}; -- 1.9.1
next prev parent reply other threads:[~2016-10-06 8:45 UTC|newest] Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-06 8:45 [PATCH v13 00/15] KVM PCIe/MSI passthrough on ARM/ARM64 Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger [this message] 2016-10-06 8:45 ` [PATCH v13 01/15] iommu: Introduce DOMAIN_ATTR_MSI_GEOMETRY Eric Auger 2016-10-06 8:45 ` [PATCH v13 02/15] iommu/arm-smmu: Initialize the msi geometry Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 20:16 ` Alex Williamson 2016-10-06 20:16 ` Alex Williamson 2016-10-06 20:16 ` Alex Williamson 2016-10-06 8:45 ` [PATCH v13 03/15] iommu/dma: Allow MSI-only cookies Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 20:17 ` Alex Williamson 2016-10-06 20:17 ` Alex Williamson 2016-10-06 20:17 ` Alex Williamson 2016-10-07 17:14 ` Auger Eric 2016-10-07 17:14 ` Auger Eric 2016-10-07 17:14 ` Auger Eric 2016-10-10 14:26 ` Robin Murphy 2016-10-10 14:26 ` Robin Murphy 2016-10-10 14:26 ` Robin Murphy 2016-10-10 14:47 ` Auger Eric 2016-10-10 14:47 ` Auger Eric 2016-10-10 14:47 ` Auger Eric 2016-10-10 15:52 ` Robin Murphy 2016-10-10 15:52 ` Robin Murphy 2016-10-10 15:52 ` Robin Murphy 2016-10-06 8:45 ` [PATCH v13 04/15] genirq/msi: Introduce the MSI doorbell API Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 20:17 ` Alex Williamson 2016-10-06 20:17 ` Alex Williamson 2016-10-07 17:13 ` Auger Eric 2016-10-07 17:13 ` Auger Eric 2016-10-07 17:13 ` Auger Eric 2016-10-06 8:45 ` [PATCH v13 05/15] genirq/msi: msi_doorbell_calc_pages Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` [PATCH v13 06/15] irqchip/gic-v2m: Register the MSI doorbell Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` [PATCH v13 07/15] irqchip/gicv3-its: " Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` [PATCH v13 08/15] vfio: Introduce a vfio_dma type field Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 20:18 ` Alex Williamson 2016-10-06 20:18 ` Alex Williamson 2016-10-06 20:18 ` Alex Williamson 2016-10-06 8:45 ` [PATCH v13 09/15] vfio/type1: vfio_find_dma accepting a type argument Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 20:18 ` Alex Williamson 2016-10-06 20:18 ` Alex Williamson 2016-10-06 20:18 ` Alex Williamson 2016-10-06 8:45 ` [PATCH v13 10/15] vfio/type1: Implement recursive vfio_find_dma_from_node Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 20:19 ` Alex Williamson 2016-10-06 20:19 ` Alex Williamson 2016-10-06 20:19 ` Alex Williamson 2016-10-06 8:45 ` [PATCH v13 11/15] vfio/type1: Handle unmap/unpin and replay for VFIO_IOVA_RESERVED slots Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 20:19 ` Alex Williamson 2016-10-06 20:19 ` Alex Williamson 2016-10-06 20:19 ` Alex Williamson 2016-10-07 17:11 ` Auger Eric 2016-10-07 17:11 ` Auger Eric 2016-10-07 17:11 ` Auger Eric 2016-10-06 8:45 ` [PATCH v13 12/15] vfio: Allow reserved msi iova registration Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 20:19 ` Alex Williamson 2016-10-06 20:19 ` Alex Williamson 2016-10-06 20:19 ` Alex Williamson 2016-10-07 17:11 ` Auger Eric 2016-10-07 17:11 ` Auger Eric 2016-10-07 17:11 ` Auger Eric 2016-10-07 20:45 ` Alex Williamson 2016-10-07 20:45 ` Alex Williamson 2016-10-07 20:45 ` Alex Williamson 2016-10-06 8:45 ` [PATCH v13 13/15] vfio/type1: Check doorbell safety Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 20:19 ` Alex Williamson 2016-10-06 20:19 ` Alex Williamson 2016-10-06 20:19 ` Alex Williamson 2016-10-06 8:45 ` [PATCH v13 14/15] iommu/arm-smmu: Do not advertise IOMMU_CAP_INTR_REMAP Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` [PATCH v13 15/15] vfio/type1: Return the MSI geometry through VFIO_IOMMU_GET_INFO capability chains Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 8:45 ` Eric Auger 2016-10-06 20:20 ` Alex Williamson 2016-10-06 20:20 ` Alex Williamson 2016-10-06 20:20 ` Alex Williamson 2016-10-06 20:42 ` Alex Williamson 2016-10-06 20:42 ` Alex Williamson 2016-10-06 20:42 ` Alex Williamson 2016-10-07 17:10 ` Auger Eric 2016-10-07 17:10 ` Auger Eric 2016-10-07 17:10 ` Auger Eric 2016-10-07 20:38 ` Alex Williamson 2016-10-07 20:38 ` Alex Williamson 2016-10-07 20:38 ` Alex Williamson 2016-10-10 15:01 ` Auger Eric 2016-10-10 15:01 ` Auger Eric
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1475743531-4780-2-git-send-email-eric.auger@redhat.com \ --to=eric.auger@redhat.com \ --cc=Bharat.Bhushan@freescale.com \ --cc=Jean-Philippe.Brucker@arm.com \ --cc=Manish.Jaggi@caviumnetworks.com \ --cc=alex.williamson@redhat.com \ --cc=christoffer.dall@linaro.org \ --cc=drjones@redhat.com \ --cc=eric.auger.pro@gmail.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jason@lakedaemon.net \ --cc=joro@8bytes.org \ --cc=kvm@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=p.fedin@samsung.com \ --cc=pranav.sawargaonkar@gmail.com \ --cc=robin.murphy@arm.com \ --cc=tglx@linutronix.de \ --cc=will.deacon@arm.com \ --cc=yehuday@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.