From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-serial@vger.kernel.org
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] serial: 8250_uniphier: fix clearing divisor latch access bit
Date: Mon, 24 Oct 2016 17:00:28 +0900 [thread overview]
Message-ID: <1477296030-7517-3-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1477296030-7517-1-git-send-email-yamada.masahiro@socionext.com>
At this point, 'value' is always a byte, then this code is clearing
bit 15, which is already clear. I meant to clear bit 7.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reported-by: Denys Vlasenko <dvlasenk@redhat.com>
---
drivers/tty/serial/8250/8250_uniphier.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
index a8babb0..417d9e7 100644
--- a/drivers/tty/serial/8250/8250_uniphier.c
+++ b/drivers/tty/serial/8250/8250_uniphier.c
@@ -99,7 +99,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
case UART_LCR:
valshift = UNIPHIER_UART_LCR_SHIFT;
/* Divisor latch access bit does not exist. */
- value &= ~(UART_LCR_DLAB << valshift);
+ value &= ~UART_LCR_DLAB;
/* fall through */
case UART_MCR:
offset = UNIPHIER_UART_LCR_MCR;
--
1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: yamada.masahiro@socionext.com (Masahiro Yamada)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] serial: 8250_uniphier: fix clearing divisor latch access bit
Date: Mon, 24 Oct 2016 17:00:28 +0900 [thread overview]
Message-ID: <1477296030-7517-3-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1477296030-7517-1-git-send-email-yamada.masahiro@socionext.com>
At this point, 'value' is always a byte, then this code is clearing
bit 15, which is already clear. I meant to clear bit 7.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reported-by: Denys Vlasenko <dvlasenk@redhat.com>
---
drivers/tty/serial/8250/8250_uniphier.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
index a8babb0..417d9e7 100644
--- a/drivers/tty/serial/8250/8250_uniphier.c
+++ b/drivers/tty/serial/8250/8250_uniphier.c
@@ -99,7 +99,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
case UART_LCR:
valshift = UNIPHIER_UART_LCR_SHIFT;
/* Divisor latch access bit does not exist. */
- value &= ~(UART_LCR_DLAB << valshift);
+ value &= ~UART_LCR_DLAB;
/* fall through */
case UART_MCR:
offset = UNIPHIER_UART_LCR_MCR;
--
1.9.1
next prev parent reply other threads:[~2016-10-24 7:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 8:00 [PATCH 0/4] serial: 8250_uniphier: some fixes and optimization Masahiro Yamada
2016-10-24 8:00 ` Masahiro Yamada
2016-10-24 8:00 ` [PATCH 1/4] serial: 8250_uniphier: fix more unterminated string Masahiro Yamada
2016-10-24 8:00 ` Masahiro Yamada
2016-10-24 8:00 ` Masahiro Yamada [this message]
2016-10-24 8:00 ` [PATCH 2/4] serial: 8250_uniphier: fix clearing divisor latch access bit Masahiro Yamada
2016-10-24 8:00 ` [PATCH 3/4] serial: 8250_uniphier: hardcode regshift to avoid unneeded memory read Masahiro Yamada
2016-10-24 8:00 ` Masahiro Yamada
2016-10-24 8:00 ` [PATCH 4/4] serial: 8250_uniphier: avoid locking for FCR register write Masahiro Yamada
2016-10-24 8:00 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477296030-7517-3-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=dvlasenk@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.