From: Tom Haynes <loghyr@primarydata.com>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH pynfs 08/12] Add a check to see if NFS4ERR_OLD_STATEID is issued on concurrent layoutgets
Date: Sat, 26 Nov 2016 22:26:37 -0800 [thread overview]
Message-ID: <1480228001-64821-9-git-send-email-loghyr@primarydata.com> (raw)
In-Reply-To: <1480228001-64821-1-git-send-email-loghyr@primarydata.com>
Signed-off-by: Tom Haynes <loghyr@primarydata.com>
---
nfs4.1/server41tests/st_flex.py | 68 +++++++++++++++++++++++++++++++++++++=
++--
1 file changed, 66 insertions(+), 2 deletions(-)
diff --git a/nfs4.1/server41tests/st_flex.py b/nfs4.1/server41tests/st_flex=
.py
index bb4405c..8ecb114 100644
--- a/nfs4.1/server41tests/st_flex.py
+++ b/nfs4.1/server41tests/st_flex.py
@@ -106,6 +106,70 @@ def testFlexLayoutReturnFile(t, env):
res =3D close_file(sess, fh, stateid=3Dopen_stateid)
check(res)
=20
+def testFlexLayoutOldSeqid(t, env):
+ """Check that we do not get NFS4ERR_OLD_STATEID if we send
+ two LAYOUTGETS in a row without bumping the seqid
+
+ FLAGS: flex
+ CODE: FFLOOS
+ """
+ seqid_next =3D 1
+ sess =3D env.c1.new_pnfs_client_session(env.testname(t))
+ # Create the file
+ res =3D create_file(sess, env.testname(t))
+ check(res)
+
+ # Get layout 1
+ fh =3D res.resarray[-1].object
+ open_stateid =3D res.resarray[-2].stateid
+
+ ops =3D [op.putfh(fh),
+ op.layoutget(False, LAYOUT4_FLEX_FILES,
+ LAYOUTIOMODE4_RW,
+ 0, 0xffffffffffffffff, 8192, open_stateid, 0xffff)=
]
+ res =3D sess.compound(ops)
+ check(res)
+ lo_stateid =3D res.resarray[-1].logr_stateid
+
+ if lo_stateid.seqid !=3D seqid_next:
+ fail("Expected stateid.seqid=3D=3D%i, got %i" % (seqid_next, lo_st=
ateid.seqid))
+ seqid_next +=3D 1
+
+ # Get the first with the lo_stateid
+ ops =3D [op.putfh(fh),
+ op.layoutget(False, LAYOUT4_FLEX_FILES,
+ LAYOUTIOMODE4_RW,
+ 0, 0xffffffffffffffff, 8192, lo_stateid, 0xffff)]
+ res =3D sess.compound(ops)
+ check(res)
+ lo_stateid2 =3D res.resarray[-1].logr_stateid
+
+ if lo_stateid2.seqid !=3D seqid_next:
+ fail("Expected stateid.seqid=3D=3D%i, got %i" % (seqid_next, lo_st=
ateid2.seqid))
+ seqid_next +=3D 1
+
+ # Get the second with the original lo_stateid
+ ops =3D [op.putfh(fh),
+ op.layoutget(False, LAYOUT4_FLEX_FILES,
+ LAYOUTIOMODE4_RW,
+ 0, 0xffffffffffffffff, 8192, lo_stateid, 0xffff)]
+ res =3D sess.compound(ops)
+ check(res)
+ lo_stateid3 =3D res.resarray[-1].logr_stateid
+
+ if lo_stateid3.seqid !=3D seqid_next:
+ fail("Expected stateid.seqid=3D=3D%i, got %i" % (seqid_next, lo_st=
ateid3.seqid))
+ seqid_next +=3D 1
+
+ ops =3D [op.putfh(fh),
+ op.layoutreturn(False, LAYOUT4_FLEX_FILES, LAYOUTIOMODE4_ANY,
+ layoutreturn4(LAYOUTRETURN4_FILE,
+ layoutreturn_file4(0, 0xfffffffff=
fffffff, lo_stateid, "")))]
+ res =3D sess.compound(ops)
+ check(res)
+ res =3D close_file(sess, fh, stateid=3Dopen_stateid)
+ check(res)
+
def testFlexLayoutStress(t, env):
"""Alternate LAYOUTIOMODE4_RW/LAYOUTIOMODE4_READ layout segments in th=
e file
=20
@@ -117,7 +181,7 @@ def testFlexLayoutStress(t, env):
# Create the file
res =3D create_file(sess, env.testname(t))
check(res)
- # Get layout 1
+
fh =3D res.resarray[-1].object
open_stateid =3D res.resarray[-2].stateid
lo_stateid =3D open_stateid
@@ -126,7 +190,7 @@ def testFlexLayoutStress(t, env):
ops =3D [op.putfh(fh),
op.layoutget(False, LAYOUT4_FLEX_FILES,
LAYOUTIOMODE4_READ if i%2 else LAYOUTIOMODE4_=
RW,
- i * 8192, 8192, 8192, lo_stateid, 0xffff)]
+ 0, 0xffffffffffffffff, 8192, lo_stateid, 0xfff=
f)]
res =3D sess.compound(ops)
check(res)
lo_stateid =3D res.resarray[-1].logr_stateid
--=20
2.3.6
next prev parent reply other threads:[~2016-11-27 6:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 6:26 [PATCH pynfs 00/12] Flex File support Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 01/12] According to RFC7863, this is not an array Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 02/12] Close the files opened in the OPEN tests Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 03/12] Some more file closes to cleanup state on the server Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 04/12] Get rid of the client records as well as the session records Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 05/12] Really, really close those open temp files to remove state on the server Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 06/12] Add xdr for Flex Files Layout Type Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 07/12] Simple tests of the flex file layout type Tom Haynes
2016-11-27 6:26 ` Tom Haynes [this message]
2016-11-27 6:26 ` [PATCH pynfs 09/12] Check that the flex file access uid/gid are correct for the different iomodes Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 10/12] FFLS1: Simulate LAYOUTSTATS for 20 small file creations Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 11/12] Factor out checking seqid for flex file layouts Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 12/12] Add layoutstats tests for flex files Tom Haynes
2016-11-28 17:22 ` J. Bruce Fields
2016-11-28 17:52 ` Tom Haynes
2016-11-28 16:33 ` [PATCH pynfs 00/12] Flex File support J. Bruce Fields
2016-11-28 16:53 ` Tom Haynes
2016-11-28 21:47 ` J. Bruce Fields
2016-11-28 23:38 ` Tom Haynes
2016-11-29 1:55 ` J. Bruce Fields
2016-11-29 23:44 ` Frank Filz
2016-11-30 14:24 ` J. Bruce Fields
2016-11-30 16:56 ` Frank Filz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480228001-64821-9-git-send-email-loghyr@primarydata.com \
--to=loghyr@primarydata.com \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.