From: Tom Haynes <loghyr@excfb.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: "J. Bruce Fields" <bfields@redhat.com>,
Tom Haynes <loghyr@primarydata.com>,
Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH pynfs 00/12] Flex File support
Date: Mon, 28 Nov 2016 15:38:31 -0800 [thread overview]
Message-ID: <20161128233831.GD30012@psyklo.internal.excfb.com> (raw)
In-Reply-To: <20161128214725.GD30954@fieldses.org>
On Mon, Nov 28, 2016 at 04:47:25PM -0500, J. Bruce Fields wrote:
> On Mon, Nov 28, 2016 at 11:33:21AM -0500, J. Bruce Fields wrote:
> > On Sat, Nov 26, 2016 at 10:26:29PM -0800, Tom Haynes wrote:
> > > I wanted to add client support for the flex file layout.
> > >
> > > Note, I did not add pynfs as a flag because I didn't want to
> > > mess up with any existing uses of it.
> > >
> > > The other major change here is in closing all opened
> > > files and destroying all clientids. With all the tests
> > > which run against my server, there are no longer any
> > > open files. There are however 11 clientids remaining.
> > >
> > > I will track those down.
> > >
> > > fwiw - these are in my staging branch at git://linux-nfs.org/~loghyr/pynfs.git
> >
> > Thanks! I'll try these and take a look.
>
> It breaks all the 4.0 tests:
>
> ACC3 st_access.testNoFh : FAILURE
> AttributeError: 'Environment' object has no attribute
> 'clean_clients'
>
> The problem is that nfs4.1/testmod.py is used by 4.0 as well, but
> there's not a 4.0 version of clean_clients.... Simplest I guess is to do
> as with clean_sessions and define a dummy method.
>
> --b.
>
> diff --git a/nfs4.0/servertests/environment.py b/nfs4.0/servertests/environment.py
> index 6fe083a..221c3ed 100644
> --- a/nfs4.0/servertests/environment.py
> +++ b/nfs4.0/servertests/environment.py
> @@ -229,6 +229,9 @@ class Environment(testmod.Environment):
> def clean_sessions(self):
> return
>
> + def clean_clients(self):
> + return
> +
> #########################################
> debug_fail = False
Yeah, I never run 4.0 tests. Do you want me to add it to the patchset and
resubmit?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-11-28 23:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 6:26 [PATCH pynfs 00/12] Flex File support Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 01/12] According to RFC7863, this is not an array Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 02/12] Close the files opened in the OPEN tests Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 03/12] Some more file closes to cleanup state on the server Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 04/12] Get rid of the client records as well as the session records Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 05/12] Really, really close those open temp files to remove state on the server Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 06/12] Add xdr for Flex Files Layout Type Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 07/12] Simple tests of the flex file layout type Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 08/12] Add a check to see if NFS4ERR_OLD_STATEID is issued on concurrent layoutgets Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 09/12] Check that the flex file access uid/gid are correct for the different iomodes Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 10/12] FFLS1: Simulate LAYOUTSTATS for 20 small file creations Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 11/12] Factor out checking seqid for flex file layouts Tom Haynes
2016-11-27 6:26 ` [PATCH pynfs 12/12] Add layoutstats tests for flex files Tom Haynes
2016-11-28 17:22 ` J. Bruce Fields
2016-11-28 17:52 ` Tom Haynes
2016-11-28 16:33 ` [PATCH pynfs 00/12] Flex File support J. Bruce Fields
2016-11-28 16:53 ` Tom Haynes
2016-11-28 21:47 ` J. Bruce Fields
2016-11-28 23:38 ` Tom Haynes [this message]
2016-11-29 1:55 ` J. Bruce Fields
2016-11-29 23:44 ` Frank Filz
2016-11-30 14:24 ` J. Bruce Fields
2016-11-30 16:56 ` Frank Filz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128233831.GD30012@psyklo.internal.excfb.com \
--to=loghyr@excfb.com \
--cc=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=loghyr@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.