Re: [PATCH] drm/fsl: don't use drm_put_dev

From: Lucas Stach <l.stach@pengutronix.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/fsl: don't use drm_put_dev
Date: Tue, 13 Dec 2016 18:57:59 +0100	[thread overview]
Message-ID: <1481651879.2313.17.camel@pengutronix.de> (raw)
In-Reply-To: <20161213175449.24525-1-daniel.vetter@ffwll.ch>

Am Dienstag, den 13.12.2016, 18:54 +0100 schrieb Daniel Vetter:
> fsl is already fully demidlayered in the probe function, but for
> convenience stuck with drm_put_dev. Call the unregister/unref parts
> separately, to make sure this driver works correct.
> 
> v2: Rebase.
> 
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Stefan Agner <stefan@agner.ch>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> ---
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> index 537ca159ffe5..0b35da73c2b0 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> @@ -434,7 +434,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev)
>  {
>  	struct fsl_dcu_drm_device *fsl_dev = platform_get_drvdata(pdev);
>  
> -	drm_put_dev(fsl_dev->drm);
> +	drm_dev_unregister(fsl_dev->drm);
> +	drm_dev_unref(fsl_dev->drm);
>  	clk_disable_unprepare(fsl_dev->clk);
>  	clk_unregister(fsl_dev->pix_clk);
>  


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel