From: Daniel Vetter <daniel@ffwll.ch>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 2/4] drm/fsl: don't use drm_put_dev
Date: Tue, 13 Dec 2016 18:12:27 +0100 [thread overview]
Message-ID: <20161213171227.5vxf5tvd2lkrwoo5@phenom.ffwll.local> (raw)
In-Reply-To: <1481626433.2313.14.camel@pengutronix.de>
On Tue, Dec 13, 2016 at 11:53:53AM +0100, Lucas Stach wrote:
> Am Donnerstag, den 08.12.2016, 12:07 +0100 schrieb Daniel Vetter:
> > fsl is already fully demidlayered in the probe function, but for
> > convenience stuck with drm_put_dev. Call the unregister/unref parts
> > separately, to make sure this driver works correct.
> >
> > Cc: Stefan Agner <stefan@agner.ch>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> > index 320e4728c9b9..d36bf4f8b3de 100644
> > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> > @@ -426,7 +426,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev)
> >
> > clk_disable_unprepare(fsl_dev->clk);
> > clk_unregister(fsl_dev->pix_clk);
> > - drm_put_dev(fsl_dev->drm);
> > + drm_dev_unregister(fsl_dev->drm);
> > + drm_dev_unref(fsl_dev->drm);
>
> Why not make it work correctly instead of the mechanical change? I.e.
> move the drm_dev_unregister() up 2 lines.
I have a rebased v2 here which does that, because upstream fsl changed
that. Will resend.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-12-13 17:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 11:07 [PATCH 1/4] drm/etnaviv: Use drm_dev_unref, not drm_put_dev Daniel Vetter
2016-12-08 11:07 ` [PATCH 2/4] drm/fsl: don't use drm_put_dev Daniel Vetter
2016-12-13 10:53 ` Lucas Stach
2016-12-13 17:12 ` Daniel Vetter [this message]
2016-12-13 17:54 ` [PATCH] " Daniel Vetter
2016-12-13 17:57 ` Lucas Stach
2016-12-13 21:26 ` Daniel Vetter
2016-12-13 23:29 ` Stefan Agner
2016-12-08 11:07 ` [PATCH 3/4] drm/mediatek: " Daniel Vetter
2016-12-13 10:55 ` Lucas Stach
2016-12-13 17:14 ` Daniel Vetter
2016-12-08 11:07 ` [PATCH 4/4] drm/vc4: Don't " Daniel Vetter
2016-12-09 23:44 ` Eric Anholt
2016-12-13 10:52 ` [PATCH 1/4] drm/etnaviv: Use drm_dev_unref, not drm_put_dev Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213171227.5vxf5tvd2lkrwoo5@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.