Re: [Qemu-devel] [PATCH v4 qemu 0/6] Fast (de)inflating & fast live migration - no-reply

From: no-reply@patchew.org
To: liang.z.li@intel.com
Cc: famz@redhat.com, qemu-devel@nongnu.org, mtosatti@redhat.com,
	kvm@vger.kernel.org, mst@redhat.com, uintela@redhat.com,
	dgilbert@redhat.com, dave.hansen@intel.com, wei.w.wang@intel.com,
	amit.shah@redhat.com, pbonzini@redhat.com, liang.z.li@intel.com
Subject: Re: [Qemu-devel] [PATCH v4 qemu 0/6] Fast (de)inflating & fast live migration
Date: Wed, 11 Jan 2017 01:08:52 -0800 (PST)	[thread overview]
Message-ID: <148412573107.208.13981250517015114145@790289a7ca88> (raw)
In-Reply-To: <1484124524-481-1-git-send-email-liang.z.li@intel.com>

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 1484124524-481-1-git-send-email-liang.z.li@intel.com
Subject: [Qemu-devel] [PATCH v4 qemu 0/6] Fast (de)inflating & fast live migration
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1484124524-481-1-git-send-email-liang.z.li@intel.com -> patchew/1484124524-481-1-git-send-email-liang.z.li@intel.com
Switched to a new branch 'test'
7e2ce67 migration: skip unused pages during live migration
687ca7e kvm.c: Add two new arch specific functions
b2682d9 bitmap: Add a new bitmap_move function
3983f00 balloon: get unused page info from guest
df86151 virtio-balloon: speed up inflating & deflating process
1a58699 virtio-balloon: update linux head file

=== OUTPUT BEGIN ===
Checking PATCH 1/6: virtio-balloon: update linux head file...
Checking PATCH 2/6: virtio-balloon: speed up inflating & deflating process...
Checking PATCH 3/6: balloon: get unused page info from guest...
ERROR: suspect code indent for conditional statements (12, 17)
#147: FILE: hw/virtio/virtio-balloon.c:430:
+            if (s->bmap_len < hdr.data_len) {
+                 hdr.data_len = s->bmap_len;

total: 1 errors, 0 warnings, 344 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/6: bitmap: Add a new bitmap_move function...
Checking PATCH 5/6: kvm.c: Add two new arch specific functions...
Checking PATCH 6/6: migration: skip unused pages during live migration...
=== OUTPUT END ===

Test command exited with code: 1

---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org