Re: [PATCH v2 00/14] qla2xxx: Bug Fixes and updates for target.

From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hch@infradead.org" <hch@infradead.org>,
	"himanshu.madhani@cavium.com" <himanshu.madhani@cavium.com>,
	"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
	"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"giridhar.malavali@cavium.com" <giridhar.malavali@cavium.com>
Subject: Re: [PATCH v2 00/14] qla2xxx: Bug Fixes and updates for target.
Date: Wed, 8 Feb 2017 15:02:53 +0000	[thread overview]
Message-ID: <1486566153.2957.1.camel@sandisk.com> (raw)
In-Reply-To: <1486161655-2307-1-git-send-email-himanshu.madhani@cavium.com>

On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote:
> Please consider this series for inclusion in target-pending.

Hello Himanshu,

I gave this patch series a try on a system equipped with two QLogic FC HBAs
where an FC cable connects both HBAs to each other. qlini_mode has been set
to "dual" such that both ports support initiator and target mode. Without this
patch series both ports log in to each other and lsscsi shows several LUNs.
With this patch series applied the two ports do not log in to each other
anymore and strange messages appear in the kernel log:

------------[ cut here ]------------
WARNING: CPU: 0 PID: 5 at lib/kobject.c:244 kobject_add_internal+0x118/0x350
kobject_add_internal failed for 3:0:0:0 (error: -2 parent: target3:0:0)
Modules linked in: target_core_pscsi target_core_iblock target_core_file tcm_qla2xxx target_core_mod fcoe libfcoe libfc qla2xxx scsi_transport_fc netconsole af_packet hid_generic usbhid hid sg virtio_balloon i2c_piix4 acpi_cpufreq button ib_iser rdma_cm iw_cm ib_cm ib_core configfs iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi autofs4 ext4 crc16 jbd2 mbcache sr_mod cdrom ata_generic pata_acpi virtio_net virtio_blk virtio_gpu drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm drm i2c_core ata_piix xhci_pci libata xhci_hcd intel_agp usbcore intel_gtt virtio_pci scsi_mod virtio_ring usb_common agpgart virtio
CPU: 0 PID: 5 Comm: kworker/u16:0 Not tainted 4.10.0-rc6-dbg+ #1
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
Workqueue: scsi_wq_3 fc_scsi_scan_rport [scsi_transport_fc]
Call Trace:
 dump_stack+0x85/0xc2
 __warn+0xcb/0xf0
 warn_slowpath_fmt+0x4f/0x60
 kobject_add_internal+0x118/0x350
 kobject_add+0x68/0xb0
 device_add+0xfa/0x600
 scsi_sysfs_add_sdev+0x8e/0x270 [scsi_mod]
 scsi_probe_and_add_lun+0xca1/0xe30 [scsi_mod]
 __scsi_scan_target+0xd3/0x5f0 [scsi_mod]
 scsi_scan_target+0xf1/0x100 [scsi_mod]
 fc_scsi_scan_rport+0xc0/0xd0 [scsi_transport_fc]
 process_one_work+0x1f4/0x6e0
 worker_thread+0x4e/0x4a0
 kthread+0x10c/0x140
 ret_from_fork+0x31/0x40
---[ end trace 86f40b52873f9529 ]---
scsi 3:0:0:0: failed to add device: -2

Bart.