From: "Madhani, Himanshu" <Himanshu.Madhani@cavium.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"Bart.VanAssche@sandisk.com" <Bart.VanAssche@sandisk.com>,
"nab@linux-iscsi.org" <nab@linux-iscsi.org>,
"Malavali, Giridhar" <Giridhar.Malavali@cavium.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2 03/14] qla2xxx: Allow vref count to timeout on vport delete.
Date: Wed, 8 Feb 2017 18:25:07 +0000 [thread overview]
Message-ID: <8A0C1FAD-00F9-4CA2-A319-877F48E125F2@cavium.com> (raw)
In-Reply-To: <20170208130315.GA22512@infradead.org>
On 2/8/17, 5:03 AM, "Christoph Hellwig" <hch@infradead.org> wrote:
>On Fri, Feb 03, 2017 at 02:40:44PM -0800, Himanshu Madhani wrote:
>> - spin_lock_irqsave(&ha->vport_slock, flags);
>> - while (atomic_read(&vha->vref_count)) {
>> - spin_unlock_irqrestore(&ha->vport_slock, flags);
>> -
>> + while (count-- && atomic_read(&vha->vref_count))
>> msleep(500);
>
>Please add a wait queue to skeep on while waiting for vref_count to
>drop to zero.
Thanks for the review. Will update patch and resend series.
next prev parent reply other threads:[~2017-02-08 19:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 22:40 [PATCH v2 00/14] qla2xxx: Bug Fixes and updates for target Himanshu Madhani
2017-02-03 22:40 ` [PATCH v2 01/14] qla2xxx: Fix delayed response to command for loop mode/direct connect Himanshu Madhani
2017-02-08 18:35 ` Bart Van Assche
2017-02-03 22:40 ` [PATCH v2 02/14] qla2xxx: Allow relogin to proceed if remote login did not finish Himanshu Madhani
2017-02-08 18:42 ` Bart Van Assche
2017-02-08 19:16 ` Madhani, Himanshu
2017-02-03 22:40 ` [PATCH v2 03/14] qla2xxx: Allow vref count to timeout on vport delete Himanshu Madhani
2017-02-08 13:03 ` Christoph Hellwig
2017-02-08 18:25 ` Madhani, Himanshu [this message]
2017-02-03 22:40 ` [PATCH v2 04/14] qla2xxx: Use IOCB interface to submit non-critical MBX Himanshu Madhani
2017-02-08 18:48 ` Bart Van Assche
2017-02-08 19:15 ` Madhani, Himanshu
2017-02-03 22:40 ` [PATCH v2 05/14] qla2xxx: Add DebugFS node to display Port Database Himanshu Madhani
2017-02-03 22:40 ` [PATCH v2 06/14] qla2xxx: Improve T10-DIF/PI handling in driver Himanshu Madhani
2017-02-08 4:13 ` Nicholas A. Bellinger
2017-02-08 19:12 ` Madhani, Himanshu
2017-02-08 18:57 ` Bart Van Assche
2017-02-08 19:11 ` Madhani, Himanshu
2017-02-03 22:40 ` [PATCH v2 07/14] qla2xxx: Export DIF stats via debugfs Himanshu Madhani
2017-02-03 22:40 ` [PATCH v2 08/14] qla2xxx: Change scsi host lookup method Himanshu Madhani
2017-02-03 22:40 ` [PATCH v2 09/14] qla2xxx: Fix memory leak for abts processing Himanshu Madhani
2017-02-03 22:40 ` [PATCH v2 10/14] qla2xxx: Fix request queue corruption Himanshu Madhani
2017-02-08 19:22 ` Bart Van Assche
2017-02-09 21:34 ` Tran, Quinn
2017-02-03 22:40 ` [PATCH v2 11/14] qla2xxx: Fix inadequate lock protection for ABTS Himanshu Madhani
2017-02-03 22:40 ` [PATCH v2 12/14] qla2xxx: Add async new target notification Himanshu Madhani
2017-02-03 22:40 ` [PATCH v2 13/14] qla2xxx: Fix sess_lock & hardware_lock lock order problem Himanshu Madhani
2017-02-03 22:40 ` [PATCH v2 14/14] qla2xxx: Update driver version to 9.00.00.00-k Himanshu Madhani
2017-02-08 15:02 ` [PATCH v2 00/14] qla2xxx: Bug Fixes and updates for target Bart Van Assche
2017-02-08 17:11 ` Madhani, Himanshu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8A0C1FAD-00F9-4CA2-A319-877F48E125F2@cavium.com \
--to=himanshu.madhani@cavium.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=Giridhar.Malavali@cavium.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.