All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Tony Lindgren <tony@atomide.com>,
	Dinh Nguyen <dinguyen@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-pm@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 2/3] ARM: OMAP: PM: Drop useless checks for PM_SUSPEND_STANDBY
Date: Fri, 17 Feb 2017 17:10:35 +0100	[thread overview]
Message-ID: <1487347836-14427-3-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1487347836-14427-1-git-send-email-geert+renesas@glider.be>

As OMAP uses the standard suspend_valid_only_mem() for its
platform_suspend_ops.valid() callback, its platform_suspend_ops.enter()
callback will never be called with state equal to PM_SUSPEND_STANDBY.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/mach-omap1/pm.c | 1 -
 arch/arm/mach-omap2/pm.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c
index ee5460b8ec2ee6e9..f1135bf8940ed82d 100644
--- a/arch/arm/mach-omap1/pm.c
+++ b/arch/arm/mach-omap1/pm.c
@@ -581,7 +581,6 @@ static int omap_pm_enter(suspend_state_t state)
 {
 	switch (state)
 	{
-	case PM_SUSPEND_STANDBY:
 	case PM_SUSPEND_MEM:
 		omap1_pm_suspend();
 		break;
diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
index 0598630c17786242..63027e60cc209f1c 100644
--- a/arch/arm/mach-omap2/pm.c
+++ b/arch/arm/mach-omap2/pm.c
@@ -163,7 +163,6 @@ static int omap_pm_enter(suspend_state_t suspend_state)
 		return -ENOENT; /* XXX doublecheck */
 
 	switch (suspend_state) {
-	case PM_SUSPEND_STANDBY:
 	case PM_SUSPEND_MEM:
 		ret = omap_pm_suspend();
 		break;
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: geert+renesas@glider.be (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: OMAP: PM: Drop useless checks for PM_SUSPEND_STANDBY
Date: Fri, 17 Feb 2017 17:10:35 +0100	[thread overview]
Message-ID: <1487347836-14427-3-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1487347836-14427-1-git-send-email-geert+renesas@glider.be>

As OMAP uses the standard suspend_valid_only_mem() for its
platform_suspend_ops.valid() callback, its platform_suspend_ops.enter()
callback will never be called with state equal to PM_SUSPEND_STANDBY.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/mach-omap1/pm.c | 1 -
 arch/arm/mach-omap2/pm.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c
index ee5460b8ec2ee6e9..f1135bf8940ed82d 100644
--- a/arch/arm/mach-omap1/pm.c
+++ b/arch/arm/mach-omap1/pm.c
@@ -581,7 +581,6 @@ static int omap_pm_enter(suspend_state_t state)
 {
 	switch (state)
 	{
-	case PM_SUSPEND_STANDBY:
 	case PM_SUSPEND_MEM:
 		omap1_pm_suspend();
 		break;
diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
index 0598630c17786242..63027e60cc209f1c 100644
--- a/arch/arm/mach-omap2/pm.c
+++ b/arch/arm/mach-omap2/pm.c
@@ -163,7 +163,6 @@ static int omap_pm_enter(suspend_state_t suspend_state)
 		return -ENOENT; /* XXX doublecheck */
 
 	switch (suspend_state) {
-	case PM_SUSPEND_STANDBY:
 	case PM_SUSPEND_MEM:
 		ret = omap_pm_suspend();
 		break;
-- 
1.9.1

  parent reply	other threads:[~2017-02-17 16:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-17 16:10 [PATCH 0/3] ARM: PM: Drop useless checks for PM_SUSPEND_STANDBY Geert Uytterhoeven
2017-02-17 16:10 ` Geert Uytterhoeven
2017-02-17 16:10 ` [PATCH 1/3] ARM: davinci: PM: Drop useless check " Geert Uytterhoeven
2017-02-17 16:10   ` Geert Uytterhoeven
2017-02-20  8:30   ` Sekhar Nori
2017-02-20  8:30     ` Sekhar Nori
2017-02-20  8:40     ` Geert Uytterhoeven
2017-02-20  8:40       ` Geert Uytterhoeven
2017-02-21  8:57       ` Sekhar Nori
2017-02-21  8:57         ` Sekhar Nori
2017-02-17 16:10 ` Geert Uytterhoeven [this message]
2017-02-17 16:10   ` [PATCH 2/3] ARM: OMAP: PM: Drop useless checks " Geert Uytterhoeven
2017-02-17 16:10 ` [PATCH 3/3] ARM: socfpga: PM: Drop useless check " Geert Uytterhoeven
2017-02-17 16:10   ` Geert Uytterhoeven
2017-02-19 20:15   ` Dinh Nguyen
2017-02-19 20:15     ` Dinh Nguyen
2017-02-17 16:40 ` [PATCH 0/3] ARM: PM: Drop useless checks " Tony Lindgren
2017-02-17 16:40   ` Tony Lindgren
2017-03-06 18:38   ` Tony Lindgren
2017-03-06 18:38     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487347836-14427-3-git-send-email-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=aaro.koskinen@iki.fi \
    --cc=dinguyen@kernel.org \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=rjw@sisk.pl \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.