From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> To: linus.walleij@linaro.org, krzk@kernel.org Cc: tomasz.figa@gmail.com, s.nawrocki@samsung.com, linux-gpio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: [PATCH v2] pinctrl: samsung: Calculate GPIO base for pinctrl_add_gpio_range Date: Tue, 28 Feb 2017 17:04:35 +0000 [thread overview] Message-ID: <1488301475-10804-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw) In-Reply-To: <20170228090143.GG2742@localhost.localdomain> As the pinctrl is now added before the GPIOs are registered we need to manually calculate what the GPIO base will be, otherwise the base for each gpio_range will be set to zero. Fortunately the driver already assigns a GPIO base, in samsung_gpiolib_register, and uses the same calculation it does for the pin_base. Meaning the two will always be the same and allowing us to reuse the pinbase and avoid the issue. Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> --- Changes since v1: - Use grange.base in samsung_gpiolib_register to make it more clear the two are related in the driver. Thanks, Charles drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index ddc8d6b..27d5157 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -882,7 +882,7 @@ static int samsung_pinctrl_register(struct platform_device *pdev, pin_bank->grange.id = bank; pin_bank->grange.pin_base = drvdata->pin_base + pin_bank->pin_base; - pin_bank->grange.base = pin_bank->gpio_chip.base; + pin_bank->grange.base = pin_bank->grange.pin_base; pin_bank->grange.npins = pin_bank->gpio_chip.ngpio; pin_bank->grange.gc = &pin_bank->gpio_chip; pinctrl_add_gpio_range(drvdata->pctl_dev, &pin_bank->grange); @@ -928,7 +928,7 @@ static int samsung_gpiolib_register(struct platform_device *pdev, bank->gpio_chip = samsung_gpiolib_chip; gc = &bank->gpio_chip; - gc->base = drvdata->pin_base + bank->pin_base; + gc->base = bank->grange.base; gc->ngpio = bank->nr_pins; gc->parent = &pdev->dev; gc->of_node = bank->of_node; -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> To: <linus.walleij@linaro.org>, <krzk@kernel.org> Cc: <tomasz.figa@gmail.com>, <s.nawrocki@samsung.com>, <linux-gpio@vger.kernel.org>, <linux-samsung-soc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <patches@opensource.wolfsonmicro.com> Subject: [PATCH v2] pinctrl: samsung: Calculate GPIO base for pinctrl_add_gpio_range Date: Tue, 28 Feb 2017 17:04:35 +0000 [thread overview] Message-ID: <1488301475-10804-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw) In-Reply-To: <20170228090143.GG2742@localhost.localdomain> As the pinctrl is now added before the GPIOs are registered we need to manually calculate what the GPIO base will be, otherwise the base for each gpio_range will be set to zero. Fortunately the driver already assigns a GPIO base, in samsung_gpiolib_register, and uses the same calculation it does for the pin_base. Meaning the two will always be the same and allowing us to reuse the pinbase and avoid the issue. Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> --- Changes since v1: - Use grange.base in samsung_gpiolib_register to make it more clear the two are related in the driver. Thanks, Charles drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index ddc8d6b..27d5157 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -882,7 +882,7 @@ static int samsung_pinctrl_register(struct platform_device *pdev, pin_bank->grange.id = bank; pin_bank->grange.pin_base = drvdata->pin_base + pin_bank->pin_base; - pin_bank->grange.base = pin_bank->gpio_chip.base; + pin_bank->grange.base = pin_bank->grange.pin_base; pin_bank->grange.npins = pin_bank->gpio_chip.ngpio; pin_bank->grange.gc = &pin_bank->gpio_chip; pinctrl_add_gpio_range(drvdata->pctl_dev, &pin_bank->grange); @@ -928,7 +928,7 @@ static int samsung_gpiolib_register(struct platform_device *pdev, bank->gpio_chip = samsung_gpiolib_chip; gc = &bank->gpio_chip; - gc->base = drvdata->pin_base + bank->pin_base; + gc->base = bank->grange.base; gc->ngpio = bank->nr_pins; gc->parent = &pdev->dev; gc->of_node = bank->of_node; -- 2.1.4
next prev parent reply other threads:[~2017-02-28 17:04 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-16 13:27 [PATCH v2 1/4] pinctrl: Fix trivial spelling typo in a comment Charles Keepax 2017-02-16 13:27 ` Charles Keepax 2017-02-16 13:27 ` [PATCH v2 2/4] pinctrl: samsung: Register pinctrl before GPIO Charles Keepax 2017-02-16 13:27 ` Charles Keepax 2017-02-22 14:37 ` Linus Walleij 2017-02-22 14:37 ` Linus Walleij 2017-02-23 17:23 ` Charles Keepax 2017-02-23 17:23 ` Charles Keepax 2017-02-23 17:54 ` [PATCH] pinctrl: samsung: Calculate GPIO base for pinctrl_add_gpio_range Charles Keepax 2017-02-23 17:54 ` Charles Keepax 2017-02-27 2:13 ` Tomasz Figa 2017-02-27 2:13 ` Tomasz Figa 2017-02-28 9:01 ` Charles Keepax 2017-02-28 9:01 ` Charles Keepax 2017-02-28 17:04 ` Charles Keepax [this message] 2017-02-28 17:04 ` [PATCH v2] " Charles Keepax 2017-03-04 11:20 ` Tomasz Figa 2017-03-04 11:20 ` Tomasz Figa 2017-03-06 16:49 ` Charles Keepax 2017-03-06 16:49 ` Charles Keepax 2017-03-20 18:39 ` Krzysztof Kozlowski 2017-03-20 18:39 ` Krzysztof Kozlowski 2017-03-21 9:32 ` Charles Keepax 2017-03-21 9:32 ` Charles Keepax 2017-03-14 13:44 ` [PATCH v2 2/4] pinctrl: samsung: Register pinctrl before GPIO Linus Walleij 2017-03-14 13:44 ` Linus Walleij 2017-03-14 13:58 ` Krzysztof Kozlowski 2017-03-14 13:58 ` Krzysztof Kozlowski 2017-03-16 15:28 ` Linus Walleij 2017-03-16 15:28 ` Linus Walleij 2017-02-16 13:27 ` [PATCH v2 3/4] pinctrl: samsung: Remove unused local variable Charles Keepax 2017-02-16 13:27 ` Charles Keepax 2017-02-22 14:38 ` Linus Walleij 2017-02-22 14:38 ` Linus Walleij 2017-02-16 13:27 ` [PATCH v2 4/4] pinctrl: samsung: Use devres version of gpiochip_add_data Charles Keepax 2017-02-16 13:27 ` Charles Keepax 2017-02-17 13:35 ` Krzysztof Kozlowski 2017-02-17 13:52 ` Charles Keepax 2017-02-17 13:52 ` Charles Keepax 2017-03-20 18:44 ` Krzysztof Kozlowski 2017-03-23 9:47 ` Linus Walleij 2017-03-23 9:47 ` Linus Walleij 2017-03-23 11:34 ` Krzysztof Kozlowski 2017-03-23 11:34 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1488301475-10804-1-git-send-email-ckeepax@opensource.wolfsonmicro.com \ --to=ckeepax@opensource.wolfsonmicro.com \ --cc=krzk@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=patches@opensource.wolfsonmicro.com \ --cc=s.nawrocki@samsung.com \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.