From: Sinan Kaya <okaya@codeaurora.org> To: linux-pci@vger.kernel.org, timur@codeaurora.org Cc: mayurkumar.patel@intel.com, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sinan Kaya <okaya@codeaurora.org> Subject: [PATCH V7 0/5] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT Date: Thu, 30 Mar 2017 09:30:31 -0400 [thread overview] Message-ID: <1490880636-30542-1-git-send-email-okaya@codeaurora.org> (raw) When the operating system is booted with the default ASPM policy (POLICY_DEFAULT), current code is querying the enable/disable states from ASPM registers to determine the policy. For example, a BIOS could set the power saving state to performance and clear all ASPM control registers. A balanced ASPM policy could enable L0s and disable L1. A power conscious BIOS could enable both L0s and L1 to trade off latency and performance vs. power. After hotplug removal, pcie_aspm_exit_link_state() function clears the ASPM registers. An insertion following hotplug removal reads incorrect policy as ASPM disabled even though ASPM was enabled during boot. This is caused by the fact that same function is used for reconfiguring ASPM regardless of the power on state. ------------------------ Changes from v6 (https://www.spinics.net/lists/arm-kernel/msg572876.html) ------------------------ - revert the accidental parent check in bridge remove Sinan Kaya (5): PCI/ASPM: introduce pci_aspm_init() and add to pci_init_capabilities() PCI/ASPM: split pci_aspm_init() into two PCI/ASPM: add init hook to device_add PCI/ASPM: save power on values during bridge init PCI/ASPM: move link_state cleanup to bridge remove drivers/pci/pcie/aspm.c | 137 ++++++++++++++++++++++++++++++++---------------- drivers/pci/probe.c | 3 ++ drivers/pci/remove.c | 3 +- include/linux/pci.h | 2 + 4 files changed, 98 insertions(+), 47 deletions(-) -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V7 0/5] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT Date: Thu, 30 Mar 2017 09:30:31 -0400 [thread overview] Message-ID: <1490880636-30542-1-git-send-email-okaya@codeaurora.org> (raw) When the operating system is booted with the default ASPM policy (POLICY_DEFAULT), current code is querying the enable/disable states from ASPM registers to determine the policy. For example, a BIOS could set the power saving state to performance and clear all ASPM control registers. A balanced ASPM policy could enable L0s and disable L1. A power conscious BIOS could enable both L0s and L1 to trade off latency and performance vs. power. After hotplug removal, pcie_aspm_exit_link_state() function clears the ASPM registers. An insertion following hotplug removal reads incorrect policy as ASPM disabled even though ASPM was enabled during boot. This is caused by the fact that same function is used for reconfiguring ASPM regardless of the power on state. ------------------------ Changes from v6 (https://www.spinics.net/lists/arm-kernel/msg572876.html) ------------------------ - revert the accidental parent check in bridge remove Sinan Kaya (5): PCI/ASPM: introduce pci_aspm_init() and add to pci_init_capabilities() PCI/ASPM: split pci_aspm_init() into two PCI/ASPM: add init hook to device_add PCI/ASPM: save power on values during bridge init PCI/ASPM: move link_state cleanup to bridge remove drivers/pci/pcie/aspm.c | 137 ++++++++++++++++++++++++++++++++---------------- drivers/pci/probe.c | 3 ++ drivers/pci/remove.c | 3 +- include/linux/pci.h | 2 + 4 files changed, 98 insertions(+), 47 deletions(-) -- 1.9.1
next reply other threads:[~2017-03-30 13:30 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-30 13:30 Sinan Kaya [this message] 2017-03-30 13:30 ` [PATCH V7 0/5] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT Sinan Kaya 2017-03-30 13:30 ` [PATCH V7 1/5] PCI/ASPM: introduce pci_aspm_init() and add to pci_init_capabilities() Sinan Kaya 2017-03-30 13:30 ` Sinan Kaya 2017-03-30 13:30 ` Sinan Kaya 2017-03-30 13:30 ` [PATCH V7 2/5] PCI/ASPM: split pci_aspm_init() into two Sinan Kaya 2017-03-30 13:30 ` Sinan Kaya 2017-03-30 13:30 ` [PATCH V7 3/5] PCI/ASPM: add init hook to device_add Sinan Kaya 2017-03-30 13:30 ` Sinan Kaya 2017-03-30 13:30 ` [PATCH V7 4/5] PCI/ASPM: save power on values during bridge init Sinan Kaya 2017-03-30 13:30 ` Sinan Kaya 2017-03-30 13:30 ` [PATCH V7 5/5] PCI/ASPM: move link_state cleanup to bridge remove Sinan Kaya 2017-03-30 13:30 ` Sinan Kaya 2017-04-04 13:13 ` [PATCH V7 0/5] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT Sinan Kaya 2017-04-04 13:13 ` Sinan Kaya 2017-04-04 13:13 ` Sinan Kaya 2017-04-04 15:02 ` Patel, Mayurkumar 2017-04-04 15:02 ` Patel, Mayurkumar 2017-04-04 15:02 ` Patel, Mayurkumar 2017-04-06 13:23 ` Patel, Mayurkumar 2017-04-06 13:23 ` Patel, Mayurkumar 2017-04-06 13:23 ` Patel, Mayurkumar 2017-04-06 15:19 ` Sinan Kaya 2017-04-06 15:19 ` Sinan Kaya 2017-04-06 15:19 ` Sinan Kaya 2017-04-06 17:10 ` Rajat Jain 2017-04-06 17:10 ` Rajat Jain 2017-04-06 17:10 ` Rajat Jain 2017-04-07 0:34 ` Sinan Kaya 2017-04-07 0:34 ` Sinan Kaya 2017-04-07 0:34 ` Sinan Kaya 2017-04-07 16:46 ` Rajat Jain 2017-04-07 16:46 ` Rajat Jain 2017-04-07 9:03 ` Patel, Mayurkumar 2017-04-07 9:03 ` Patel, Mayurkumar 2017-04-07 9:03 ` Patel, Mayurkumar 2017-04-07 13:09 ` Sinan Kaya 2017-04-07 13:09 ` Sinan Kaya 2017-04-07 13:09 ` Sinan Kaya 2017-04-08 5:03 ` Sinan Kaya 2017-04-08 5:03 ` Sinan Kaya 2017-04-08 5:03 ` Sinan Kaya 2017-04-07 17:15 ` Rajat Jain 2017-04-07 17:15 ` Rajat Jain 2017-04-10 11:44 ` Patel, Mayurkumar 2017-04-10 11:44 ` Patel, Mayurkumar 2017-04-10 11:44 ` Patel, Mayurkumar 2017-04-06 15:36 ` Sinan Kaya 2017-04-06 15:36 ` Sinan Kaya 2017-04-06 15:36 ` Sinan Kaya 2017-04-06 15:56 ` Patel, Mayurkumar 2017-04-06 15:56 ` Patel, Mayurkumar 2017-04-06 15:56 ` Patel, Mayurkumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1490880636-30542-1-git-send-email-okaya@codeaurora.org \ --to=okaya@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=mayurkumar.patel@intel.com \ --cc=timur@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.