From: Sean Wang <sean.wang@mediatek.com> To: Linus Walleij <linus.walleij@linaro.org> Cc: Rob Herring <robh+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, John Crispin <john@phrozen.org>, Mark Rutland <mark.rutland@arm.com>, Russell King <linux@armlinux.org.uk>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 02/30] pinctrl: mediatek: reuse pinctrl driver for mt7623 Date: Mon, 1 May 2017 14:44:07 +0800 [thread overview] Message-ID: <1493621047.32195.4.camel@mtkswgap22> (raw) In-Reply-To: <CACRpkdbR-k3wgD+7KoV6d7yg1uduXpa9MO0+woEibQYPeYzgYw@mail.gmail.com> On Fri, 2017-04-28 at 10:01 +0200, Linus Walleij wrote: > On Wed, Apr 26, 2017 at 11:25 AM, <sean.wang@mediatek.com> wrote: > > > From: Sean Wang <sean.wang@mediatek.com> > > > > mt7623 pinctrl driver can be compatible with mt2701 one, > > so the patch reuses the driver and deletes those redundant > > ones. > > > > Cc: John Crispin <john@phrozen.org> > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > > Partly correct. > > > "mediatek,mt6397-pinctrl", compatible with mt6397 pinctrl. > > - "mediatek,mt7623-pinctrl", compatible with mt7623 pinctrl. > > NO don't do this. > > "compatible" means exactly this: this hardware is compatible with > this driver. That is why we have it! > > So instead of mt7623 pretending to be mt2701, let the mt2701 driver > list that it is compatible with mt7623, simple. > > So patch pinctrl-mt2701.c mt2701_pctrl_match[] instead. > Hi Linus, really appreciate your clear guidance and reviewing on this I will fix it up in the next version Sean > Yours, > Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: sean.wang@mediatek.com (Sean Wang) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 02/30] pinctrl: mediatek: reuse pinctrl driver for mt7623 Date: Mon, 1 May 2017 14:44:07 +0800 [thread overview] Message-ID: <1493621047.32195.4.camel@mtkswgap22> (raw) In-Reply-To: <CACRpkdbR-k3wgD+7KoV6d7yg1uduXpa9MO0+woEibQYPeYzgYw@mail.gmail.com> On Fri, 2017-04-28 at 10:01 +0200, Linus Walleij wrote: > On Wed, Apr 26, 2017 at 11:25 AM, <sean.wang@mediatek.com> wrote: > > > From: Sean Wang <sean.wang@mediatek.com> > > > > mt7623 pinctrl driver can be compatible with mt2701 one, > > so the patch reuses the driver and deletes those redundant > > ones. > > > > Cc: John Crispin <john@phrozen.org> > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > > Partly correct. > > > "mediatek,mt6397-pinctrl", compatible with mt6397 pinctrl. > > - "mediatek,mt7623-pinctrl", compatible with mt7623 pinctrl. > > NO don't do this. > > "compatible" means exactly this: this hardware is compatible with > this driver. That is why we have it! > > So instead of mt7623 pretending to be mt2701, let the mt2701 driver > list that it is compatible with mt7623, simple. > > So patch pinctrl-mt2701.c mt2701_pctrl_match[] instead. > Hi Linus, really appreciate your clear guidance and reviewing on this I will fix it up in the next version Sean > Yours, > Linus Walleij
next prev parent reply other threads:[~2017-05-01 6:44 UTC|newest] Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-26 9:25 [PATCH v2 00/30] arm: dts: extend mt7623 support sean.wang 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:25 ` [PATCH v2 01/30] pinctrl: mediatek: Add missing pinctrl bindings for mt7623 sean.wang 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-28 7:55 ` Linus Walleij 2017-04-28 7:55 ` Linus Walleij 2017-04-28 7:55 ` Linus Walleij 2017-04-26 9:25 ` [PATCH v2 04/30] arm: dts: mt7623: add subsystem clock controller device nodes sean.wang 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:25 ` [PATCH v2 08/30] arm: dts: mt7623: add pmic wrapper nodes to the mt7623 dtsi file sean.wang 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:25 ` [PATCH v2 09/30] arm: dts: mt7623: add i2c nodes to the mt7623.dtsi file sean.wang 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:25 ` [PATCH v2 11/30] arm: dts: mt7623: add nand " sean.wang 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:25 ` [PATCH v2 12/30] arm: dts: mt7623: add mmc " sean.wang 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:25 ` [PATCH v2 14/30] arm: dts: mt7623: add pwm " sean.wang 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:26 ` [PATCH v2 17/30] arm: dts: mt7623: add ir " sean.wang 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang 2017-04-26 9:26 ` [PATCH v2 19/30] arm: dts: mt7623: add rng " sean.wang 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang 2017-04-26 9:26 ` [PATCH v2 20/30] arm: dts: mt7623: add auxadc " sean.wang 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang 2017-04-26 9:26 ` [PATCH v2 21/30] arm: dts: mt7623: add efuse " sean.wang 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang 2017-04-26 9:26 ` [PATCH v2 22/30] arm: dts: mt7623: add thermal " sean.wang 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang [not found] ` <1493198774-4478-1-git-send-email-sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2017-04-26 9:25 ` [PATCH v2 02/30] pinctrl: mediatek: reuse pinctrl driver for mt7623 sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang [not found] ` <1493198774-4478-3-git-send-email-sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2017-04-28 8:01 ` Linus Walleij 2017-04-28 8:01 ` Linus Walleij 2017-04-28 8:01 ` Linus Walleij 2017-05-01 6:44 ` Sean Wang [this message] 2017-05-01 6:44 ` Sean Wang 2017-05-01 6:44 ` Sean Wang 2017-04-26 9:25 ` [PATCH v2 03/30] arm: dts: mt7623: add clock controller device nodes sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:25 ` [PATCH v2 05/30] arm: dts: mt7623: add power domain controller device node sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:25 ` [PATCH v2 06/30] arm: dts: mt7623: add clock-frequency to the a7 timer node to mt7623.dtsi sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:25 ` [PATCH v2 07/30] arm: dts: mt7623: add pinctrl nodes to the mt7623 dtsi file sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang [not found] ` <1493198774-4478-8-git-send-email-sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2017-04-28 8:03 ` Linus Walleij 2017-04-28 8:03 ` Linus Walleij 2017-04-28 8:03 ` Linus Walleij 2017-04-26 9:25 ` [PATCH v2 10/30] arm: dts: mt7623: add spi nodes to the mt7623.dtsi file sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:25 ` [PATCH v2 13/30] arm: dts: mt7623: add usb " sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:25 ` [PATCH v2 15/30] arm: dts: mt7623: add ethernet " sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:25 ` sean.wang at mediatek.com 2017-04-26 9:25 ` sean.wang 2017-04-26 9:26 ` [PATCH v2 16/30] arm: dts: mt7623: add crypto engine " sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang 2017-04-26 9:26 ` [PATCH v2 18/30] arm: dts: mt7623: add afe " sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang 2017-04-26 9:26 ` [PATCH v2 23/30] arm: dts: mt7623: add Sean as one of authors for mt7623.dtsi files sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang 2017-04-26 9:26 ` [PATCH v2 24/30] arm: dts: mt7623: add mt7623-mt6323.dtsi file sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang 2017-04-26 9:26 ` [PATCH v2 25/30] arm: dts: mt7623: rename mt7623-evb.dts to arch/arm/boot/dts/mt7623n-rfb.dtsi sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang [not found] ` <1493198774-4478-26-git-send-email-sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2017-04-28 20:30 ` Rob Herring 2017-04-28 20:30 ` Rob Herring 2017-04-28 20:30 ` Rob Herring 2017-05-01 7:06 ` Sean Wang 2017-05-01 7:06 ` Sean Wang 2017-05-01 7:06 ` Sean Wang 2017-04-26 9:26 ` [PATCH v2 26/30] arm: dts: mt7623: cleanup the mt7623n rfb uart nodes sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang 2017-05-10 9:58 ` [PATCH v2 00/30] arm: dts: extend mt7623 support Matthias Brugger 2017-05-10 9:58 ` Matthias Brugger 2017-05-10 9:58 ` Matthias Brugger 2017-04-26 9:26 ` [PATCH v2 27/30] arm: dts: mt7623: enable the usb device on the mt7623n rfb sean.wang 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang 2017-04-26 9:26 ` [PATCH v2 28/30] arm: dts: mt7623: enable the nand device on the mt7623n nand rfb sean.wang 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang 2017-04-26 9:26 ` [PATCH v2 29/30] dt-bindings: add vendor prefix for bananapi sean.wang 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang [not found] ` <1493198774-4478-30-git-send-email-sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2017-04-28 20:37 ` Rob Herring 2017-04-28 20:37 ` Rob Herring 2017-04-28 20:37 ` Rob Herring 2017-05-01 6:58 ` Sean Wang 2017-05-01 6:58 ` Sean Wang 2017-05-01 6:58 ` Sean Wang 2017-05-02 13:52 ` Rob Herring 2017-05-02 13:52 ` Rob Herring 2017-05-02 13:52 ` Rob Herring [not found] ` <CAL_JsqKHpWGviZ2H-xhGMzNWsCCRMj_O5ux8aguFfeVKBfJa_w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-05-08 9:53 ` Sean Wang 2017-05-08 9:53 ` Sean Wang 2017-05-08 9:53 ` Sean Wang 2017-05-08 11:36 ` Arnd Bergmann 2017-05-08 11:36 ` Arnd Bergmann 2017-05-08 11:36 ` Arnd Bergmann [not found] ` <CAK8P3a3FpbGErEo93xaDLZMi0+XQvKk44dniZqrecQf=WJD1-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-05-09 7:49 ` Matthias Brugger 2017-05-09 7:49 ` Matthias Brugger 2017-05-09 7:49 ` Matthias Brugger 2017-05-09 8:03 ` Chen-Yu Tsai 2017-05-09 8:03 ` Chen-Yu Tsai 2017-05-09 8:03 ` Chen-Yu Tsai 2017-05-09 9:40 ` Sean Wang 2017-05-09 9:40 ` Sean Wang 2017-05-09 9:40 ` Sean Wang 2017-04-26 9:26 ` [PATCH v2 30/30] arm: dts: mt7623: add dts file for Bananapi R2 (BPI-R2) board sean.wang 2017-04-26 9:26 ` sean.wang at mediatek.com 2017-04-26 9:26 ` sean.wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1493621047.32195.4.camel@mtkswgap22 \ --to=sean.wang@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=john@phrozen.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.