All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "osandov@osandov.com" <osandov@osandov.com>
Cc: "hare@suse.com" <hare@suse.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"osandov@fb.com" <osandov@fb.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH 5/6] blk-mq-debugfs: Show busy requests
Date: Tue, 2 May 2017 16:13:15 +0000	[thread overview]
Message-ID: <1493741594.2552.4.camel@sandisk.com> (raw)
In-Reply-To: <20170502001741.GA2894@vader>

On Mon, 2017-05-01 at 17:17 -0700, Omar Sandoval wrote:
> On Thu, Apr 27, 2017 at 08:54:36AM -0700, Bart Van Assche wrote:
> > +	if (q->queue_hw_ctx[rq->mq_ctx->index_hw] =3D=3D ctx->hctx &&
>=20
> This doesn't look right. ctx->index_hw is the index into hctx->ctxs for
> this ctx. I think you mean blk_mq_map_queue(q, rq->mq_ctx->cpu).

Hello Omar,

Thanks for the feedback. I will integrate this fix when I repost this patch=
 series
(after the merge window has closed).

Bart.=

  reply	other threads:[~2017-05-02 16:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 15:54 [PATCH 0/6] Six more patches for Linux kernel v4.12 Bart Van Assche
2017-04-27 15:54 ` [PATCH 1/6] blk-mq: Make blk_mq_quiesce_queue() wait for all .queue_rq() calls Bart Van Assche
2017-04-28  2:00   ` Ming Lei
2017-04-28  3:48     ` Ming Lei
2017-04-28 15:35     ` Bart Van Assche
2017-04-28 15:35       ` Bart Van Assche
2017-04-28 16:02       ` Ming Lei
2017-04-27 15:54 ` [PATCH 2/6] blk-mq: Fix the comment above blk_mq_quiesce_queue() Bart Van Assche
2017-04-27 22:37   ` Omar Sandoval
2017-04-27 22:40     ` Bart Van Assche
2017-04-28  3:26   ` Ming Lei
2017-04-27 15:54 ` [PATCH 3/6] blk-mq-debugfs: Show atomic request flags Bart Van Assche
2017-04-27 22:38   ` Omar Sandoval
2017-04-27 15:54 ` [PATCH 4/6] blk-mq-debugfs: Show requeue list Bart Van Assche
2017-04-27 22:40   ` Omar Sandoval
2017-04-27 15:54 ` [PATCH 5/6] blk-mq-debugfs: Show busy requests Bart Van Assche
2017-05-02  0:17   ` Omar Sandoval
2017-05-02 16:13     ` Bart Van Assche [this message]
2017-04-27 15:54 ` [PATCH 6/6] blk-mq-debugfs: Add 'kick' operation Bart Van Assche
2017-05-02  0:19   ` Omar Sandoval
2017-05-02  0:24     ` Jens Axboe
2017-05-02 16:23       ` Bart Van Assche
2017-05-02 16:25         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493741594.2552.4.camel@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.com \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.