From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "osandov@fb.com" <osandov@fb.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH 1/6] blk-mq: Make blk_mq_quiesce_queue() wait for all .queue_rq() calls
Date: Fri, 28 Apr 2017 15:35:59 +0000 [thread overview]
Message-ID: <1493393758.2767.3.camel@sandisk.com> (raw)
In-Reply-To: <20170428020038.GA31518@ming.t460p>
On Fri, 2017-04-28 at 10:00 +0800, Ming Lei wrote:
> On Thu, Apr 27, 2017 at 08:54:32AM -0700, Bart Van Assche wrote:
> > void blk_mq_stop_hw_queue(struct blk_mq_hw_ctx *hctx)
> > {
> > - cancel_work(&hctx->run_work);
> > - cancel_delayed_work(&hctx->delay_work);
> > + cancel_work_sync(&hctx->run_work);
> > + cancel_delayed_work_sync(&hctx->delay_work);
>=20
> Could you explain it a bit why we need the sync version?
Because the purpose of this patch is to make blk_mq_quiesce_queue() wait fo=
r
all .queue_rq() calls.
> So I suggest to unity both .run_work and .dealyed_run_work
> into one work, just as what Jens did in the following link:
>=20
> http://marc.info/?t=3D149183989800010&r=3D1&w=3D2
That should be done after this patch is upstream otherwise this
patch won't apply to the stable trees.
Bart.=
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "osandov@fb.com" <osandov@fb.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH 1/6] blk-mq: Make blk_mq_quiesce_queue() wait for all .queue_rq() calls
Date: Fri, 28 Apr 2017 15:35:59 +0000 [thread overview]
Message-ID: <1493393758.2767.3.camel@sandisk.com> (raw)
In-Reply-To: <20170428020038.GA31518@ming.t460p>
On Fri, 2017-04-28 at 10:00 +0800, Ming Lei wrote:
> On Thu, Apr 27, 2017 at 08:54:32AM -0700, Bart Van Assche wrote:
> > void blk_mq_stop_hw_queue(struct blk_mq_hw_ctx *hctx)
> > {
> > - cancel_work(&hctx->run_work);
> > - cancel_delayed_work(&hctx->delay_work);
> > + cancel_work_sync(&hctx->run_work);
> > + cancel_delayed_work_sync(&hctx->delay_work);
>
> Could you explain it a bit why we need the sync version?
Because the purpose of this patch is to make blk_mq_quiesce_queue() wait for
all .queue_rq() calls.
> So I suggest to unity both .run_work and .dealyed_run_work
> into one work, just as what Jens did in the following link:
>
> http://marc.info/?t=149183989800010&r=1&w=2
That should be done after this patch is upstream otherwise this
patch won't apply to the stable trees.
Bart.
next prev parent reply other threads:[~2017-04-28 15:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 15:54 [PATCH 0/6] Six more patches for Linux kernel v4.12 Bart Van Assche
2017-04-27 15:54 ` [PATCH 1/6] blk-mq: Make blk_mq_quiesce_queue() wait for all .queue_rq() calls Bart Van Assche
2017-04-28 2:00 ` Ming Lei
2017-04-28 3:48 ` Ming Lei
2017-04-28 15:35 ` Bart Van Assche [this message]
2017-04-28 15:35 ` Bart Van Assche
2017-04-28 16:02 ` Ming Lei
2017-04-27 15:54 ` [PATCH 2/6] blk-mq: Fix the comment above blk_mq_quiesce_queue() Bart Van Assche
2017-04-27 22:37 ` Omar Sandoval
2017-04-27 22:40 ` Bart Van Assche
2017-04-28 3:26 ` Ming Lei
2017-04-27 15:54 ` [PATCH 3/6] blk-mq-debugfs: Show atomic request flags Bart Van Assche
2017-04-27 22:38 ` Omar Sandoval
2017-04-27 15:54 ` [PATCH 4/6] blk-mq-debugfs: Show requeue list Bart Van Assche
2017-04-27 22:40 ` Omar Sandoval
2017-04-27 15:54 ` [PATCH 5/6] blk-mq-debugfs: Show busy requests Bart Van Assche
2017-05-02 0:17 ` Omar Sandoval
2017-05-02 16:13 ` Bart Van Assche
2017-04-27 15:54 ` [PATCH 6/6] blk-mq-debugfs: Add 'kick' operation Bart Van Assche
2017-05-02 0:19 ` Omar Sandoval
2017-05-02 0:24 ` Jens Axboe
2017-05-02 16:23 ` Bart Van Assche
2017-05-02 16:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493393758.2767.3.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.