Re: [PATCH] ath10k: Don't allow tx logic when state is not ON.

From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Ben Greear <greearb@candelatech.com>
Cc: Manikanta Pubbisetty <mpubbise@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	kvalo@codeaurora.org, linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH] ath10k: Don't allow tx logic when state is not ON.
Date: Wed, 20 Jun 2018 14:16:20 -0700	[thread overview]
Message-ID: <14a066cc39a22b204c206440faab9b26@codeaurora.org> (raw)
In-Reply-To: <a624d36c-409a-c2d5-d1d9-8cb857eab2fb@candelatech.com>

On 2018-06-20 11:51, Ben Greear wrote:
> On 06/20/2018 11:48 AM, Rajkumar Manoharan wrote:
>> On 2018-06-20 10:42, Ben Greear wrote:
>>> On 06/20/2018 10:37 AM, Manikanta Pubbisetty wrote:
>>>> 
>> [...]
>>>> This case should not be dealt in ath10k, rather we should make sure 
>>>> packets does not reach the driver during hardware restart after the 
>>>> firmware crash.
>>>> Can you please try the RFC patch and see if it fixes the issue? I am 
>>>> working on the patch and probably send it out after doing some 
>>>> testing and cleanup.
>>>> 
>>>> https://patchwork.kernel.org/patch/10411967/
>>> 
>>> I did see your patch, but I was not sure it would make it upstream.
>>> 
>>> I think either way my patch might be useful in case bugs creep back 
>>> in.
>>> 
>> 
>> ar->state check can not be in hot path as it is protected by mutex 
>> lock.
> 
> If the tx logic is ever called while state is changing, that would seem
> to be a bug as well?
> 
Thats true. The assumption is that packets should not be given to driver
after ieee80211_stop_queues is called. Isn't it? Manikanta is trying to 
fix
some cases where packets are still continued to sent even after queue 
stop.
Worth trying that.

-Rajkumar