From: Anup Patel <anup.patel@broadcom.com> To: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Jassi Brar <jassisinghbrar@gmail.com> Cc: Florian Fainelli <f.fainelli@gmail.com>, Scott Branden <sbranden@broadcom.com>, Ray Jui <rjui@broadcom.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Anup Patel <anup.patel@broadcom.com>, stable@vger.kernel.org Subject: [PATCH v2 3/7] mailbox: bcm-flexrm-mailbox: Fix mask used in CMPL_START_ADDR_VALUE() Date: Fri, 21 Jul 2017 12:25:38 +0530 [thread overview] Message-ID: <1500620142-910-4-git-send-email-anup.patel@broadcom.com> (raw) In-Reply-To: <1500620142-910-1-git-send-email-anup.patel@broadcom.com> The mask used in CMPL_START_ADDR_VALUE() should be 27bits instead of 26bits. This incorrect mask was causing completion writes to 40bits physical address fail. This patch fixes mask used in CMPL_START_ADDR_VALUE() macro. Fixes: dbc049eee730 ("mailbox: Add driver for Broadcom FlexRM ring manager") Signed-off-by: Anup Patel <anup.patel@broadcom.com> Reviewed-by: Ray Jui <ray.jui@broadcom.com> Reviewed-by: Scott Branden <scott.branden@broadcom.com> Cc: stable@vger.kernel.org --- drivers/mailbox/bcm-flexrm-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c index a0be2ea..46ad305 100644 --- a/drivers/mailbox/bcm-flexrm-mailbox.c +++ b/drivers/mailbox/bcm-flexrm-mailbox.c @@ -97,7 +97,7 @@ /* Register RING_CMPL_START_ADDR fields */ #define CMPL_START_ADDR_VALUE(pa) \ - ((u32)((((u64)(pa)) >> RING_CMPL_ALIGN_ORDER) & 0x03ffffff)) + ((u32)((((u64)(pa)) >> RING_CMPL_ALIGN_ORDER) & 0x07ffffff)) /* Register RING_CONTROL fields */ #define CONTROL_MASK_DISABLE_CONTROL 12 -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: anup.patel@broadcom.com (Anup Patel) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 3/7] mailbox: bcm-flexrm-mailbox: Fix mask used in CMPL_START_ADDR_VALUE() Date: Fri, 21 Jul 2017 12:25:38 +0530 [thread overview] Message-ID: <1500620142-910-4-git-send-email-anup.patel@broadcom.com> (raw) In-Reply-To: <1500620142-910-1-git-send-email-anup.patel@broadcom.com> The mask used in CMPL_START_ADDR_VALUE() should be 27bits instead of 26bits. This incorrect mask was causing completion writes to 40bits physical address fail. This patch fixes mask used in CMPL_START_ADDR_VALUE() macro. Fixes: dbc049eee730 ("mailbox: Add driver for Broadcom FlexRM ring manager") Signed-off-by: Anup Patel <anup.patel@broadcom.com> Reviewed-by: Ray Jui <ray.jui@broadcom.com> Reviewed-by: Scott Branden <scott.branden@broadcom.com> Cc: stable at vger.kernel.org --- drivers/mailbox/bcm-flexrm-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c index a0be2ea..46ad305 100644 --- a/drivers/mailbox/bcm-flexrm-mailbox.c +++ b/drivers/mailbox/bcm-flexrm-mailbox.c @@ -97,7 +97,7 @@ /* Register RING_CMPL_START_ADDR fields */ #define CMPL_START_ADDR_VALUE(pa) \ - ((u32)((((u64)(pa)) >> RING_CMPL_ALIGN_ORDER) & 0x03ffffff)) + ((u32)((((u64)(pa)) >> RING_CMPL_ALIGN_ORDER) & 0x07ffffff)) /* Register RING_CONTROL fields */ #define CONTROL_MASK_DISABLE_CONTROL 12 -- 2.7.4
next prev parent reply other threads:[~2017-07-21 6:56 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-21 6:55 [PATCH v2 0/7] FlexRM driver improvements Anup Patel 2017-07-21 6:55 ` Anup Patel 2017-07-21 6:55 ` [PATCH v2 1/7] mailbox: bcm-flexrm-mailbox: Set IRQ affinity hint for FlexRM ring IRQs Anup Patel 2017-07-21 6:55 ` Anup Patel 2017-07-21 6:55 ` [PATCH v2 2/7] mailbox: bcm-flexrm-mailbox: Add debugfs support Anup Patel 2017-07-21 6:55 ` Anup Patel 2017-07-21 6:55 ` Anup Patel [this message] 2017-07-21 6:55 ` [PATCH v2 3/7] mailbox: bcm-flexrm-mailbox: Fix mask used in CMPL_START_ADDR_VALUE() Anup Patel 2017-07-21 6:55 ` [PATCH v2 4/7] mailbox: bcm-flexrm-mailbox: Use bitmap instead of IDA Anup Patel 2017-07-21 6:55 ` Anup Patel 2017-07-21 6:55 ` [PATCH v2 5/7] mailbox: Make message send queue size dynamic in Linux mailbox Anup Patel 2017-07-21 6:55 ` Anup Patel 2017-07-21 6:55 ` Anup Patel 2017-07-21 6:55 ` [PATCH v2 6/7] mailbox: bcm-flexrm-mailbox: Set msg_queue_len for each channel Anup Patel 2017-07-21 6:55 ` Anup Patel 2017-07-21 6:55 ` Anup Patel 2017-07-21 15:46 ` Jassi Brar 2017-07-21 15:46 ` Jassi Brar 2017-07-21 15:46 ` Jassi Brar 2017-07-24 3:56 ` Anup Patel 2017-07-24 3:56 ` Anup Patel 2017-07-24 3:56 ` Anup Patel 2017-07-24 16:36 ` Jassi Brar 2017-07-24 16:36 ` Jassi Brar 2017-07-24 16:36 ` Jassi Brar 2017-07-25 5:41 ` Anup Patel 2017-07-25 5:41 ` Anup Patel 2017-07-25 5:41 ` Anup Patel 2017-07-25 16:07 ` Jassi Brar 2017-07-25 16:07 ` Jassi Brar 2017-07-25 16:07 ` Jassi Brar 2017-07-27 3:55 ` Anup Patel 2017-07-27 3:55 ` Anup Patel 2017-07-27 3:55 ` Anup Patel 2017-07-27 4:59 ` Jassi Brar 2017-07-27 4:59 ` Jassi Brar 2017-07-27 4:59 ` Jassi Brar 2017-07-27 5:50 ` Anup Patel 2017-07-27 5:50 ` Anup Patel 2017-07-27 5:50 ` Anup Patel 2017-07-27 11:53 ` Jassi Brar 2017-07-27 11:53 ` Jassi Brar 2017-07-27 11:53 ` Jassi Brar 2017-07-28 8:49 ` Anup Patel 2017-07-28 8:49 ` Anup Patel 2017-07-28 8:49 ` Anup Patel 2017-07-28 9:04 ` Jassi Brar 2017-07-28 9:04 ` Jassi Brar 2017-07-28 9:04 ` Jassi Brar 2017-07-28 9:48 ` Anup Patel 2017-07-28 9:48 ` Anup Patel 2017-07-28 9:48 ` Anup Patel 2017-07-28 10:20 ` Jassi Brar 2017-07-28 10:20 ` Jassi Brar 2017-07-28 10:20 ` Jassi Brar 2017-07-21 6:55 ` [PATCH v2 7/7] arm64: dts: Add FlexRM DT nodes for Stingray Anup Patel 2017-07-21 6:55 ` Anup Patel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1500620142-910-4-git-send-email-anup.patel@broadcom.com \ --to=anup.patel@broadcom.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=jassisinghbrar@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=rjui@broadcom.com \ --cc=robh+dt@kernel.org \ --cc=sbranden@broadcom.com \ --cc=stable@vger.kernel.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.