From: Dan Williams <dan.j.williams@intel.com> To: linux-fsdevel@vger.kernel.org Cc: jack@suse.cz, linux-nvdimm@lists.01.org, "Darrick J. Wong" <darrick.wong@oracle.com>, linux-kernel@vger.kernel.org, Andreas Dilger <adilger.kernel@dilger.ca>, Jan Kara <jack@suse.com>, Theodore Ts'o <tytso@mit.edu>, hch@lst.de Subject: [PATCH 0/2] fs: cache dax_device lookup result Date: Thu, 24 Aug 2017 17:35:43 -0700 [thread overview] Message-ID: <150362134292.39142.1715377949592729029.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) Christoph notes: I just noticed that we now do a fs_dax_get_by_host in every iomap_begin call for DAX. This function iterates a list, does a string compared and igrab. I really think we need to cache this in the superblock (possible even the fs superblock) similar to what we do for the block device. Fix this up to cache the result of the dax_device lookup in 'struct xfs_mount' for xfs and 'struct super_block' for ext2/ext4. --- Dan Williams (2): xfs: cache dax_device lookup result ext2, ext4: cache dax_device lookup result fs/ext2/inode.c | 11 +++++++---- fs/ext4/inode.c | 11 +++++++---- fs/xfs/xfs_aops.c | 24 ++++++++++++++++++++++++ fs/xfs/xfs_aops.h | 1 + fs/xfs/xfs_buf.h | 1 + fs/xfs/xfs_iomap.c | 9 +-------- include/linux/fs.h | 3 +++ 7 files changed, 44 insertions(+), 16 deletions(-) _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: linux-fsdevel@vger.kernel.org Cc: jack@suse.cz, "Darrick J. Wong" <darrick.wong@oracle.com>, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, Andreas Dilger <adilger.kernel@dilger.ca>, Jan Kara <jack@suse.com>, "Theodore Ts'o" <tytso@mit.edu>, hch@lst.de Subject: [PATCH 0/2] fs: cache dax_device lookup result Date: Thu, 24 Aug 2017 17:35:43 -0700 [thread overview] Message-ID: <150362134292.39142.1715377949592729029.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) Christoph notes: I just noticed that we now do a fs_dax_get_by_host in every iomap_begin call for DAX. This function iterates a list, does a string compared and igrab. I really think we need to cache this in the superblock (possible even the fs superblock) similar to what we do for the block device. Fix this up to cache the result of the dax_device lookup in 'struct xfs_mount' for xfs and 'struct super_block' for ext2/ext4. --- Dan Williams (2): xfs: cache dax_device lookup result ext2, ext4: cache dax_device lookup result fs/ext2/inode.c | 11 +++++++---- fs/ext4/inode.c | 11 +++++++---- fs/xfs/xfs_aops.c | 24 ++++++++++++++++++++++++ fs/xfs/xfs_aops.h | 1 + fs/xfs/xfs_buf.h | 1 + fs/xfs/xfs_iomap.c | 9 +-------- include/linux/fs.h | 3 +++ 7 files changed, 44 insertions(+), 16 deletions(-)
next reply other threads:[~2017-08-25 0:39 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-25 0:35 Dan Williams [this message] 2017-08-25 0:35 ` [PATCH 0/2] fs: cache dax_device lookup result Dan Williams 2017-08-25 0:35 ` [PATCH 1/2] xfs: " Dan Williams 2017-08-25 0:35 ` Dan Williams 2017-08-25 5:32 ` Darrick J. Wong 2017-08-25 5:32 ` Darrick J. Wong 2017-08-25 6:24 ` Dan Williams 2017-08-25 6:24 ` Dan Williams 2017-08-25 7:02 ` Christoph Hellwig 2017-08-25 7:02 ` Christoph Hellwig 2017-08-25 7:01 ` Christoph Hellwig 2017-08-25 7:01 ` Christoph Hellwig 2017-08-25 0:35 ` [PATCH 2/2] ext2, ext4: " Dan Williams 2017-08-25 0:35 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=150362134292.39142.1715377949592729029.stgit@dwillia2-desk3.amr.corp.intel.com \ --to=dan.j.williams@intel.com \ --cc=adilger.kernel@dilger.ca \ --cc=darrick.wong@oracle.com \ --cc=hch@lst.de \ --cc=jack@suse.com \ --cc=jack@suse.cz \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=tytso@mit.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.