All of lore.kernel.org
 help / color / mirror / Atom feed
From: yesanishhere@gmail.com
To: ckeepax@opensource.cirrus.com, broonie@kernel.org,
	lgirdwood@gmail.com, perex@perex.cz, alsa-devel@alsa-project.org,
	tiwai@suse.com
Cc: anish kumar <yesanishhere@gmail.com>
Subject: [Resend] [PATCH 0/4] ASoC: dapm: Avoid creating kcontrol for params
Date: Wed, 20 Sep 2017 01:28:32 -0700	[thread overview]
Message-ID: <1505896116-43310-1-git-send-email-yesanishhere@gmail.com> (raw)

From: anish kumar <yesanishhere@gmail.com>

Currently in codec to codec dai link if there are multiple
params defined then dapm can use created kcontrol to
decide which param to apply at runtime.

However, in case there is only single param configuration
then there is no point in creating the kcontrol and also there
is no point in allocating memory for kcontrol.

In the snd_soc_dapm_new_pcm function, there is memory
allocation happening for kcontrol which is later used
or not used based on num_param. It is better to not
allocate memory when there is only a single configuration.
This change is to remedy that anomaly.

This code change doesn't do much except just refactor
snd_soc_dapm_new_pcm function. Now the part of allocating
memory for kcontrol is allocated to a new function and it
is called only in the case it is needed.

anish kumar (4):
  ASoC: dapm: fix error path in snd_soc_dapm_new_pcm
  ASoC: dapm: Refactor the code in snd_soc_dapm_new_pcm
  ASoC: dapm: Avoid creating kcontrol for params
  ASoC: dapm: Remove the redundant check

 sound/soc/soc-dapm.c | 122 ++++++++++++++++++++++++++++-----------------------
 1 file changed, 66 insertions(+), 56 deletions(-)

-- 
2.5.4 (Apple Git-61)

             reply	other threads:[~2017-09-20  8:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20  8:28 yesanishhere [this message]
2017-09-20  8:28 ` [Resend] [PATCH 1/4] ASoC: dapm: fix error path in snd_soc_dapm_new_pcm yesanishhere
2017-09-20 11:02   ` Charles Keepax
2017-09-20 11:42   ` Applied "ASoC: dapm: fix error path in snd_soc_dapm_new_pcm" to the asoc tree Mark Brown
2017-09-20  8:28 ` [Resend] [PATCH 2/4] ASoC: dapm: Refactor the code in snd_soc_dapm_new_pcm yesanishhere
2017-09-20 11:02   ` Charles Keepax
2017-09-20  8:28 ` [Resend] [PATCH 3/4] ASoC: dapm: Avoid creating kcontrol for params yesanishhere
2017-09-20 11:05   ` Charles Keepax
2017-09-20  8:28 ` [Resend] [PATCH 4/4] ASoC: dapm: Remove the redundant check yesanishhere

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505896116-43310-1-git-send-email-yesanishhere@gmail.com \
    --to=yesanishhere@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.