All of lore.kernel.org
 help / color / mirror / Atom feed
From: yesanishhere@gmail.com
To: ckeepax@opensource.cirrus.com, broonie@kernel.org,
	lgirdwood@gmail.com, perex@perex.cz, alsa-devel@alsa-project.org,
	tiwai@suse.com
Cc: anish kumar <yesanishhere@gmail.com>
Subject: [Resend] [PATCH 4/4] ASoC: dapm: Remove the redundant check
Date: Wed, 20 Sep 2017 01:28:36 -0700	[thread overview]
Message-ID: <1505896116-43310-5-git-send-email-yesanishhere@gmail.com> (raw)
In-Reply-To: <1505896116-43310-1-git-send-email-yesanishhere@gmail.com>

From: anish kumar <yesanishhere@gmail.com>

Remove this redundant check, the check for
creating the control in the case of codec to codec
dai link is moved to snd_soc_dapm_new_pcm function.

Signed-off-by: anish kumar <yesanishhere@gmail.com>
---
 sound/soc/soc-dapm.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 3c493b3..fcad345 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -1032,10 +1032,6 @@ static int dapm_new_dai_link(struct snd_soc_dapm_widget *w)
 	struct snd_soc_dapm_context *dapm = w->dapm;
 	struct snd_card *card = dapm->card->snd_card;
 
-	/* create control for links with > 1 config */
-	if (w->num_params <= 1)
-		return 0;
-
 	/* add kcontrol */
 	for (i = 0; i < w->num_kcontrols; i++) {
 		kcontrol = snd_soc_cnew(&w->kcontrol_news[i], w,
-- 
2.5.4 (Apple Git-61)

      parent reply	other threads:[~2017-09-20  8:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20  8:28 [Resend] [PATCH 0/4] ASoC: dapm: Avoid creating kcontrol for params yesanishhere
2017-09-20  8:28 ` [Resend] [PATCH 1/4] ASoC: dapm: fix error path in snd_soc_dapm_new_pcm yesanishhere
2017-09-20 11:02   ` Charles Keepax
2017-09-20 11:42   ` Applied "ASoC: dapm: fix error path in snd_soc_dapm_new_pcm" to the asoc tree Mark Brown
2017-09-20  8:28 ` [Resend] [PATCH 2/4] ASoC: dapm: Refactor the code in snd_soc_dapm_new_pcm yesanishhere
2017-09-20 11:02   ` Charles Keepax
2017-09-20  8:28 ` [Resend] [PATCH 3/4] ASoC: dapm: Avoid creating kcontrol for params yesanishhere
2017-09-20 11:05   ` Charles Keepax
2017-09-20  8:28 ` yesanishhere [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505896116-43310-5-git-send-email-yesanishhere@gmail.com \
    --to=yesanishhere@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.