From: Ryder Lee <ryder.lee@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
<devicetree@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 3/4] arm: dts: mt7623: add display related nodes
Date: Thu, 21 Sep 2017 17:50:24 +0800 [thread overview]
Message-ID: <1505987424.3084.8.camel@mtkswgap22> (raw)
In-Reply-To: <1505834813.16414.5.camel@mtksdaap41>
On Tue, 2017-09-19 at 23:26 +0800, CK Hu wrote:
> Hi, Ryder:
>
> Some comment inline.
>
> On Tue, 2017-09-19 at 14:27 +0800, Ryder Lee wrote:
> > This patch adds the device nodes for the display function block.
> > Also, we add some missing pin macros in mt7623-pinfunc.h.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > CC: Linus Walleij <linus.walleij@linaro.org>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > arch/arm/boot/dts/mt7623.dtsi | 210 ++++++++++++++++++++++++++
> > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 41 ++++-
> > include/dt-bindings/pinctrl/mt7623-pinfunc.h | 12 ++
> > 3 files changed, 261 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
> > index 9ec3767..e11e5e7 100644
> > --- a/arch/arm/boot/dts/mt7623.dtsi
> > +++ b/arch/arm/boot/dts/mt7623.dtsi
> > @@ -20,6 +20,7 @@
> > #include <dt-bindings/power/mt2701-power.h>
> > #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/phy/phy.h>
> > +#include <dt-bindings/memory/mt2701-larb-port.h>
> > #include <dt-bindings/reset/mt2701-resets.h>
> > #include <dt-bindings/thermal/thermal.h>
> > #include "skeleton64.dtsi"
> > @@ -28,6 +29,11 @@
> > compatible = "mediatek,mt7623";
> > interrupt-parent = <&sysirq>;
> >
> > + aliases {
> > + rdma0 = &rdma0;
> > + rdma1 = &rdma1;
>
> For display, are these two aliases enough?
Yes, this part is the same as mt2701.
https://patchwork.kernel.org/patch/9803813/
> > + };
> > +
...
> > + wdma@14009000 {
> > + compatible = "mediatek,mt7623-disp-wdma",
> > + "mediatek,mt2701-disp-wdma";
>
> There is neither "mediatek,mt7623-disp-wdma" nor
> "mediatek,mt2701-disp-wdma" in driver, do you really need this device
> node?
Okay, I will remove it.
> > + reg = <0 0x14009000 0 0x1000>;
> > + interrupts = <GIC_SPI 154 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&mmsys CLK_MM_DISP_WDMA>;
> > + iommus = <&iommu MT2701_M4U_PORT_DISP_WDMA>;
> > + mediatek,larb = <&larb0>;
> > + };
> > +
> > + bls: bls@1400a000 {
> > + compatible = "mediatek,mt7623-disp-pwm",
> > + "mediatek,mt2701-disp-pwm";
> > + reg = <0 0x1400a000 0 0x1000>;
> > + #pwm-cells = <2>;
> > + clocks = <&mmsys CLK_MM_MDP_BLS_26M>,
> > + <&mmsys CLK_MM_DISP_BLS>;
> > + clock-names = "main", "mm";
> > + status = "disabled";
> > + };
> > +
> > + color@1400b000 {
>
> color: color@1400b000 {
Okay.
> > + compatible = "mediatek,mt7623-disp-color",
> > + "mediatek,mt2701-disp-color";
> > + reg = <0 0x1400b000 0 0x1000>;
> > + interrupts = <GIC_SPI 156 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&mmsys CLK_MM_DISP_COLOR>;
> > + };
> > +
WARNING: multiple messages have this Message-ID (diff)
From: Ryder Lee <ryder.lee@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 3/4] arm: dts: mt7623: add display related nodes
Date: Thu, 21 Sep 2017 17:50:24 +0800 [thread overview]
Message-ID: <1505987424.3084.8.camel@mtkswgap22> (raw)
In-Reply-To: <1505834813.16414.5.camel@mtksdaap41>
On Tue, 2017-09-19 at 23:26 +0800, CK Hu wrote:
> Hi, Ryder:
>
> Some comment inline.
>
> On Tue, 2017-09-19 at 14:27 +0800, Ryder Lee wrote:
> > This patch adds the device nodes for the display function block.
> > Also, we add some missing pin macros in mt7623-pinfunc.h.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > CC: Linus Walleij <linus.walleij@linaro.org>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > arch/arm/boot/dts/mt7623.dtsi | 210 ++++++++++++++++++++++++++
> > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 41 ++++-
> > include/dt-bindings/pinctrl/mt7623-pinfunc.h | 12 ++
> > 3 files changed, 261 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
> > index 9ec3767..e11e5e7 100644
> > --- a/arch/arm/boot/dts/mt7623.dtsi
> > +++ b/arch/arm/boot/dts/mt7623.dtsi
> > @@ -20,6 +20,7 @@
> > #include <dt-bindings/power/mt2701-power.h>
> > #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/phy/phy.h>
> > +#include <dt-bindings/memory/mt2701-larb-port.h>
> > #include <dt-bindings/reset/mt2701-resets.h>
> > #include <dt-bindings/thermal/thermal.h>
> > #include "skeleton64.dtsi"
> > @@ -28,6 +29,11 @@
> > compatible = "mediatek,mt7623";
> > interrupt-parent = <&sysirq>;
> >
> > + aliases {
> > + rdma0 = &rdma0;
> > + rdma1 = &rdma1;
>
> For display, are these two aliases enough?
Yes, this part is the same as mt2701.
https://patchwork.kernel.org/patch/9803813/
> > + };
> > +
...
> > + wdma@14009000 {
> > + compatible = "mediatek,mt7623-disp-wdma",
> > + "mediatek,mt2701-disp-wdma";
>
> There is neither "mediatek,mt7623-disp-wdma" nor
> "mediatek,mt2701-disp-wdma" in driver, do you really need this device
> node?
Okay, I will remove it.
> > + reg = <0 0x14009000 0 0x1000>;
> > + interrupts = <GIC_SPI 154 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&mmsys CLK_MM_DISP_WDMA>;
> > + iommus = <&iommu MT2701_M4U_PORT_DISP_WDMA>;
> > + mediatek,larb = <&larb0>;
> > + };
> > +
> > + bls: bls@1400a000 {
> > + compatible = "mediatek,mt7623-disp-pwm",
> > + "mediatek,mt2701-disp-pwm";
> > + reg = <0 0x1400a000 0 0x1000>;
> > + #pwm-cells = <2>;
> > + clocks = <&mmsys CLK_MM_MDP_BLS_26M>,
> > + <&mmsys CLK_MM_DISP_BLS>;
> > + clock-names = "main", "mm";
> > + status = "disabled";
> > + };
> > +
> > + color@1400b000 {
>
> color: color@1400b000 {
Okay.
> > + compatible = "mediatek,mt7623-disp-color",
> > + "mediatek,mt2701-disp-color";
> > + reg = <0 0x1400b000 0 0x1000>;
> > + interrupts = <GIC_SPI 156 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&mmsys CLK_MM_DISP_COLOR>;
> > + };
> > +
WARNING: multiple messages have this Message-ID (diff)
From: ryder.lee@mediatek.com (Ryder Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 3/4] arm: dts: mt7623: add display related nodes
Date: Thu, 21 Sep 2017 17:50:24 +0800 [thread overview]
Message-ID: <1505987424.3084.8.camel@mtkswgap22> (raw)
In-Reply-To: <1505834813.16414.5.camel@mtksdaap41>
On Tue, 2017-09-19 at 23:26 +0800, CK Hu wrote:
> Hi, Ryder:
>
> Some comment inline.
>
> On Tue, 2017-09-19 at 14:27 +0800, Ryder Lee wrote:
> > This patch adds the device nodes for the display function block.
> > Also, we add some missing pin macros in mt7623-pinfunc.h.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > CC: Linus Walleij <linus.walleij@linaro.org>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > arch/arm/boot/dts/mt7623.dtsi | 210 ++++++++++++++++++++++++++
> > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 41 ++++-
> > include/dt-bindings/pinctrl/mt7623-pinfunc.h | 12 ++
> > 3 files changed, 261 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
> > index 9ec3767..e11e5e7 100644
> > --- a/arch/arm/boot/dts/mt7623.dtsi
> > +++ b/arch/arm/boot/dts/mt7623.dtsi
> > @@ -20,6 +20,7 @@
> > #include <dt-bindings/power/mt2701-power.h>
> > #include <dt-bindings/gpio/gpio.h>
> > #include <dt-bindings/phy/phy.h>
> > +#include <dt-bindings/memory/mt2701-larb-port.h>
> > #include <dt-bindings/reset/mt2701-resets.h>
> > #include <dt-bindings/thermal/thermal.h>
> > #include "skeleton64.dtsi"
> > @@ -28,6 +29,11 @@
> > compatible = "mediatek,mt7623";
> > interrupt-parent = <&sysirq>;
> >
> > + aliases {
> > + rdma0 = &rdma0;
> > + rdma1 = &rdma1;
>
> For display, are these two aliases enough?
Yes, this part is the same as mt2701.
https://patchwork.kernel.org/patch/9803813/
> > + };
> > +
...
> > + wdma at 14009000 {
> > + compatible = "mediatek,mt7623-disp-wdma",
> > + "mediatek,mt2701-disp-wdma";
>
> There is neither "mediatek,mt7623-disp-wdma" nor
> "mediatek,mt2701-disp-wdma" in driver, do you really need this device
> node?
Okay, I will remove it.
> > + reg = <0 0x14009000 0 0x1000>;
> > + interrupts = <GIC_SPI 154 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&mmsys CLK_MM_DISP_WDMA>;
> > + iommus = <&iommu MT2701_M4U_PORT_DISP_WDMA>;
> > + mediatek,larb = <&larb0>;
> > + };
> > +
> > + bls: bls at 1400a000 {
> > + compatible = "mediatek,mt7623-disp-pwm",
> > + "mediatek,mt2701-disp-pwm";
> > + reg = <0 0x1400a000 0 0x1000>;
> > + #pwm-cells = <2>;
> > + clocks = <&mmsys CLK_MM_MDP_BLS_26M>,
> > + <&mmsys CLK_MM_DISP_BLS>;
> > + clock-names = "main", "mm";
> > + status = "disabled";
> > + };
> > +
> > + color at 1400b000 {
>
> color: color at 1400b000 {
Okay.
> > + compatible = "mediatek,mt7623-disp-color",
> > + "mediatek,mt2701-disp-color";
> > + reg = <0 0x1400b000 0 0x1000>;
> > + interrupts = <GIC_SPI 156 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&mmsys CLK_MM_DISP_COLOR>;
> > + };
> > +
next prev parent reply other threads:[~2017-09-21 9:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 6:27 [PATCH v1 0/4] update MT7623 and MT2701 dts Ryder Lee
2017-09-19 6:27 ` Ryder Lee
2017-09-19 6:27 ` Ryder Lee
2017-09-19 6:27 ` [PATCH v1 1/4] arm: dts: mediatek: update audio node for mt2701 and mt7623 Ryder Lee
2017-09-19 6:27 ` Ryder Lee
2017-09-19 6:27 ` Ryder Lee
2017-09-19 6:27 ` [PATCH v1 2/4] arm: dts: mt7623: update pio, usb and crypto nodes Ryder Lee
2017-09-19 6:27 ` Ryder Lee
2017-09-19 6:27 ` Ryder Lee
2017-09-19 6:27 ` [PATCH v1 3/4] arm: dts: mt7623: add display related nodes Ryder Lee
2017-09-19 6:27 ` Ryder Lee
2017-09-19 6:27 ` Ryder Lee
2017-09-19 15:26 ` CK Hu
2017-09-19 15:26 ` CK Hu
2017-09-19 15:26 ` CK Hu
2017-09-21 9:50 ` Ryder Lee [this message]
2017-09-21 9:50 ` Ryder Lee
2017-09-21 9:50 ` Ryder Lee
2017-09-20 1:11 ` CK Hu
2017-09-20 1:11 ` CK Hu
2017-09-20 1:11 ` CK Hu
2017-09-21 9:53 ` Ryder Lee
2017-09-21 9:53 ` Ryder Lee
2017-09-21 9:53 ` Ryder Lee
2017-09-19 6:27 ` [PATCH v1 4/4] arm: dts: mt7623: add PCIe " Ryder Lee
2017-09-19 6:27 ` Ryder Lee
2017-09-19 6:27 ` Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505987424.3084.8.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.