From: Allen Pais <allen.lkml@gmail.com> To: linux-scsi@vger.kernel.org Cc: nab@linux-iscsi.org, target-devel@vger.kernel.org, Allen Pais <allen.lkml@gmail.com> Subject: [PATCH 4/5] iscsi-target: use setup_timer() helper. Date: Fri, 22 Sep 2017 10:20:53 +0000 [thread overview] Message-ID: <1506074934-15062-5-git-send-email-allen.lkml@gmail.com> (raw) In-Reply-To: <1506074934-15062-1-git-send-email-allen.lkml@gmail.com> Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais <allen.lkml@gmail.com> --- drivers/target/iscsi/iscsi_target_erl1.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_erl1.c b/drivers/target/iscsi/iscsi_target_erl1.c index fe9b7f1..858d9c6 100644 --- a/drivers/target/iscsi/iscsi_target_erl1.c +++ b/drivers/target/iscsi/iscsi_target_erl1.c @@ -1264,10 +1264,9 @@ void iscsit_start_dataout_timer( pr_debug("Starting DataOUT timer for ITT: 0x%08x on" " CID: %hu.\n", cmd->init_task_tag, conn->cid); - init_timer(&cmd->dataout_timer); + setup_timer(&cmd->dataout_timer, iscsit_handle_dataout_timeout, + (unsigned long)cmd); cmd->dataout_timer.expires = (get_jiffies_64() + na->dataout_timeout * HZ); - cmd->dataout_timer.data = (unsigned long)cmd; - cmd->dataout_timer.function = iscsit_handle_dataout_timeout; cmd->dataout_timer_flags &= ~ISCSI_TF_STOP; cmd->dataout_timer_flags |= ISCSI_TF_RUNNING; add_timer(&cmd->dataout_timer); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Allen Pais <allen.lkml@gmail.com> To: linux-scsi@vger.kernel.org Cc: nab@linux-iscsi.org, target-devel@vger.kernel.org, Allen Pais <allen.lkml@gmail.com> Subject: [PATCH 4/5] iscsi-target: use setup_timer() helper. Date: Fri, 22 Sep 2017 15:38:53 +0530 [thread overview] Message-ID: <1506074934-15062-5-git-send-email-allen.lkml@gmail.com> (raw) In-Reply-To: <1506074934-15062-1-git-send-email-allen.lkml@gmail.com> Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais <allen.lkml@gmail.com> --- drivers/target/iscsi/iscsi_target_erl1.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_erl1.c b/drivers/target/iscsi/iscsi_target_erl1.c index fe9b7f1..858d9c6 100644 --- a/drivers/target/iscsi/iscsi_target_erl1.c +++ b/drivers/target/iscsi/iscsi_target_erl1.c @@ -1264,10 +1264,9 @@ void iscsit_start_dataout_timer( pr_debug("Starting DataOUT timer for ITT: 0x%08x on" " CID: %hu.\n", cmd->init_task_tag, conn->cid); - init_timer(&cmd->dataout_timer); + setup_timer(&cmd->dataout_timer, iscsit_handle_dataout_timeout, + (unsigned long)cmd); cmd->dataout_timer.expires = (get_jiffies_64() + na->dataout_timeout * HZ); - cmd->dataout_timer.data = (unsigned long)cmd; - cmd->dataout_timer.function = iscsit_handle_dataout_timeout; cmd->dataout_timer_flags &= ~ISCSI_TF_STOP; cmd->dataout_timer_flags |= ISCSI_TF_RUNNING; add_timer(&cmd->dataout_timer); -- 2.7.4
next prev parent reply other threads:[~2017-09-22 10:20 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-22 10:08 [PATCH 0/5] use setup_timer() helper function Allen Pais 2017-09-22 10:20 ` Allen Pais 2017-09-22 10:08 ` [PATCH 1/5] iscsi-target: use setup_timer() helper Allen Pais 2017-09-22 10:20 ` Allen Pais 2017-09-22 10:08 ` [PATCH 2/5] " Allen Pais 2017-09-22 10:20 ` Allen Pais 2017-09-22 10:08 ` [PATCH 3/5] " Allen Pais 2017-09-22 10:20 ` Allen Pais 2017-09-22 10:08 ` Allen Pais [this message] 2017-09-22 10:20 ` [PATCH 4/5] " Allen Pais 2017-09-22 10:08 ` [PATCH 5/5] " Allen Pais 2017-09-22 10:20 ` Allen Pais
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1506074934-15062-5-git-send-email-allen.lkml@gmail.com \ --to=allen.lkml@gmail.com \ --cc=linux-scsi@vger.kernel.org \ --cc=nab@linux-iscsi.org \ --cc=target-devel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.