From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
yong mao <yong.mao@mediatek.com>,
Linus Walleij <linus.walleij@linaro.org>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Phong LE <ple@baylibre.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
srv_heupstream <srv_heupstream@mediatek.com>
Subject: Re: [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" from mmc nodes
Date: Wed, 27 Sep 2017 09:14:45 +0800 [thread overview]
Message-ID: <1506474885.19851.5.camel@mhfsdcap03> (raw)
In-Reply-To: <CAPDyKFo7rC5UVWw9VyJ7ws1wW4kCvSW7Jcsgqd6gY_nifB6fTw@mail.gmail.com>
On Wed, 2017-09-27 at 00:37 +0200, Ulf Hansson wrote:
> On 12 September 2017 at 11:07, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> > devicetree bindings has been updated to support multi-platforms,
> > so that each platform has its owns compatible name.
> > And, this compatible name may used in driver to distinguish with
> > other platform.
>
> This does not seems to be DT backwards compatible.
>
> If the driver starts interpreting the "mt8135-mmc" differently,
> wouldn't that lead to old DTBs to become broken?
>
> Kind regards
> Uffe
At patch 03/12, it shows that no difference between "mt8135-mmc" and
"mt8173-mmc", and following changes will make difference between these
two.
but, the user should update DTS & driver together,then will do not have
compatible issue.
>
> >
> > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 12 ++++--------
> > 1 file changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index b99a273..26396ef 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -682,8 +682,7 @@
> > };
> >
> > mmc0: mmc@11230000 {
> > - compatible = "mediatek,mt8173-mmc",
> > - "mediatek,mt8135-mmc";
> > + compatible = "mediatek,mt8173-mmc";
> > reg = <0 0x11230000 0 0x1000>;
> > interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&pericfg CLK_PERI_MSDC30_0>,
> > @@ -693,8 +692,7 @@
> > };
> >
> > mmc1: mmc@11240000 {
> > - compatible = "mediatek,mt8173-mmc",
> > - "mediatek,mt8135-mmc";
> > + compatible = "mediatek,mt8173-mmc";
> > reg = <0 0x11240000 0 0x1000>;
> > interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&pericfg CLK_PERI_MSDC30_1>,
> > @@ -704,8 +702,7 @@
> > };
> >
> > mmc2: mmc@11250000 {
> > - compatible = "mediatek,mt8173-mmc",
> > - "mediatek,mt8135-mmc";
> > + compatible = "mediatek,mt8173-mmc";
> > reg = <0 0x11250000 0 0x1000>;
> > interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&pericfg CLK_PERI_MSDC30_2>,
> > @@ -715,8 +712,7 @@
> > };
> >
> > mmc3: mmc@11260000 {
> > - compatible = "mediatek,mt8173-mmc",
> > - "mediatek,mt8135-mmc";
> > + compatible = "mediatek,mt8173-mmc";
> > reg = <0 0x11260000 0 0x1000>;
> > interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&pericfg CLK_PERI_MSDC30_3>,
> > --
> > 1.8.1.1.dirty
> >
WARNING: multiple messages have this Message-ID (diff)
From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
yong mao <yong.mao@mediatek.com>,
Linus Walleij <linus.walleij@linaro.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Phong LE <ple@baylibre.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
srv_heupstream <srv_heupstream@mediatek.com>
Subject: Re: [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" from mmc nodes
Date: Wed, 27 Sep 2017 09:14:45 +0800 [thread overview]
Message-ID: <1506474885.19851.5.camel@mhfsdcap03> (raw)
In-Reply-To: <CAPDyKFo7rC5UVWw9VyJ7ws1wW4kCvSW7Jcsgqd6gY_nifB6fTw@mail.gmail.com>
On Wed, 2017-09-27 at 00:37 +0200, Ulf Hansson wrote:
> On 12 September 2017 at 11:07, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> > devicetree bindings has been updated to support multi-platforms,
> > so that each platform has its owns compatible name.
> > And, this compatible name may used in driver to distinguish with
> > other platform.
>
> This does not seems to be DT backwards compatible.
>
> If the driver starts interpreting the "mt8135-mmc" differently,
> wouldn't that lead to old DTBs to become broken?
>
> Kind regards
> Uffe
At patch 03/12, it shows that no difference between "mt8135-mmc" and
"mt8173-mmc", and following changes will make difference between these
two.
but, the user should update DTS & driver together,then will do not have
compatible issue.
>
> >
> > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 12 ++++--------
> > 1 file changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index b99a273..26396ef 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -682,8 +682,7 @@
> > };
> >
> > mmc0: mmc@11230000 {
> > - compatible = "mediatek,mt8173-mmc",
> > - "mediatek,mt8135-mmc";
> > + compatible = "mediatek,mt8173-mmc";
> > reg = <0 0x11230000 0 0x1000>;
> > interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&pericfg CLK_PERI_MSDC30_0>,
> > @@ -693,8 +692,7 @@
> > };
> >
> > mmc1: mmc@11240000 {
> > - compatible = "mediatek,mt8173-mmc",
> > - "mediatek,mt8135-mmc";
> > + compatible = "mediatek,mt8173-mmc";
> > reg = <0 0x11240000 0 0x1000>;
> > interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&pericfg CLK_PERI_MSDC30_1>,
> > @@ -704,8 +702,7 @@
> > };
> >
> > mmc2: mmc@11250000 {
> > - compatible = "mediatek,mt8173-mmc",
> > - "mediatek,mt8135-mmc";
> > + compatible = "mediatek,mt8173-mmc";
> > reg = <0 0x11250000 0 0x1000>;
> > interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&pericfg CLK_PERI_MSDC30_2>,
> > @@ -715,8 +712,7 @@
> > };
> >
> > mmc3: mmc@11260000 {
> > - compatible = "mediatek,mt8173-mmc",
> > - "mediatek,mt8135-mmc";
> > + compatible = "mediatek,mt8173-mmc";
> > reg = <0 0x11260000 0 0x1000>;
> > interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&pericfg CLK_PERI_MSDC30_3>,
> > --
> > 1.8.1.1.dirty
> >
WARNING: multiple messages have this Message-ID (diff)
From: chaotian.jing@mediatek.com (Chaotian Jing)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" from mmc nodes
Date: Wed, 27 Sep 2017 09:14:45 +0800 [thread overview]
Message-ID: <1506474885.19851.5.camel@mhfsdcap03> (raw)
In-Reply-To: <CAPDyKFo7rC5UVWw9VyJ7ws1wW4kCvSW7Jcsgqd6gY_nifB6fTw@mail.gmail.com>
On Wed, 2017-09-27 at 00:37 +0200, Ulf Hansson wrote:
> On 12 September 2017 at 11:07, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> > devicetree bindings has been updated to support multi-platforms,
> > so that each platform has its owns compatible name.
> > And, this compatible name may used in driver to distinguish with
> > other platform.
>
> This does not seems to be DT backwards compatible.
>
> If the driver starts interpreting the "mt8135-mmc" differently,
> wouldn't that lead to old DTBs to become broken?
>
> Kind regards
> Uffe
At patch 03/12, it shows that no difference between "mt8135-mmc" and
"mt8173-mmc", and following changes will make difference between these
two.
but, the user should update DTS & driver together,then will do not have
compatible issue.
>
> >
> > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 12 ++++--------
> > 1 file changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index b99a273..26396ef 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -682,8 +682,7 @@
> > };
> >
> > mmc0: mmc at 11230000 {
> > - compatible = "mediatek,mt8173-mmc",
> > - "mediatek,mt8135-mmc";
> > + compatible = "mediatek,mt8173-mmc";
> > reg = <0 0x11230000 0 0x1000>;
> > interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&pericfg CLK_PERI_MSDC30_0>,
> > @@ -693,8 +692,7 @@
> > };
> >
> > mmc1: mmc at 11240000 {
> > - compatible = "mediatek,mt8173-mmc",
> > - "mediatek,mt8135-mmc";
> > + compatible = "mediatek,mt8173-mmc";
> > reg = <0 0x11240000 0 0x1000>;
> > interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&pericfg CLK_PERI_MSDC30_1>,
> > @@ -704,8 +702,7 @@
> > };
> >
> > mmc2: mmc at 11250000 {
> > - compatible = "mediatek,mt8173-mmc",
> > - "mediatek,mt8135-mmc";
> > + compatible = "mediatek,mt8173-mmc";
> > reg = <0 0x11250000 0 0x1000>;
> > interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&pericfg CLK_PERI_MSDC30_2>,
> > @@ -715,8 +712,7 @@
> > };
> >
> > mmc3: mmc at 11260000 {
> > - compatible = "mediatek,mt8173-mmc",
> > - "mediatek,mt8135-mmc";
> > + compatible = "mediatek,mt8173-mmc";
> > reg = <0 0x11260000 0 0x1000>;
> > interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_LOW>;
> > clocks = <&pericfg CLK_PERI_MSDC30_3>,
> > --
> > 1.8.1.1.dirty
> >
next prev parent reply other threads:[~2017-09-27 1:14 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 9:07 mmc: mediatek: add support of mt2701/mt2712 Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` [PATCH 01/12] mmc: dt-bindings: update Mediatek MMC bindings Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-13 14:10 ` Rob Herring
2017-09-13 14:10 ` Rob Herring
2017-09-13 14:10 ` Rob Herring
2017-09-14 2:10 ` Chaotian Jing
2017-09-14 2:10 ` Chaotian Jing
2017-09-14 2:10 ` Chaotian Jing
2017-09-21 11:38 ` Linus Walleij
2017-09-21 11:38 ` Linus Walleij
2017-09-21 11:38 ` Linus Walleij
2017-09-26 22:33 ` Ulf Hansson
2017-09-26 22:33 ` Ulf Hansson
2017-09-26 22:33 ` Ulf Hansson
2017-09-27 1:18 ` Chaotian Jing
2017-09-27 1:18 ` Chaotian Jing
2017-09-27 1:18 ` Chaotian Jing
2017-09-29 1:56 ` Chaotian Jing
2017-09-29 1:56 ` Chaotian Jing
2017-09-29 1:56 ` Chaotian Jing
2017-10-02 6:53 ` Ulf Hansson
2017-10-02 6:53 ` Ulf Hansson
2017-10-02 6:53 ` Ulf Hansson
2017-10-09 2:16 ` Chaotian Jing
2017-10-09 2:16 ` Chaotian Jing
2017-10-09 2:16 ` Chaotian Jing
2017-10-02 10:49 ` Yingjoe Chen
2017-10-02 10:49 ` Yingjoe Chen
2017-10-02 10:49 ` Yingjoe Chen
2017-09-12 9:07 ` [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" from mmc nodes Chaotian Jing
2017-09-12 9:07 ` [PATCH 02/12] arm64: dts: mt8173: remove "mediatek, mt8135-mmc" " Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-26 22:37 ` [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" " Ulf Hansson
2017-09-26 22:37 ` Ulf Hansson
2017-09-26 22:37 ` Ulf Hansson
2017-09-27 1:14 ` Chaotian Jing [this message]
2017-09-27 1:14 ` Chaotian Jing
2017-09-27 1:14 ` Chaotian Jing
2017-09-12 9:07 ` [PATCH 03/12] mmc: mediatek: add support of mt2701/mt2712 Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-26 1:38 ` Chaotian Jing
2017-09-26 1:38 ` Chaotian Jing
2017-09-26 1:38 ` Chaotian Jing
2017-09-12 9:07 ` [PATCH 04/12] mmc: mediatek: make hs400_tune_response only for mt8173 Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` [PATCH 05/12] mmc: mediatek: add pad_tune0 support Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` [PATCH 06/12] mmc: mediatek: add async fifo and data tune support Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` [PATCH 07/12] mmc: mediatek: add busy_check support Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` [PATCH 08/12] mmc: mediatek: add stop_clk fix and enhance_rx support Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` [PATCH 09/12] mmc: mediatek: add support of source_cg clock Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` [PATCH 10/12] mmc: mediatek: add latch-ck support Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` [PATCH 11/12] mmc: mediatek: improve eMMC hs400 mode read performance Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` [PATCH 12/12] mmc: mediatek: perfer to use rise edge latching for cmd line Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
2017-09-12 9:07 ` Chaotian Jing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506474885.19851.5.camel@mhfsdcap03 \
--to=chaotian.jing@mediatek.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=javier@osg.samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=ple@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=ulf.hansson@linaro.org \
--cc=will.deacon@arm.com \
--cc=yong.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.