From: Andrew Jeffery <andrew@aj.id.au>
To: Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: "Russell King" <linux@armlinux.org.uk>,
devicetree <devicetree@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Rick Altherr" <raltherr@google.com>,
"Brendan Higgins" <brendanhiggins@google.com>,
"Cédric Le Goater" <clg@kaod.org>,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH v2 9/9] ARM: dts: aspeed: Clean up UART nodes
Date: Thu, 05 Oct 2017 10:09:10 +1030 [thread overview]
Message-ID: <1507160350.5452.37.camel@aj.id.au> (raw)
In-Reply-To: <CACPK8XcQB6PQhGxESV0owo_sAg2+4KV7hsyT-TJOpuOCXmTcdw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]
On Wed, 2017-10-04 at 16:22 +0930, Joel Stanley wrote:
> > On Wed, Oct 4, 2017 at 4:19 PM, Joel Stanley <joel@jms.id.au> wrote:
>
> > diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> > index 61cc2d25143a..cef51dcc1002 100644
> > --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> > @@ -297,9 +297,9 @@
> > };
> > };
> >
> > - uart6: serial@1e787000 {
> > - compatible = "ns16550a";
> > - reg = <0x1e787000 0x1000>;
> > + vuart: vuart@1e787000 {
>
> Doh. I'll fix this up when I apply, assuming I don't need to send a v3.
In that case:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
>
>
> > + compatible = "aspeed,ast2500-vuart";
> > + reg = <0x1e787000 0x40>;
> > reg-shift = <2>;
> > interrupts = <10>;
> > clocks = <&clk_uart>;
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jeffery <andrew-zrmu5oMJ5Fs@public.gmane.org>
To: Joel Stanley <joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: "Russell King" <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Linux ARM"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"Linux Kernel Mailing List"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Rick Altherr" <raltherr-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
"Brendan Higgins"
<brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
"Cédric Le Goater" <clg-Bxea+6Xhats@public.gmane.org>,
linux-aspeed-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH v2 9/9] ARM: dts: aspeed: Clean up UART nodes
Date: Thu, 05 Oct 2017 10:09:10 +1030 [thread overview]
Message-ID: <1507160350.5452.37.camel@aj.id.au> (raw)
In-Reply-To: <CACPK8XcQB6PQhGxESV0owo_sAg2+4KV7hsyT-TJOpuOCXmTcdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]
On Wed, 2017-10-04 at 16:22 +0930, Joel Stanley wrote:
> > On Wed, Oct 4, 2017 at 4:19 PM, Joel Stanley <joel@jms.id.au> wrote:
>
> > diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> > index 61cc2d25143a..cef51dcc1002 100644
> > --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> > @@ -297,9 +297,9 @@
> > };
> > };
> >
> > - uart6: serial@1e787000 {
> > - compatible = "ns16550a";
> > - reg = <0x1e787000 0x1000>;
> > + vuart: vuart@1e787000 {
>
> Doh. I'll fix this up when I apply, assuming I don't need to send a v3.
In that case:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
>
>
> > + compatible = "aspeed,ast2500-vuart";
> > + reg = <0x1e787000 0x40>;
> > reg-shift = <2>;
> > interrupts = <10>;
> > clocks = <&clk_uart>;
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: andrew@aj.id.au (Andrew Jeffery)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 9/9] ARM: dts: aspeed: Clean up UART nodes
Date: Thu, 05 Oct 2017 10:09:10 +1030 [thread overview]
Message-ID: <1507160350.5452.37.camel@aj.id.au> (raw)
In-Reply-To: <CACPK8XcQB6PQhGxESV0owo_sAg2+4KV7hsyT-TJOpuOCXmTcdw@mail.gmail.com>
On Wed, 2017-10-04 at 16:22 +0930, Joel Stanley wrote:
> > On Wed, Oct 4, 2017 at 4:19 PM, Joel Stanley <joel@jms.id.au> wrote:
>
> > diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> > index 61cc2d25143a..cef51dcc1002 100644
> > --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> > @@ -297,9 +297,9 @@
> > ????????????????????????????????};
> > ????????????????????????};
> >
> > -???????????????????????uart6: serial at 1e787000 {
> > -???????????????????????????????compatible = "ns16550a";
> > -???????????????????????????????reg = <0x1e787000 0x1000>;
> > +???????????????????????vuart: vuart at 1e787000 {
>
> Doh. I'll fix this up when I apply, assuming I don't need to send a v3.
In that case:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
>
>
> > +???????????????????????????????compatible = "aspeed,ast2500-vuart";
> > +???????????????????????????????reg = <0x1e787000 0x40>;
> > ????????????????????????????????reg-shift = <2>;
> > ????????????????????????????????interrupts = <10>;
> > ????????????????????????????????clocks = <&clk_uart>;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171005/b69c0c02/attachment.sig>
next prev parent reply other threads:[~2017-10-04 23:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 6:49 [PATCH v2 0/9] ARM: dts: aspeed: Device tree updates Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 6:49 ` [PATCH v2 1/9] ARM: dts: aspeed: Move pinctrl subnodes to improve readability Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 6:49 ` [PATCH v2 2/9] ARM: dts: aspeed: Reorder ADC node Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 23:31 ` Andrew Jeffery
2017-10-04 23:31 ` Andrew Jeffery
2017-10-04 6:49 ` [PATCH v2 3/9] ARM: dts: aspeed: Add I2C buses Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 6:49 ` [PATCH v2 4/9] ARM: dts: aspeed-romulus: Add I2C devices Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 23:35 ` Andrew Jeffery
2017-10-04 23:35 ` Andrew Jeffery
2017-10-04 23:35 ` Andrew Jeffery
2017-10-04 6:49 ` [PATCH v2 5/9] ARM: dts: aspeed-palmetto: " Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 6:49 ` [PATCH v2 6/9] ARM: dts: aspeed-ast2500: " Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 6:49 ` [PATCH v2 7/9] ARM: dts: aspeed: Add aliases for UARTs Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 6:49 ` [PATCH v2 8/9] ARM: dts: aspeed: Correctly order UART nodes Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 23:37 ` Andrew Jeffery
2017-10-04 23:37 ` Andrew Jeffery
2017-10-04 23:37 ` Andrew Jeffery
2017-10-04 6:49 ` [PATCH v2 9/9] ARM: dts: aspeed: Clean up " Joel Stanley
2017-10-04 6:49 ` Joel Stanley
2017-10-04 6:52 ` Joel Stanley
2017-10-04 6:52 ` Joel Stanley
2017-10-04 6:52 ` Joel Stanley
2017-10-04 23:39 ` Andrew Jeffery [this message]
2017-10-04 23:39 ` Andrew Jeffery
2017-10-04 23:39 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507160350.5452.37.camel@aj.id.au \
--to=andrew@aj.id.au \
--cc=brendanhiggins@google.com \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=raltherr@google.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.