From: Elena Reshetova <elena.reshetova@intel.com> To: mingo@redhat.com Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, peterz@infradead.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, tj@kernel.org, hannes@cmpxchg.org, lizefan@huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, eparis@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, luto@kernel.org, keescook@chromium.org, tglx@linutronix.de, dvhart@infradead.org, ebiederm@xmission.com, linux-mm@kvack.org, axboe@kernel.dk, Elena Reshetova <elena.reshetova@intel.com> Subject: [PATCH 00/15] v5 kernel core pieces refcount conversions Date: Fri, 20 Oct 2017 15:15:42 +0300 [thread overview] Message-ID: <1508501757-15784-1-git-send-email-elena.reshetova@intel.com> (raw) Note: this is just a fresh rebase on top of linux-next. No functional changes. Changes in v5: * Kees catched that the following changes in perf_event_context.refcount and futex_pi_state.refcount are not correct now when ARCH_HAS_REFCOUNT is enabled: - WARN_ON(!atomic_inc_not_zero(refcount)); + refcount_inc(refcount); So they are now changed back to using refcount_inc_not_zero. Changes in v4: * just rebase and corrections on linux-next/master Changes in v3: * SoB chain corrected * minor corrections based on v2 feedback * rebase on linux-next/master as of today Changes in v2: * dropped already merged patches * rebase on top of linux-next/master * Now by default refcount_t = atomic_t (*) and uses all atomic standard operations unless CONFIG_REFCOUNT_FULL is enabled. This is a compromise for the systems that are critical on performance (such as net) and cannot accept even slight delay on the refcounter operations. This series, for core kernel components, replaces atomic_t reference counters with the new refcount_t type and API (see include/linux/refcount.h). By doing this we prevent intentional or accidental underflows or overflows that can led to use-after-free vulnerabilities. The patches are fully independent and can be cherry-picked separately. If there are no objections to the patches, please merge them via respective trees. Elena Reshetova (15): sched: convert sighand_struct.count to refcount_t sched: convert signal_struct.sigcnt to refcount_t sched: convert user_struct.__count to refcount_t sched: convert numa_group.refcount to refcount_t sched/task_struct: convert task_struct.usage to refcount_t sched/task_struct: convert task_struct.stack_refcount to refcount_t perf: convert perf_event_context.refcount to refcount_t perf/ring_buffer: convert ring_buffer.refcount to refcount_t perf/ring_buffer: convert ring_buffer.aux_refcount to refcount_t uprobes: convert uprobe.ref to refcount_t nsproxy: convert nsproxy.count to refcount_t groups: convert group_info.usage to refcount_t creds: convert cred.usage to refcount_t kcov: convert kcov.refcount to refcount_t bdi: convert bdi_writeback_congested.refcnt from atomic_t to refcount_t fs/exec.c | 4 ++-- fs/proc/task_nommu.c | 2 +- include/linux/backing-dev-defs.h | 3 ++- include/linux/backing-dev.h | 4 ++-- include/linux/cred.h | 13 ++++++------ include/linux/init_task.h | 7 +++--- include/linux/nsproxy.h | 6 +++--- include/linux/perf_event.h | 3 ++- include/linux/sched.h | 5 +++-- include/linux/sched/signal.h | 5 +++-- include/linux/sched/task.h | 4 ++-- include/linux/sched/task_stack.h | 2 +- include/linux/sched/user.h | 5 +++-- kernel/cred.c | 46 ++++++++++++++++++++-------------------- kernel/events/core.c | 18 ++++++++-------- kernel/events/internal.h | 5 +++-- kernel/events/ring_buffer.c | 8 +++---- kernel/events/uprobes.c | 8 +++---- kernel/fork.c | 24 ++++++++++----------- kernel/groups.c | 2 +- kernel/kcov.c | 9 ++++---- kernel/nsproxy.c | 6 +++--- kernel/sched/fair.c | 12 +++++------ kernel/user.c | 8 +++---- mm/backing-dev.c | 14 ++++++------ 25 files changed, 117 insertions(+), 106 deletions(-) -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Elena Reshetova <elena.reshetova@intel.com> To: mingo@redhat.com Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, peterz@infradead.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, tj@kernel.org, hannes@cmpxchg.org, lizefan@huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, eparis@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, luto@kernel.org, keescook@chromium.org, tglx@linutronix.de, dvhart@infradead.org, ebiederm@xmission.com, linux-mm@kvack.org, axboe@kernel.dk, Elena Reshetova <elena.reshetova@intel.com> Subject: [PATCH 00/15] v5 kernel core pieces refcount conversions Date: Fri, 20 Oct 2017 15:15:42 +0300 [thread overview] Message-ID: <1508501757-15784-1-git-send-email-elena.reshetova@intel.com> (raw) Note: this is just a fresh rebase on top of linux-next. No functional changes. Changes in v5: * Kees catched that the following changes in perf_event_context.refcount and futex_pi_state.refcount are not correct now when ARCH_HAS_REFCOUNT is enabled: - WARN_ON(!atomic_inc_not_zero(refcount)); + refcount_inc(refcount); So they are now changed back to using refcount_inc_not_zero. Changes in v4: * just rebase and corrections on linux-next/master Changes in v3: * SoB chain corrected * minor corrections based on v2 feedback * rebase on linux-next/master as of today Changes in v2: * dropped already merged patches * rebase on top of linux-next/master * Now by default refcount_t = atomic_t (*) and uses all atomic standard operations unless CONFIG_REFCOUNT_FULL is enabled. This is a compromise for the systems that are critical on performance (such as net) and cannot accept even slight delay on the refcounter operations. This series, for core kernel components, replaces atomic_t reference counters with the new refcount_t type and API (see include/linux/refcount.h). By doing this we prevent intentional or accidental underflows or overflows that can led to use-after-free vulnerabilities. The patches are fully independent and can be cherry-picked separately. If there are no objections to the patches, please merge them via respective trees. Elena Reshetova (15): sched: convert sighand_struct.count to refcount_t sched: convert signal_struct.sigcnt to refcount_t sched: convert user_struct.__count to refcount_t sched: convert numa_group.refcount to refcount_t sched/task_struct: convert task_struct.usage to refcount_t sched/task_struct: convert task_struct.stack_refcount to refcount_t perf: convert perf_event_context.refcount to refcount_t perf/ring_buffer: convert ring_buffer.refcount to refcount_t perf/ring_buffer: convert ring_buffer.aux_refcount to refcount_t uprobes: convert uprobe.ref to refcount_t nsproxy: convert nsproxy.count to refcount_t groups: convert group_info.usage to refcount_t creds: convert cred.usage to refcount_t kcov: convert kcov.refcount to refcount_t bdi: convert bdi_writeback_congested.refcnt from atomic_t to refcount_t fs/exec.c | 4 ++-- fs/proc/task_nommu.c | 2 +- include/linux/backing-dev-defs.h | 3 ++- include/linux/backing-dev.h | 4 ++-- include/linux/cred.h | 13 ++++++------ include/linux/init_task.h | 7 +++--- include/linux/nsproxy.h | 6 +++--- include/linux/perf_event.h | 3 ++- include/linux/sched.h | 5 +++-- include/linux/sched/signal.h | 5 +++-- include/linux/sched/task.h | 4 ++-- include/linux/sched/task_stack.h | 2 +- include/linux/sched/user.h | 5 +++-- kernel/cred.c | 46 ++++++++++++++++++++-------------------- kernel/events/core.c | 18 ++++++++-------- kernel/events/internal.h | 5 +++-- kernel/events/ring_buffer.c | 8 +++---- kernel/events/uprobes.c | 8 +++---- kernel/fork.c | 24 ++++++++++----------- kernel/groups.c | 2 +- kernel/kcov.c | 9 ++++---- kernel/nsproxy.c | 6 +++--- kernel/sched/fair.c | 12 +++++------ kernel/user.c | 8 +++---- mm/backing-dev.c | 14 ++++++------ 25 files changed, 117 insertions(+), 106 deletions(-) -- 2.7.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-10-20 12:15 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-20 12:15 Elena Reshetova [this message] 2017-10-20 12:15 ` [PATCH 00/15] v5 kernel core pieces refcount conversions Elena Reshetova 2017-10-20 12:15 ` [PATCH 01/15] sched: convert sighand_struct.count to refcount_t Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:43 ` Thomas Gleixner 2017-10-20 12:43 ` Thomas Gleixner 2017-10-23 10:22 ` Reshetova, Elena 2017-10-23 10:22 ` Reshetova, Elena 2017-10-23 10:26 ` Thomas Gleixner 2017-10-23 10:26 ` Thomas Gleixner 2017-10-23 10:26 ` Thomas Gleixner 2017-10-23 10:45 ` Reshetova, Elena 2017-10-23 10:45 ` Reshetova, Elena 2017-10-20 12:15 ` [PATCH 02/15] sched: convert signal_struct.sigcnt " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 03/15] sched: convert user_struct.__count " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 04/15] sched: convert numa_group.refcount " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 05/15] sched/task_struct: convert task_struct.usage " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 06/15] sched/task_struct: convert task_struct.stack_refcount " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 07/15] perf: convert perf_event_context.refcount " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 08/15] perf/ring_buffer: convert ring_buffer.refcount " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 09/15] perf/ring_buffer: convert ring_buffer.aux_refcount " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 10/15] uprobes: convert uprobe.ref " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 11/15] nsproxy: convert nsproxy.count " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 12/15] groups: convert group_info.usage " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 13/15] creds: convert cred.usage " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 14/15] kcov: convert kcov.refcount " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova 2017-10-20 12:15 ` [PATCH 15/15] bdi: convert bdi_writeback_congested.refcnt from atomic_t " Elena Reshetova 2017-10-20 12:15 ` Elena Reshetova -- strict thread matches above, loose matches on Subject: below -- 2017-08-30 12:22 [PATCH 00/15] v5 kernel core pieces refcount conversions Elena Reshetova 2017-08-31 23:48 ` Kees Cook 2017-09-01 9:48 ` Peter Zijlstra 2017-09-01 16:55 ` Kees Cook 2017-09-01 17:08 ` Reshetova, Elena
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1508501757-15784-1-git-send-email-elena.reshetova@intel.com \ --to=elena.reshetova@intel.com \ --cc=acme@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=alexander.shishkin@linux.intel.com \ --cc=arnd@arndb.de \ --cc=axboe@kernel.dk \ --cc=dvhart@infradead.org \ --cc=ebiederm@xmission.com \ --cc=eparis@redhat.com \ --cc=gregkh@linuxfoundation.org \ --cc=hannes@cmpxchg.org \ --cc=keescook@chromium.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lizefan@huawei.com \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=tj@kernel.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.