From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: alan@linux.intel.com,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1.1 10/13] staging: atomisp: Remove Gmin dead code #1
Date: Fri, 27 Oct 2017 20:16:54 +0300 [thread overview]
Message-ID: <1509124614-30505-1-git-send-email-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20170927182508.52119-11-andriy.shevchenko@linux.intel.com>
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
struct camera_af_platform_data and bound functions are not used anywhere.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
since v1:
- Remove af_power_ctrl which is now unused.
.../media/atomisp/include/linux/atomisp_platform.h | 6 ---
.../platform/intel-mid/atomisp_gmin_platform.c | 43 ----------------------
2 files changed, 49 deletions(-)
diff --git a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
index a8c1825..2dae493 100644
--- a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
+++ b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
@@ -221,12 +221,6 @@ struct camera_sensor_platform_data {
char *module_id);
};
-struct camera_af_platform_data {
- int (*power_ctrl)(struct v4l2_subdev *subdev, int flag);
-};
-
-const struct camera_af_platform_data *camera_get_af_platform_data(void);
-
struct camera_mipi_info {
enum atomisp_camera_port port;
unsigned int num_lanes;
diff --git a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
index 129608a..bf9f34b 100644
--- a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
+++ b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
@@ -106,49 +106,6 @@ const struct atomisp_platform_data *atomisp_get_platform_data(void)
}
EXPORT_SYMBOL_GPL(atomisp_get_platform_data);
-static int af_power_ctrl(struct v4l2_subdev *subdev, int flag)
-{
- struct gmin_subdev *gs = find_gmin_subdev(subdev);
-
- if (gs && gs->v2p8_vcm_on == flag)
- return 0;
- gs->v2p8_vcm_on = flag;
-
- /*
- * The power here is used for dw9817,
- * regulator is from rear sensor
- */
- if (gs->v2p8_vcm_reg) {
- if (flag)
- return regulator_enable(gs->v2p8_vcm_reg);
- else
- return regulator_disable(gs->v2p8_vcm_reg);
- }
- return 0;
-}
-
-/*
- * Used in a handful of modules. Focus motor control, I think. Note
- * that there is no configurability in the API, so this needs to be
- * fixed where it is used.
- *
- * struct camera_af_platform_data {
- * int (*power_ctrl)(struct v4l2_subdev *subdev, int flag);
- * };
- *
- * Note that the implementation in MCG platform_camera.c is stubbed
- * out anyway (i.e. returns zero from the callback) on BYT. So
- * neither needed on gmin platforms or supported upstream.
- */
-const struct camera_af_platform_data *camera_get_af_platform_data(void)
-{
- static struct camera_af_platform_data afpd = {
- .power_ctrl = af_power_ctrl,
- };
- return &afpd;
-}
-EXPORT_SYMBOL_GPL(camera_get_af_platform_data);
-
int atomisp_register_i2c_module(struct v4l2_subdev *subdev,
struct camera_sensor_platform_data *plat_data,
enum intel_v4l2_subdev_type type)
--
2.7.4
next prev parent reply other threads:[~2017-10-27 17:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 18:24 [PATCH v1 00/13] staging: atomisp: clean up bomb Andy Shevchenko
2017-09-27 18:24 ` [PATCH v1 02/13] staging: atomisp: Remove AP1302 sensor support Andy Shevchenko
2017-09-27 18:24 ` [PATCH v1 03/13] staging: atomisp: Use module_i2c_driver() macro Andy Shevchenko
2017-09-27 18:24 ` [PATCH v1 04/13] staging: atomisp: Switch i2c drivers to use ->probe_new() Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 05/13] staging: atomisp: Do not set GPIO twice Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 06/13] staging: atomisp: Remove unneeded gpio.h inclusion Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 07/13] staging: atomisp: Remove ->gpio_ctrl() callback Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 08/13] staging: atomisp: Remove ->power_ctrl() callback Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 09/13] staging: atomisp: Remove unused members of camera_sensor_platform_data Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 10/13] staging: atomisp: Remove Gmin dead code #1 Andy Shevchenko
2017-10-27 17:16 ` Sakari Ailus [this message]
2017-09-27 18:25 ` [PATCH v1 11/13] staging: atomisp: Remove Gmin dead code #2 Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 12/13] staging: atomisp: Remove duplicate declaration in header Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 13/13] staging: atomisp: Remove FSF snail address Andy Shevchenko
2017-10-18 13:53 ` [PATCH v1 00/13] staging: atomisp: clean up bomb Sakari Ailus
2017-10-18 20:53 ` Sakari Ailus
2017-10-19 11:40 ` Andy Shevchenko
2017-10-19 15:14 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509124614-30505-1-git-send-email-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.