From: Sakari Ailus <sakari.ailus@iki.fi>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, Alan Cox <alan@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH v1 00/13] staging: atomisp: clean up bomb
Date: Wed, 18 Oct 2017 16:53:25 +0300 [thread overview]
Message-ID: <20171018135325.ivamfadhzlhioqhp@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20170927182508.52119-1-andriy.shevchenko@linux.intel.com>
Hi Andy,
Thanks for the patchset.
On Wed, Sep 27, 2017 at 09:24:55PM +0300, Andy Shevchenko wrote:
> The driver has been submitted with a limitation to few platforms and
> sensors which it does support. Even though two sensor drivers have no
> users neither on ACPI-enabled platforms, nor in current Linux kernel
> code. Patches 1 and 2 removes those drivers for now.
>
> It seems new contributors follow cargo cult programming done by the
> original driver developers. It's neither good for code, nor for
> reviewing process. To avoid such issues in the future here are few clean
> up patches, i.e. patches 3, 4, 6. 13.
>
> On top of this here are clean ups with regard to GPIO use. One may
> consider this as an intermediate clean up. This part toughly related to
> removal of unused sensor drivers in patches 1 and 2.
>
> Patch series has been partially compile tested. It would be nice to see
> someone with hardware to confirm it doesn't break anything.
Partially compile tested? :-) That sounds really reliable. ;)
Considering the cleanups this set contains, and we need to move forward,
reducing the number of extra drivers that are unverifiable anyway, I think
the patchset is definitely worth merging.
I've rebased this on the current atomisp branch, and I've pushed the result
here:
<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=atomisp-andy>
Let me know if you see issues. The only manually resolved conflict was in
the removal of the ap1302 driver.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi
next prev parent reply other threads:[~2017-10-18 13:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 18:24 [PATCH v1 00/13] staging: atomisp: clean up bomb Andy Shevchenko
2017-09-27 18:24 ` [PATCH v1 02/13] staging: atomisp: Remove AP1302 sensor support Andy Shevchenko
2017-09-27 18:24 ` [PATCH v1 03/13] staging: atomisp: Use module_i2c_driver() macro Andy Shevchenko
2017-09-27 18:24 ` [PATCH v1 04/13] staging: atomisp: Switch i2c drivers to use ->probe_new() Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 05/13] staging: atomisp: Do not set GPIO twice Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 06/13] staging: atomisp: Remove unneeded gpio.h inclusion Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 07/13] staging: atomisp: Remove ->gpio_ctrl() callback Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 08/13] staging: atomisp: Remove ->power_ctrl() callback Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 09/13] staging: atomisp: Remove unused members of camera_sensor_platform_data Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 10/13] staging: atomisp: Remove Gmin dead code #1 Andy Shevchenko
2017-10-27 17:16 ` [PATCH v1.1 " Sakari Ailus
2017-09-27 18:25 ` [PATCH v1 11/13] staging: atomisp: Remove Gmin dead code #2 Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 12/13] staging: atomisp: Remove duplicate declaration in header Andy Shevchenko
2017-09-27 18:25 ` [PATCH v1 13/13] staging: atomisp: Remove FSF snail address Andy Shevchenko
2017-10-18 13:53 ` Sakari Ailus [this message]
2017-10-18 20:53 ` [PATCH v1 00/13] staging: atomisp: clean up bomb Sakari Ailus
2017-10-19 11:40 ` Andy Shevchenko
2017-10-19 15:14 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018135325.ivamfadhzlhioqhp@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.