From: Dave Jiang <dave.jiang@intel.com>
To: dan.j.williams@intel.com
Cc: linux-nvdimm@lists.01.org
Subject: [PATCH v2 1/4] ndctl: add support to alloc_intel_cmd for variable payload
Date: Wed, 06 Dec 2017 15:46:54 -0700 [thread overview]
Message-ID: <151260039600.3630.12960859289293301854.stgit@djiang5-desk3.ch.intel.com> (raw)
Certain payloads have variable size. The existing alloc_intel_cmd()
does not take into account of that. Adding additional size for allocation.
We do waste a little bit of the space because of the smart payload.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
0 files changed
diff --git a/ndctl/lib/intel.c b/ndctl/lib/intel.c
index 3e4260f..b85a682 100644
--- a/ndctl/lib/intel.c
+++ b/ndctl/lib/intel.c
@@ -33,7 +33,7 @@ static struct ndctl_cmd *alloc_intel_cmd(struct ndctl_dimm *dimm,
return NULL;
}
- size = sizeof(*cmd) + sizeof(struct nd_pkg_intel);
+ size = sizeof(*cmd) + sizeof(struct nd_pkg_intel) + in_size + out_size;
cmd = calloc(1, size);
if (!cmd)
return NULL;
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next reply other threads:[~2017-12-06 22:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 22:46 Dave Jiang [this message]
2017-12-06 22:47 ` [PATCH v2 2/4] ndctl: add firmware download support functions in libndctl Dave Jiang
2017-12-15 17:39 ` Dan Williams
2017-12-15 17:55 ` Dan Williams
2017-12-06 22:47 ` [PATCH v2 3/4] ndctl: add firmware update command option for ndctl Dave Jiang
2017-12-15 18:05 ` Dan Williams
2017-12-15 18:12 ` Dan Williams
2017-12-06 22:48 ` [PATCH v2 4/4] ndctl, test: firmware update unit test Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151260039600.3630.12960859289293301854.stgit@djiang5-desk3.ch.intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.