From: Dan Williams <dan.j.williams@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v2 3/4] ndctl: add firmware update command option for ndctl
Date: Fri, 15 Dec 2017 10:12:40 -0800 [thread overview]
Message-ID: <CAPcyv4jQy=bkvOMFaUa7uUVWm8YeqTXjJHBNHTEn-PrhoTs=BQ@mail.gmail.com> (raw)
In-Reply-To: <151260047300.3630.15691857990092270462.stgit@djiang5-desk3.ch.intel.com>
On Wed, Dec 6, 2017 at 2:47 PM, Dave Jiang <dave.jiang@intel.com> wrote:
> Adding option "update-firmware" to ndctl for update firmware support from
> Intel DSM v1.6. ndctl update-firmware takes an option of -f for a firmware
> binary and a -d for the DIMM name:
> ndctl update-firmware -d nmem0 -f new_firmware.bin
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
[..]
> diff --git a/ndctl/lib/intel.c b/ndctl/lib/intel.c
> index 3ac4d3b..6d26a6c 100644
> --- a/ndctl/lib/intel.c
> +++ b/ndctl/lib/intel.c
These changes should be folded into the previous patch.
> @@ -323,7 +323,7 @@ static int intel_fw_get_info_valid(struct ndctl_cmd *cmd)
> {
> struct nd_pkg_intel *pkg = cmd->intel;
>
> - if (cmd->type != ND_CMD_CALL || cmd->status != 1
> + if (cmd->type != ND_CMD_CALL || cmd->status != 0
> || pkg->gen.nd_family != NVDIMM_FAMILY_INTEL
> || pkg->gen.nd_command != ND_INTEL_FW_GET_INFO)
> return -EINVAL;
> @@ -382,7 +382,7 @@ static int intel_fw_start_valid(struct ndctl_cmd *cmd)
> {
> struct nd_pkg_intel *pkg = cmd->intel;
>
> - if (cmd->type != ND_CMD_CALL || cmd->status != 1
> + if (cmd->type != ND_CMD_CALL || cmd->status != 0
> || pkg->gen.nd_family != NVDIMM_FAMILY_INTEL
> || pkg->gen.nd_command != ND_INTEL_FW_START_UPDATE)
> return -EINVAL;
> @@ -414,7 +414,7 @@ static struct ndctl_cmd *intel_dimm_cmd_new_fw_send(struct ndctl_dimm *dimm,
> return cmd;
> }
>
> -static int intel_fw_send_valid(struct ndctl_cmd *cmd)
> +static int intel_fw_send_set_valid(struct ndctl_cmd *cmd)
Why the name change? The way you initially had it is what I would expect.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2017-12-15 18:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 22:46 [PATCH v2 1/4] ndctl: add support to alloc_intel_cmd for variable payload Dave Jiang
2017-12-06 22:47 ` [PATCH v2 2/4] ndctl: add firmware download support functions in libndctl Dave Jiang
2017-12-15 17:39 ` Dan Williams
2017-12-15 17:55 ` Dan Williams
2017-12-06 22:47 ` [PATCH v2 3/4] ndctl: add firmware update command option for ndctl Dave Jiang
2017-12-15 18:05 ` Dan Williams
2017-12-15 18:12 ` Dan Williams [this message]
2017-12-06 22:48 ` [PATCH v2 4/4] ndctl, test: firmware update unit test Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4jQy=bkvOMFaUa7uUVWm8YeqTXjJHBNHTEn-PrhoTs=BQ@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.