From: Jerome Brunet <jbrunet@baylibre.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Kevin Hilman <khilman@baylibre.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 7/8] net: phy: meson-gxl: add interrupt support
Date: Thu, 07 Dec 2017 17:04:49 +0100 [thread overview]
Message-ID: <1512662689.7042.20.camel@baylibre.com> (raw)
In-Reply-To: <20171207155421.GJ24750@lunn.ch>
On Thu, 2017-12-07 at 16:54 +0100, Andrew Lunn wrote:
> On Thu, Dec 07, 2017 at 03:27:14PM +0100, Jerome Brunet wrote:
> > Enable interrupt support in meson-gxl PHY driver
>
> Hi Jerome
>
> Is it possible to implement did_interrupt()? That allows for shared
> interrupts. It does however work fine without it, so long as the
> interrupt is not shared.
Hi Andrew,
It is always possible ;). The irq status registers gets reset on read.
In such case, ack_interrupt() and did_interrupt() would be more or less the same
function, except for the returned value, I guess ?
The phy being internal, I think it is unlikely to ever share its interrupt
though. If you prefer I implement this callback, I can certainly re-spin with it
?
Thanks for the lightning fast review by the way !
>
> Thanks
> Andrew
WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next v2 7/8] net: phy: meson-gxl: add interrupt support
Date: Thu, 07 Dec 2017 17:04:49 +0100 [thread overview]
Message-ID: <1512662689.7042.20.camel@baylibre.com> (raw)
In-Reply-To: <20171207155421.GJ24750@lunn.ch>
On Thu, 2017-12-07 at 16:54 +0100, Andrew Lunn wrote:
> On Thu, Dec 07, 2017 at 03:27:14PM +0100, Jerome Brunet wrote:
> > Enable interrupt support in meson-gxl PHY driver
>
> Hi Jerome
>
> Is it possible to implement did_interrupt()? That allows for shared
> interrupts. It does however work fine without it, so long as the
> interrupt is not shared.
Hi Andrew,
It is always possible ;). The irq status registers gets reset on read.
In such case, ack_interrupt() and did_interrupt() would be more or less the same
function, except for the returned value, I guess ?
The phy being internal, I think it is unlikely to ever share its interrupt
though. If you prefer I implement this callback, I can certainly re-spin with it
?
Thanks for the lightning fast review by the way !
>
> Thanks
> Andrew
WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH net-next v2 7/8] net: phy: meson-gxl: add interrupt support
Date: Thu, 07 Dec 2017 17:04:49 +0100 [thread overview]
Message-ID: <1512662689.7042.20.camel@baylibre.com> (raw)
In-Reply-To: <20171207155421.GJ24750@lunn.ch>
On Thu, 2017-12-07 at 16:54 +0100, Andrew Lunn wrote:
> On Thu, Dec 07, 2017 at 03:27:14PM +0100, Jerome Brunet wrote:
> > Enable interrupt support in meson-gxl PHY driver
>
> Hi Jerome
>
> Is it possible to implement did_interrupt()? That allows for shared
> interrupts. It does however work fine without it, so long as the
> interrupt is not shared.
Hi Andrew,
It is always possible ;). The irq status registers gets reset on read.
In such case, ack_interrupt() and did_interrupt() would be more or less the same
function, except for the returned value, I guess ?
The phy being internal, I think it is unlikely to ever share its interrupt
though. If you prefer I implement this callback, I can certainly re-spin with it
?
Thanks for the lightning fast review by the way !
>
> Thanks
> Andrew
next prev parent reply other threads:[~2017-12-07 16:04 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 14:27 [PATCH net-next v2 0/8] phy: net: meson-gxl: clean-up and improvements Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` [PATCH net-next v2 1/8] net: phy: meson-gxl: check phy_write return value Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:34 ` Andrew Lunn
2017-12-07 15:34 ` Andrew Lunn
2017-12-07 15:34 ` Andrew Lunn
2017-12-07 14:27 ` [PATCH net-next v2 2/8] net: phy: meson-gxl: define control registers Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` [PATCH net-next v2 3/8] net: phy: meson-gxl: add read and write helpers for bank registers Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 15:49 ` Neil Armstrong
2017-12-07 15:49 ` Neil Armstrong
2017-12-07 15:49 ` Neil Armstrong
2017-12-07 15:51 ` Jerome Brunet
2017-12-07 15:51 ` Jerome Brunet
2017-12-07 15:51 ` Jerome Brunet
2017-12-07 16:02 ` Andrew Lunn
2017-12-07 16:02 ` Andrew Lunn
2017-12-07 16:02 ` Andrew Lunn
2017-12-08 9:11 ` Russell King - ARM Linux
2017-12-08 9:11 ` Russell King - ARM Linux
2017-12-08 9:11 ` Russell King - ARM Linux
2017-12-07 14:27 ` [PATCH net-next v2 4/8] net: phy: meson-gxl: use genphy_config_init Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 14:27 ` [PATCH net-next v2 5/8] net: phy: meson-gxl: detect LPA corruption Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:34 ` Andrew Lunn
2017-12-07 15:34 ` Andrew Lunn
2017-12-07 15:34 ` Andrew Lunn
2017-12-07 15:42 ` Jerome Brunet
2017-12-07 15:42 ` Jerome Brunet
2017-12-07 15:42 ` Jerome Brunet
2017-12-07 16:12 ` Andrew Lunn
2017-12-07 16:12 ` Andrew Lunn
2017-12-07 16:12 ` Andrew Lunn
2017-12-07 16:22 ` Jerome Brunet
2017-12-07 16:22 ` Jerome Brunet
2017-12-07 16:22 ` Jerome Brunet
2017-12-07 14:27 ` [PATCH net-next v2 6/8] net: phy: meson-gxl: leave CONFIG_A6 untouched Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:49 ` Andrew Lunn
2017-12-07 15:49 ` Andrew Lunn
2017-12-07 15:49 ` Andrew Lunn
2017-12-07 15:49 ` Andrew Lunn
2017-12-07 15:56 ` Jerome Brunet
2017-12-07 15:56 ` Jerome Brunet
2017-12-07 15:56 ` Jerome Brunet
2017-12-07 15:56 ` Jerome Brunet
2017-12-07 14:27 ` [PATCH net-next v2 7/8] net: phy: meson-gxl: add interrupt support Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:54 ` Andrew Lunn
2017-12-07 15:54 ` Andrew Lunn
2017-12-07 15:54 ` Andrew Lunn
2017-12-07 16:04 ` Jerome Brunet [this message]
2017-12-07 16:04 ` Jerome Brunet
2017-12-07 16:04 ` Jerome Brunet
2017-12-07 16:07 ` Andrew Lunn
2017-12-07 16:07 ` Andrew Lunn
2017-12-07 16:07 ` Andrew Lunn
2017-12-07 14:27 ` [PATCH net-next v2 8/8] net: phy: meson-gxl: join the authors Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:55 ` Andrew Lunn
2017-12-07 15:55 ` Andrew Lunn
2017-12-07 15:55 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512662689.7042.20.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.