From: Suganath Prabu S <suganath-prabu.subramani@broadcom.com>
To: linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org
Cc: Sathya.Prakash@broadcom.com, sreekanth.reddy@broadcom.com,
Hannes Reinecke <hare@suse.de>,
Suganath Prabu S <suganath-prabu.subramani@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>
Subject: [PATCH 04/11] mpt3sas: open-code _scsih_scsi_lookup_get()
Date: Thu, 21 Dec 2017 23:31:40 -0800 [thread overview]
Message-ID: <1513927907-19735-5-git-send-email-suganath-prabu.subramani@broadcom.com> (raw)
In-Reply-To: <1513927907-19735-1-git-send-email-suganath-prabu.subramani@broadcom.com>
From: Hannes Reinecke <hare@suse.de>
Just a wrapper around the scsi lookup array and only used
in one place, so open-code it.
Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@broadcom.com>
Signed-off-by: Chaitra P B <chaitra.basappa@broadcom.com>
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 6fea5e6..7d76e8f 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -1445,19 +1445,6 @@ _scsih_is_nvme_device(u32 device_info)
}
/**
- * _scsih_scsi_lookup_get - returns scmd entry
- * @ioc: per adapter object
- * @smid: system request message index
- *
- * Returns the smid stored scmd pointer.
- */
-static struct scsi_cmnd *
-_scsih_scsi_lookup_get(struct MPT3SAS_ADAPTER *ioc, u16 smid)
-{
- return ioc->scsi_lookup[smid - 1].scmd;
-}
-
-/**
* __scsih_scsi_lookup_get_clear - returns scmd entry without
* holding any lock.
* @ioc: per adapter object
@@ -7541,7 +7528,7 @@ _scsih_sas_broadcast_primitive_event(struct MPT3SAS_ADAPTER *ioc,
for (smid = 1; smid <= ioc->scsiio_depth; smid++) {
if (ioc->shost_recovery)
goto out;
- scmd = _scsih_scsi_lookup_get(ioc, smid);
+ scmd = ioc->scsi_lookup[smid - 1].scmd;
if (!scmd)
continue;
sdev = scmd->device;
--
2.5.5
WARNING: multiple messages have this Message-ID (diff)
From: suganath-prabu.subramani@broadcom.com (Suganath Prabu S)
Subject: [PATCH 04/11] mpt3sas: open-code _scsih_scsi_lookup_get()
Date: Thu, 21 Dec 2017 23:31:40 -0800 [thread overview]
Message-ID: <1513927907-19735-5-git-send-email-suganath-prabu.subramani@broadcom.com> (raw)
In-Reply-To: <1513927907-19735-1-git-send-email-suganath-prabu.subramani@broadcom.com>
From: Hannes Reinecke <hare@suse.de>
Just a wrapper around the scsi lookup array and only used
in one place, so open-code it.
Signed-off-by: Suganath Prabu S <suganath-prabu.subramani at broadcom.com>
Signed-off-by: Chaitra P B <chaitra.basappa at broadcom.com>
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 6fea5e6..7d76e8f 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -1445,19 +1445,6 @@ _scsih_is_nvme_device(u32 device_info)
}
/**
- * _scsih_scsi_lookup_get - returns scmd entry
- * @ioc: per adapter object
- * @smid: system request message index
- *
- * Returns the smid stored scmd pointer.
- */
-static struct scsi_cmnd *
-_scsih_scsi_lookup_get(struct MPT3SAS_ADAPTER *ioc, u16 smid)
-{
- return ioc->scsi_lookup[smid - 1].scmd;
-}
-
-/**
* __scsih_scsi_lookup_get_clear - returns scmd entry without
* holding any lock.
* @ioc: per adapter object
@@ -7541,7 +7528,7 @@ _scsih_sas_broadcast_primitive_event(struct MPT3SAS_ADAPTER *ioc,
for (smid = 1; smid <= ioc->scsiio_depth; smid++) {
if (ioc->shost_recovery)
goto out;
- scmd = _scsih_scsi_lookup_get(ioc, smid);
+ scmd = ioc->scsi_lookup[smid - 1].scmd;
if (!scmd)
continue;
sdev = scmd->device;
--
2.5.5
next prev parent reply other threads:[~2017-12-22 7:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 7:31 [PATCH 00/11] mpt3sas: Enable scsi MQ & lockless command submission Suganath Prabu S
2017-12-22 7:31 ` Suganath Prabu S
2017-12-22 7:31 ` [PATCH 01/11] mpt3sas: set default value for cb_idx Suganath Prabu S
2017-12-22 7:31 ` Suganath Prabu S
2017-12-22 7:31 ` [PATCH 02/11] mpt3sas: use list_splice_init() Suganath Prabu S
2017-12-22 7:31 ` Suganath Prabu S
2017-12-22 7:31 ` [PATCH 03/11] mpt3sas: separate out _base_recovery_check() Suganath Prabu S
2017-12-22 7:31 ` Suganath Prabu S
2017-12-22 7:31 ` Suganath Prabu S [this message]
2017-12-22 7:31 ` [PATCH 04/11] mpt3sas: open-code _scsih_scsi_lookup_get() Suganath Prabu S
2017-12-22 7:31 ` [PATCH 05/11] mpt3sas: Introduce mpt3sas_get_st_from_smid() Suganath Prabu S
2017-12-22 7:31 ` Suganath Prabu S
2017-12-22 7:31 ` [PATCH 06/11] mpt3sas: check command status before attempting abort Suganath Prabu S
2017-12-22 7:31 ` Suganath Prabu S
2017-12-22 7:31 ` [PATCH 07/11] mpt3sas: always use first reserved smid for ioctl passthrough Suganath Prabu S
2017-12-22 7:31 ` Suganath Prabu S
2017-12-22 7:31 ` [PATCH 08/11] mpt3sas: simplify task management functions Suganath Prabu S
2017-12-22 7:31 ` Suganath Prabu S
2017-12-22 7:31 ` [PATCH 09/11] mpt3sas: simplify mpt3sas_scsi_issue_tm() Suganath Prabu S
2017-12-22 7:31 ` Suganath Prabu S
2017-12-22 7:31 ` [PATCH 10/11] mpt3sas: simplify _wait_for_commands_to_complete() Suganath Prabu S
2017-12-22 7:31 ` Suganath Prabu S
2017-12-22 7:31 ` [PATCH 11/11] mpt3sas: lockless command submission Suganath Prabu S
2017-12-22 7:31 ` Suganath Prabu S
2017-12-22 7:54 ` [PATCH 00/11] mpt3sas: Enable scsi MQ & " Hannes Reinecke
2017-12-22 7:54 ` Hannes Reinecke
2018-01-04 4:07 ` Martin K. Petersen
2018-01-04 4:07 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513927907-19735-5-git-send-email-suganath-prabu.subramani@broadcom.com \
--to=suganath-prabu.subramani@broadcom.com \
--cc=Sathya.Prakash@broadcom.com \
--cc=chaitra.basappa@broadcom.com \
--cc=hare@suse.de \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sreekanth.reddy@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.